Fix to ember-validations to accept 'content' property

lcoq / ember-validations

Ember-Validations - An Ember.js library for handling object validations

MIT License

122 stars 25 forks source link

Fix to ember-validations to accept 'content' property #14

Closed gabesmed closed 11 years ago

gabesmed commented 11 years ago

Hi Louis!

Thanks for writing this library! I've found it useful and incorporated it into my projects.

I made one small fix, where the current implementation doesn't like to nest errors inside any property that is also named 'content' -- this property conflicts with the ValidationError class's 'content' property. So I renamed the ValidationError's properties from 'content' and 'nestedErrors' to '_content' and '_nestedErrors'. And added a test.

Hope this helps!

-Gabe

lcoq commented 11 years ago

Nice! It seems to work. Could you rebase before merging please ?

gabesmed commented 11 years ago

Happy to -- but don't I need write access to your repository in order to rebase/merge? Sorry, I'm a bit inexperienced with rebasing.

gabesmed commented 11 years ago

hmm.. i don't think that worked as i'd hoped

lcoq commented 11 years ago

No problem, I fixed it. Merged in ac21b161b

Thank you!