mokutil bugfix: del unused opt "-s"

lcp / mokutil

The utility to manipulate machine owner keys

GNU General Public License v3.0

60 stars 37 forks source link

mokutil bugfix: del unused opt "-s" #54

Closed Yusong-Gao closed 2 years ago

Yusong-Gao commented 2 years ago

The -s option can cause unexcepted result.

Signed-off-by: gaoyusong gaoyusong2@huawei.com

Yusong-Gao commented 2 years ago

Reference: https://github.com/lcp/mokutil/commit/d02bf6392d1ea6ae0f8540b98cdc60af06892a11

This commit remove "--simple-hash" but not remove "-s" option in getopt_long(), so when i use command begin with "-s" like "mokutil -state" the unexpected abort happen.

Yusong-Gao commented 2 years ago

@lcp @frozencemetery

Yusong-Gao commented 2 years ago

Code looks fine.

(Typos in commit message: "unused", "unexpected")

ok, i fix it

lcp commented 2 years ago

Good catch. Thanks for the patch.

lcp commented 2 years ago

oops. Just found "unexpected" in the commit message wasn't fixed. Anyway, what's done is done.