search

lcpojr / watcher_ex

An Oauth2 server interelly in elixir.
Apache License 2.0
10 stars 3 forks source link

docs: readme asdf #50

Closed dcdourado closed 1 year ago

dcdourado commented 3 years ago

Hello guys,

This PR adds instructions and info of asdf to newcomers to the project. Started this a while ago, and I'm not sure about the grouping comments, what's your opinion about it?

lcpojr commented 3 years ago

Could you please update this branch from master aggain? I've fixed the CI crypto problem.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 84.438% when pulling ce80df81610a6e9b77612911aac2a6d6cf4de8d5 on dcdourado:master into ab6834ad5e22fc6da9b89397a6b69a1cfffed885 on lcpojr:master.

dcdourado commented 3 years ago

Hey @lcpojr can we remove the dialyzer step from the CI? It's really messing around. I also would suggest removing WIP — Ready for review, as it doesn't do a lot...

dcdourado commented 3 years ago

Hey @lcpojr can we remove the dialyzer step from the CI? It's really messing around. I also would suggest removing WIP — Ready for review, as it doesn't do a lot...

The cache is hitting but it still does find the dialyzer.plt file. Any thoughts?

lcpojr commented 3 years ago

I've finally fixed the dialyzer flow on CI. It was not generating the PLT because of permissions, linux versions and so on ... but now it's fixed on master.

The dialyzer and plt folders has to exists in order to avoid compiling every single commit all dependencies.

Sorry for all the trouble, i know it's a pain sometimes but it also helps a lot avoid mistakes with types and returns (i got some on my last pull request) and i think now that it's fixed we will more use of it.

O and i think we could make use of WIP or an label :)

lcpojr commented 3 years ago

@dcdourado try to update from master aggain. It worked on my another PR.