search

lcpp-org / RustBCA

A free, open-source Binary Collision Approximation (BCA) code for ion-material interactions including sputtering, implantation, and reflection
https://github.com/lcpp-org/RustBCA/wiki
GNU General Public License v3.0
41 stars 14 forks source link

[JOSS Review] - File name of examples does not match those in manuscript #136

Closed joglekara closed 3 years ago

joglekara commented 3 years ago

Description File name of examples does not match those in manuscript

To Reproduce cargo run --release examples/layered_target.toml cargo run --release examples/layered_target_1D.toml

Expected behavior A clear and concise description of what you expected to happen. Run the example

Error messages, output files, or figures Please include error messages, output files or figures that demonstrate the error if applicable. thread 'main' panicked at 'Input errror: could not open input file examples/layered_target.toml.: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/input.rs:184:10

System (please complete the following information): OS:

Additional context I am not clear on which filename would be preferable so leaving it up to @drobnyjt to determine if the change needs to be in the manuscript or in the example file name

drobnyjt commented 3 years ago

Sorry for the delay - recently relocated across the country and am still getting my bearings. I'll tackle this now.