Before submitting this PR, please make sure you have:
[X] Opened an issue
[X] Referenced the relevant issue number(s) below
[X] Provided a description of the changes below
[X] Ensured all tests pass and added any necessary tests for new code
Fixes #216
Description
This changes the order of energy subtraction in the weak collision loop; there may be a problem with energy conservation leading to unphysical sputtering yields when weak collisions are on and Z1>>Z2.
Tests
cargo test runs fine. I need to do a comprehensive comparison of near-threshold sputtering yield curves.
Thank you for your contribution to rustBCA!
Before submitting this PR, please make sure you have:
Fixes #216
Description
This changes the order of energy subtraction in the weak collision loop; there may be a problem with energy conservation leading to unphysical sputtering yields when weak collisions are on and Z1>>Z2.
Tests
cargo test runs fine. I need to do a comprehensive comparison of near-threshold sputtering yield curves.