lcpp-org / crane

A MOOSE application dedicated to general Chemical ReAction NEtworks for plasma chemistry and thermochemistry problems.
https://crane-plasma-chemistry.readthedocs.io/
GNU Lesser General Public License v2.1
21 stars 20 forks source link

Fix deprecations #107

Closed cticenhour closed 1 year ago

cticenhour commented 1 year ago

This PR:

Tagging @smpeyres for a review.

cticenhour commented 1 year ago

Feel free to merge whenever - Zapdos CI checks for CRANE updates weekly on Friday evening.

smpeyres commented 1 year ago

@cticenhour Tried to merge earlier - something about signing commits is blocking the merge. Never had to do this before -- I'll try to figure it out tomorrow afternoon!

smpeyres commented 1 year ago

@cticenhour The merge is blocked because "the base branch requires all commits to be signed". From what I can tell from https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits, it seems you would have to sign each of the commits...

Since you have already committed them, maybe there is a work around? @dcurreli This signed commit thing seems new...

cticenhour commented 1 year ago

This setting is part of the repository branch protection rules and has to be turned on manually. Did those settings change recently?

smpeyres commented 1 year ago

It seems so... Wasn't my doing!

cticenhour commented 1 year ago

@smpeyres Alright....since I don't want to wait on this anymore, I have signed these commits on my local machine, so this is ready to be merged.

smpeyres commented 1 year ago

@smpeyres Alright....since I don't want to wait on this anymore, I have signed these commits on my local machine, so this is ready to be merged.

Can't blame you, but I'm able to merge now. Thank you!