Closed cticenhour closed 1 year ago
Feel free to merge whenever - Zapdos CI checks for CRANE updates weekly on Friday evening.
@cticenhour Tried to merge earlier - something about signing commits is blocking the merge. Never had to do this before -- I'll try to figure it out tomorrow afternoon!
@cticenhour The merge is blocked because "the base branch requires all commits to be signed". From what I can tell from https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits, it seems you would have to sign each of the commits...
Since you have already committed them, maybe there is a work around? @dcurreli This signed commit thing seems new...
This setting is part of the repository branch protection rules and has to be turned on manually. Did those settings change recently?
It seems so... Wasn't my doing!
@smpeyres Alright....since I don't want to wait on this anymore, I have signed these commits on my local machine, so this is ready to be merged.
@smpeyres Alright....since I don't want to wait on this anymore, I have signed these commits on my local machine, so this is ready to be merged.
Can't blame you, but I'm able to merge now. Thank you!
This PR:
.gitignore
file in order to ignore new YAML files for metadata generated duringmake
as well as a dotfolder produced by VSCode.ModulesApp::registerAll(...)
method inCraneApp.C
toModulesApp::registerAllObjects<CraneApp>(...)
, which is now preferred for dynamic linking. This one is affecting Zapdos as well.[TimeStepper]
block syntax to that of[TimeSteppers]
Tagging @smpeyres for a review.