search

lcpp-org / crane

A MOOSE application dedicated to general Chemical ReAction NEtworks for plasma chemistry and thermochemistry problems.
https://crane-plasma-chemistry.readthedocs.io/
GNU Lesser General Public License v2.1
21 stars 20 forks source link

Remove trailing whitespaces from scripts #115

Closed cticenhour closed 10 months ago

cticenhour commented 11 months ago

Refs #86

@dcurreli It appears as though there was a delay in CI for #114. See those results here: https://civet.inl.gov/pr/19708/. Still have a couple failures that my last run-through missed. Let's see how this one does.

In order for testing to auto-start for me (and not require manual activation on your part), you will need to add me as an outside collaborator of CRANE in the repository Settings menu.

cticenhour commented 11 months ago

Precheck success! Next we should activate the regular testing to make sure all is well there. You can do this manually by signing in to CIVET using your GitHub credentials (upper right) and navigating to this page to press the activate button, or the collaborator option I mentioned earlier (then I can activate the tests myself and they will auto-start for me in future PRs).

cticenhour commented 11 months ago

@dcurreli FYI - I have turned on automatic devel branch merges to master on CIVET. You will need to add the @moosebuild user as an external collaborator to CRANE with Write permissions in order for it to fully work. When you have time, let's proceed with testing on this PR, so we can confirm everything else is working well.

dcurreli commented 11 months ago

@cticenhour I have added @moosebuild as an external collaborator to CRANE with write permissions.

cticenhour commented 11 months ago

Great - did you activate testing as well? If not, please activate the testing through CIVET (see below for an example from MOOSE, showing the "Activate all Jobs" button when clicking on the testing Event), or add me as a Collaborator to CRANE in order to automatically activate it.

image
dcurreli commented 11 months ago

@cticenhour Just added you as a Collaborator to the CRANE repo with Write permission.

cticenhour commented 11 months ago

@dcurreli I was just notified by one of our CIVET administrators that you need to give application permission to CIVET to finish this off (there was an error in the logs related to this PR that this should resolve). The request should be in your email!

Otherwise, testing is activated and proceeding: https://civet.inl.gov/pr/19710/

cticenhour commented 11 months ago

@dcurreli CI tests are passing, so this PR is ready for review and merge, independent of the CIVET issue above. That can be discussed further in our email exchange.

dcurreli commented 11 months ago

Great.

cticenhour commented 10 months ago

@smpeyres Pinging for a review and merge. See testing status at https://civet.inl.gov/pr/19710/

smpeyres commented 10 months ago

Looks good!

@cticenhour What do now regarding CIVET?

cticenhour commented 10 months ago

Everything related to automated testing works well now. We'll find out about automatic merges from devel to master soon when this merged PR completes devel branch testing. Automatic status updates within the PR requires some extra permissions, and that's something we're discussing with @dcurreli on the INL side. So nothing more to do on CI for the moment.