search

lcpp-org / crane

A MOOSE application dedicated to general Chemical ReAction NEtworks for plasma chemistry and thermochemistry problems.
https://crane-plasma-chemistry.readthedocs.io/
GNU Lesser General Public License v2.1
21 stars 20 forks source link

Add default value for vector type input parameters #116

Closed MengnanLi91 closed 10 months ago

MengnanLi91 commented 11 months ago

Bug Description

Refer to the issue #24455, a fix is introduced to MOOSE to properly report error when no default value is provided for vector type input parameter. This new fix in MOOSE cause several tests failed in Crane which don't provide default value for vector parameter.

Impact

This patch is made to fix the failed Crane tests due to the new changes in MOOSE

cticenhour commented 11 months ago

Pinging @smpeyres @dcurreli for review. This is necessary for the MOOSE PR mentioned in @MengnanLi91's message above to be merged.

MengnanLi91 commented 11 months ago

Compiles & tests successfully, but compilation gives warning for line 904 in ChemicalReactionsBase.C regarding unused label ‘std’ [-Wunused-label] for std:string error_str

Thanks for the review. I've removed the unused label and tested compiling

smpeyres commented 11 months ago

Thanks for the quick change! Compiles without warning and tests pass. Waiting to merge until CI is online for CRANE.

cticenhour commented 10 months ago

@MengnanLi91 if you rebase on top of CRANE devel, this should pass precheck testing. I can then activate testing for you.

MengnanLi91 commented 10 months ago

@MengnanLi91 if you rebase on top of CRANE devel, this should pass precheck testing. I can then activate testing for you.

Thanks Casey! I'll rebase and tag you to activate the testing.

MengnanLi91 commented 10 months ago

@cticenhour Could you help me with testing?

cticenhour commented 10 months ago

@smpeyres This is passing testing and is ready to be merged. See https://civet.inl.gov/pr/19853/.