search

lcpp-org / crane

A MOOSE application dedicated to general Chemical ReAction NEtworks for plasma chemistry and thermochemistry problems.
https://crane-plasma-chemistry.readthedocs.io/
GNU Lesser General Public License v2.1
21 stars 20 forks source link

Clean up main.C and explicitly register dependent app #124

Closed MengnanLi91 closed 7 months ago

MengnanLi91 commented 7 months ago

Adapt to the new changes in MOOSE(https://github.com/idaholab/moose/pull/25994)

MengnanLi91 commented 7 months ago

@MengnanLi91 as CRANE doesn't receive automatic submodule updates, you will need to update the submodule to a newer MOOSE master commit to fix the current CI failures.

Thanks for the reminder! I totally forgot about this. Just did it.

moosebuild commented 7 months ago

Job Mac Test on ff0f632 : invalidated by @cticenhour

Conda package moose-wasp added to recipe

cticenhour commented 7 months ago

@MengnanLi91 could you sign these commits? That's the final requirement before this can be merged. If you don't know how, I can assist, though likely not until late today or when I am back in the office tomorrow.

loganharbour commented 7 months ago

@cticenhour good to go.