search

lcpp-org / crane

A MOOSE application dedicated to general Chemical ReAction NEtworks for plasma chemistry and thermochemistry problems.
https://crane-plasma-chemistry.readthedocs.io/
GNU Lesser General Public License v2.1
21 stars 20 forks source link

Correct file path management #125

Closed loganharbour closed 5 months ago

loganharbour commented 5 months ago

refs idaholab/moose#26947

Requires https://github.com/idaholab/moose/pull/27143 and is in support of https://github.com/idaholab/moose/issues/26947

All file_location parameters are set to the FileName type, which eventually will be auto filled with the correct absolute path to the file base. For objects that have a default, the default is set to . (cwd of the input file). All property_file parameters are set to the RelativeFileName type, which means don't have their absolute paths resolved so you can do <file_location>/<property_file>.

moosebuild commented 5 months ago

Job Precheck on 1944998 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/crane/docs/PRs/125/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 9b883c5c1e394b6ecb09ab2d688240a523d24e6c

loganharbour commented 5 months ago

@cticenhour this is ready for review. Zapdos passes all tests with https://github.com/shannon-lab/zapdos/pull/240.

cticenhour commented 5 months ago

Test results: https://civet.inl.gov/pr/21435/