search

lcpp-org / crane

A MOOSE application dedicated to general Chemical ReAction NEtworks for plasma chemistry and thermochemistry problems.
https://crane-plasma-chemistry.readthedocs.io/
GNU Lesser General Public License v2.1
21 stars 20 forks source link

Clean up code to remove compiler warnings #24

Closed lindsayad closed 5 years ago

lindsayad commented 5 years ago

@keniley1 Are you interested in following the MOOSE code style guide? What editor do you use?

keniley1 commented 5 years ago

@lindsayad I am interested, yes! I use Atom, and I honestly thought I was following the MOOSE style guide. I was certainly trying to, at any rate.

lindsayad commented 5 years ago

Well, we can remove the try! You can install the clang-format plugin for atom and enable it to automatically run when you save. Some instructions with a link to the plugin are here: https://mooseframework.inl.gov/help/development/Atom_Editor.html.

Most of the changes in this PR are from clang-formatting. I could go back and disable my formatter and add only the changes for disabling warnings if you would prefer.

keniley1 commented 5 years ago

No, this is perfect! Thanks for the link. I'll try to conform to clang-formatting from now on.

This PR looks good, so I'll go ahead and merge.

keniley1 commented 5 years ago

Forgot to say this, but thank you very much for this PR @lindsayad. You were my first external contributor! 🥇

lindsayad commented 5 years ago

Haha sweet! I always like checking out our applications!

On Tue, May 21, 2019 at 10:52 AM Shane Keniley notifications@github.com wrote:

Forgot to say this, but thank you very much for this PR @lindsayad https://github.com/lindsayad. You were my first external contributor! 🥇

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lcpp-org/crane/pull/24?email_source=notifications&email_token=ACOGA4FF77HPKNH5SJAFJB3PWQSEPA5CNFSM4HOE7JW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV4QUWQ#issuecomment-494471770, or mute the thread https://github.com/notifications/unsubscribe-auth/ACOGA4DYIEXOABJ2BCMFMRTPWQSEPANCNFSM4HOE7JWQ .