search

lcpp-org / crane

A MOOSE application dedicated to general Chemical ReAction NEtworks for plasma chemistry and thermochemistry problems.
https://crane-plasma-chemistry.readthedocs.io/
GNU Lesser General Public License v2.1
21 stars 20 forks source link

Update for API changes #58

Closed dschwen closed 4 years ago

dschwen commented 4 years ago

I renamed ADFunction to SymFunction to avoid confusion with upcoming AD'ified function objects. FunctionParserUtils is now a template that takes a bool parameter, choosing between a regular and a dual number version (forward mode AD).

This should probably get merged after https://github.com/idaholab/moose/pull/15331 is in

Closes #57

keniley1 commented 4 years ago

Thank you very much! ADParsedMaterials will be a great tool for Zapdos/Crane.

(This also closes #53 , or at least makes it irrelevant.)

dschwen commented 4 years ago

Moose PR is in. I don't see a moose submodule here, so this can probably get merged. @lindsayad may know more on how to get Zapdos updated (do we need to manually update the crane submodule there?)

keniley1 commented 4 years ago

(do we need to manually update the crane submodule there?)

Yeah, that's typically how we do it. Update crane, and then submit a PR to update the crane submodule in Zapdos.

Thanks again!