search

lcpp-org / crane

A MOOSE application dedicated to general Chemical ReAction NEtworks for plasma chemistry and thermochemistry problems.
https://crane-plasma-chemistry.readthedocs.io/
GNU Lesser General Public License v2.1
21 stars 20 forks source link

Remove unused variables in AddReactions.C #68

Closed cticenhour closed 3 years ago

cticenhour commented 3 years ago

Fixes up some warnings experienced when updating the crane submodule in shannon-lab/zapdos#83.

Ping @keniley1 for review and merge.

keniley1 commented 3 years ago

Thanks for this @cticenhour, and sorry for the warnings! There is a lot of sloppiness in Crane that I just haven't gotten around to fixing because it's been "good enough". I should really sit down and finish cleaning this up.

cticenhour commented 3 years ago

It's all good! I have warnings set to throw errors in the CIVET testing. I just realized as a result of Logan's PR that the crane submodule hadn't been updated since the summer, so four unused variable warnings is pretty good to me! :D