Add new templates in support of Zapdos AD conversion

lcpp-org / crane

A MOOSE application dedicated to general Chemical ReAction NEtworks for plasma chemistry and thermochemistry problems.

https://crane-plasma-chemistry.readthedocs.io/

GNU Lesser General Public License v2.1

21 stars 20 forks source link

Add new templates in support of Zapdos AD conversion #72

Closed cticenhour closed 3 years ago

cticenhour commented 3 years ago

Updates the following classes to AD templates and cleans extraneous code and comment cruft:

ReactionSecondOrderLog
ReactionThirdOrderLog
GenericRateConstant

@keniley1 This change is in support of converting Zapdos to AD (specifically, to fixup the shooting method acceleration tests). Refs shannon-lab/zapdos#80

keniley1 commented 3 years ago

Looks good. Thanks for this -- I was actually wondering how to add optional AD kernels, and these templates answered that question!

cticenhour commented 3 years ago

No problem - thanks for the merge! It took me a bit to figure out - some of the module kernels that do this create their own intermediary parent class, but GenericKernel was thankfully ready to go! Just had to get all of the types correct.