search

lcpp-org / crane

A MOOSE application dedicated to general Chemical ReAction NEtworks for plasma chemistry and thermochemistry problems.
https://crane-plasma-chemistry.readthedocs.io/
GNU Lesser General Public License v2.1
21 stars 20 forks source link

Add moose submodule #87

Closed cticenhour closed 1 year ago

cticenhour commented 1 year ago

Refs #86

smpeyres commented 1 year ago

There seem to be some checks that are failing associated with this. Tests ran fine. @cticenhour You'll probably know something about this...

cticenhour commented 1 year ago

Seems GitHub pages thinks it needs to dive all the way down into the submodule to render the README.md file as a webpage.....which is silly. The Jekyll site builder that GitHub Pages uses doesn't like file symlinks, so it fails. I think I can fix this by adding a _config.yml file to CRANE excluding the MOOSE submodule (see here)

@dcurreli before I do this, do you configure your GitHub Pages usage for CRANE at the organization level? Maybe we can exclude there. We don't run into this with Zapdos because we have a gh-pages branch that is independent of the other branches for the Pages deployment to use.

smpeyres commented 1 year ago

@cticenhour After talking to @dcurreli , he said any webpages that exist for CRANE are old and experimental, and can be removed. I don't know if this is exactly the same as GitHub Pages, but I hope this helped!

cticenhour commented 1 year ago

This seems to be an automated thing - as a gh-pages branch doesn't exist GitHub simply generates one from the README.md file. So really we don't need to do anything - letting it fail for now is fine.

If you decide that you want to have a website generated based on the source code, I have an automatic GitHub action that generates the website for Zapdos using MooseDocs we can talk more about later.