lcpz / lain

Awesome WM complements
GNU General Public License v2.0
1.06k stars 212 forks source link

Fixed require statements #525

Open Trial97 opened 2 years ago

Trial97 commented 2 years ago

The require statements should be dynamic in order to place this project in another folder other than the root config folder

lcpz commented 2 years ago

Thank you for your work. Please see my review.

Before merging, can please you ensure that you tested every widget, layout and utility?

Maybe you can help me with #527 as well.

Trial97 commented 2 years ago

Thanks for the review. I reverted the change. Regarding testing everything it will take me some time as I just started learning lua and awesomewm. As regards #527 can you elaborate? It is enough for the files to only have the require statement in them? e.g.lain-test-quake.lua

local lain      = require('extra.lain')
return lain.util.quake({
    app = 'kitty',
    name = "QuakeDD",
    argname = "--name %s",
    followtag = true,
    settings = function(c)  ...    end
    extra = '',
    border = 1,
    visible = false,
    overlap = false,
    screen = awful.screen.focused(),
    height = 0.25,
    width = 1,
    vert = "top",
    horiz = "left"
})
lcpz commented 2 years ago

As regards #527 can you elaborate? It is enough for the files to only have the require statement in them?

Unfortunately not, we need to call in each of them all possible functions/widgets with all possible arguments to see if anything breaks in a new commit.

Regarding testing everything it will take me some time as I just started learning lua and awesomewm.

The reason why I mentioned #527 is that if we solve that one, we can also check the validity of this PR.

Trial97 commented 1 year ago

Ok, a small update to this:

Let me know if there are some changes that need to be done regarding tests(if not I will continue adding them in the same manner if I have time)

docs for the future :D