search

lcsc-capstone / lcsc-ionic-app

LCSC's new app, built by CS and Web Dev students
0 stars 1 forks source link

Add calendar Event #180

Closed ninamariepeterson closed 6 years ago

ninamariepeterson commented 6 years ago

Adding to my calendar is not working for academic calendar. It does work for the events.

ninamariepeterson commented 6 years ago

It may have to do with the 12:00AM time?

ajwhite2206 commented 6 years ago

That's weird both the calendars use the same code so I don't know why one wouldn't work. I'll take a look after work.

Have you tried adding that same event from the calendar tab where all the calendars are listed?

ninamariepeterson commented 6 years ago

I was tried to add from the home page for both an academic calendar event and from the home page for a regular event. I really think it might have to do with 12:00am.

From: ajwhite2206 notifications@github.com Reply-To: lcsc-capstone/lcsc-ionic-app reply@reply.github.com Date: Friday, April 20, 2018 at 12:35 PM To: lcsc-capstone/lcsc-ionic-app lcsc-ionic-app@noreply.github.com Cc: "Nina M. Peterson" nmpeterson@lcsc.edu, Author author@noreply.github.com Subject: Re: [lcsc-capstone/lcsc-ionic-app] Add calendar Event (#180)

That's weird both the calendars use the same code so I don't know why one wouldn't work. I'll take a look after work.

Have you tried adding that same event from the calendar tab where all the calendars are listed?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/lcsc-capstone/lcsc-ionic-app/issues/180#issuecomment-383199647, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALf3wAMf955DHGEqalnCnwcXNxsbudwMks5tqjhxgaJpZM4Td-al.

ninamariepeterson commented 6 years ago

I tried adding the same event from events (that is an academic event) and it doesn't add. I think it is because it is from 12:00AM to 12:00AM.

ninamariepeterson commented 6 years ago

Casey and I were discussing it. It seems that the only thing that we can think of if the startDate == endDate and startTime == endTime then set endTime = 11:50PM. How does that sound? Nina

From: ajwhite2206 notifications@github.com Reply-To: lcsc-capstone/lcsc-ionic-app reply@reply.github.com Date: Friday, April 20, 2018 at 12:35 PM To: lcsc-capstone/lcsc-ionic-app lcsc-ionic-app@noreply.github.com Cc: "Nina M. Peterson" nmpeterson@lcsc.edu, Author author@noreply.github.com Subject: Re: [lcsc-capstone/lcsc-ionic-app] Add calendar Event (#180)

That's weird both the calendars use the same code so I don't know why one wouldn't work. I'll take a look after work.

Have you tried adding that same event from the calendar tab where all the calendars are listed?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/lcsc-capstone/lcsc-ionic-app/issues/180#issuecomment-383199647, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALf3wAMf955DHGEqalnCnwcXNxsbudwMks5tqjhxgaJpZM4Td-al.

mjensenlcsc commented 6 years ago

This should be fixed in #186 once it gets accepted. The issue was that it was adding the first event from the event list instead of the first academic event.