search

lcsc-capstone / lcsc-ionic-app

LCSC's new app, built by CS and Web Dev students
0 stars 1 forks source link

Build building hours pages #183

Closed weonthank closed 6 years ago

weonthank commented 6 years ago

Wow! That was fast! -nic

ninamariepeterson commented 6 years ago

Something broke.

        Property 'saturdayClosed' does not exist on type 'BuildingDetailsPage'. Did you mean 'saturdayClose'?

  L21:  if (this.building.saturday.close == 'closed') {

  L22:    this.saturdayClosed = true;

From: weonthank notifications@github.com Reply-To: lcsc-capstone/lcsc-ionic-app reply@reply.github.com Date: Friday, April 20, 2018 at 1:42 PM To: lcsc-capstone/lcsc-ionic-app lcsc-ionic-app@noreply.github.com Cc: "Nina M. Peterson" nmpeterson@lcsc.edu, State change state_change@noreply.github.com Subject: Re: [lcsc-capstone/lcsc-ionic-app] Build building hours pages (#183)

Wow! That was fast!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/lcsc-capstone/lcsc-ionic-app/pull/183#issuecomment-383216728, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALf3wLg2GAhVOt6YABi7JxW2PgEn6mBRks5tqkg0gaJpZM4TeD-K.

ninamariepeterson commented 6 years ago

Casey fixed the typo Will.

ninamariepeterson commented 6 years ago

There are two arrows on the iOS Building Hours page. Please add something that detects if it an iOS or android and only adds an arrow to the android. Thanks.