search

lcuis / search_choices

Widget to let the user search through a keyword string typed on a customizable keyboard in a single or multiple choices list presented as a dropdown in a dialog box or a menu.
MIT License
49 stars 40 forks source link

SearchChoices Padding #80

Closed osmanybg closed 2 years ago

osmanybg commented 2 years ago

The padding property is a double and the value specified is applied to all sides. I suggest padding type be changed to EdgeInsets so we can specify different padding values for each side, being able, for instance, to set left padding to 0 and the rest to 10, so the content is aligned with the label as every other field in the form.

lcuis commented 2 years ago

Thanks @osmanybg for this good suggestion. One backward compatible way to achieve this would be to make this argument dynamic and accept either a double or the type you mentioned.

lcuis commented 2 years ago

Hi @osmanybg ,

I completed your request as commit https://github.com/lcuis/search_choices/commit/6c05345c0144b82034f98997ba7067f51f950ee3

I will try to publish soon to pub.dev .

In the meanwhile, you can use the latest GitHub repository code with the following in your pubspec.yaml:

  search_choices:
    git:
      url: https://github.com/lcuis/search_choices.git
lcuis commented 2 years ago

Version 2.0.21 is published on pub.dev . The following now should be fine in pubspec.yaml:

  search_choices:
lcuis commented 2 years ago

Closing for inactivity. Feel free to reopen if needed.