Closed bzizou closed 7 months ago
Nice, very simple and straightforward solution! Thank you @bzizou!
Thank you for the merge! Could you then update the Genesis submodule on Grenedalf?
Done, on the grenedalf dev
branch now :-)
Master branch will have to wait until I'm done with my current refactoring though. Hope that works for you.
Great, we can prepare the package to be ready for your next release, and PR it upstream at the same time. I'll test this on your dev branch...
Sounds good. What would you need for that? I am currently working on refactoring several parts within genesis and grenedalf for a next 0.4.0 release of grenedalf, hopefully in the next couple of weeks. Is that a time frame that works for you, or do you want to be quicker than that? If so, how can I help, so that you don't have to wait too long?
Time frame is ok for me! My user is already using the package from my branch (I installed it into her Nix profile). No need to push it upstream right now. I can wait for you to stabilize 0.4.0, and just tell me before releasing, so I can adapt the package and suggest the tuning if needed.
Okay, hopefully I'll remember :-)
What exactly will you need to do prior to the release though? Anything we can do already now?
This patch allows to call cmake with
-DHTSLIB_DIR=<path>
to give the path of an external htslib build. This will make the work-in-progress Genesis Nix package simpler (no more need of a patch) and more robust to Genesis upgrades.See https://github.com/lczech/grenedalf/issues/19