search

lczech / genesis

A library for working with phylogenetic and population genetic data.
http://genesis-lib.org/
GNU General Public License v3.0
57 stars 12 forks source link

Disable the local build of htslib if HTSLIB_DIR is provided #10

Closed bzizou closed 7 months ago

bzizou commented 7 months ago

This patch allows to call cmake with -DHTSLIB_DIR=<path> to give the path of an external htslib build. This will make the work-in-progress Genesis Nix package simpler (no more need of a patch) and more robust to Genesis upgrades.

See https://github.com/lczech/grenedalf/issues/19

lczech commented 7 months ago

Nice, very simple and straightforward solution! Thank you @bzizou!

bzizou commented 7 months ago

Thank you for the merge! Could you then update the Genesis submodule on Grenedalf?

lczech commented 7 months ago

Done, on the grenedalf dev branch now :-)

Master branch will have to wait until I'm done with my current refactoring though. Hope that works for you.

bzizou commented 7 months ago

Great, we can prepare the package to be ready for your next release, and PR it upstream at the same time. I'll test this on your dev branch...

lczech commented 7 months ago

Sounds good. What would you need for that? I am currently working on refactoring several parts within genesis and grenedalf for a next 0.4.0 release of grenedalf, hopefully in the next couple of weeks. Is that a time frame that works for you, or do you want to be quicker than that? If so, how can I help, so that you don't have to wait too long?

bzizou commented 7 months ago

Time frame is ok for me! My user is already using the package from my branch (I installed it into her Nix profile). No need to push it upstream right now. I can wait for you to stabilize 0.4.0, and just tell me before releasing, so I can adapt the package and suggest the tuning if needed.

lczech commented 7 months ago

Okay, hopefully I'll remember :-)

What exactly will you need to do prior to the release though? Anything we can do already now?

bzizou commented 7 months ago

I need nothing actually... it already works! Here is the resulting package No more hacky patches ;-) Once you release, I just have to uncomment this line , remove the commit rev line and update the hash.