lczub / TestLink-API-Python-client

A Python client to use the TestLink API
104 stars 63 forks source link

Allow to explicitly disable a http_proxy #121

Closed janLo closed 4 years ago

janLo commented 5 years ago

The current code always sets the http proxy from the http_proxy variable in the current environment. This makes testing difficult in setups where testlink runs locally but the internet is only available via a proxy.

This allows the user to explicitly set proxy=False in the TestLinkHelper instantiation.

lczub commented 5 years ago

Hello Jan Lesonski, thanks for your suggestion. Please apologize, that I can check it not before next week. Regards Luiko

Am 1. Juli 2019 12:51:18 MESZ schrieb Jan Losinski notifications@github.com:

The current code always sets the http proxy from the http_proxy variable in the current environment. This makes testing difficult in setups where testlink runs locally but the internet is only available via a proxy.

This allows the user to explicitly set proxy=False in the TestLinkHelper instantiation. You can view, comment on, or merge this pull request online at:

https://github.com/lczub/TestLink-API-Python-client/pull/121

-- Commit Summary --

  • Allow to explicitly disable a http_proxy

-- File Changes --

M src/testlink/testlinkhelper.py (2)

-- Patch Links --

https://github.com/lczub/TestLink-API-Python-client/pull/121.patch https://github.com/lczub/TestLink-API-Python-client/pull/121.diff

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/lczub/TestLink-API-Python-client/pull/121

-- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

lczub commented 4 years ago

Hello Jan,

I added a test test_connect_ignoring_proxy_env in c92903c. Does it covers your requirement?

Regards Luiko