lczub / TestLink-API-Python-client

A Python client to use the TestLink API
105 stars 63 forks source link

[BestPractices] Pylint fixes, testlinkapi.py #92

Closed netzulo closed 6 years ago

netzulo commented 6 years ago

Going to fix this, cleaning code on main repo

D:\4.developmentWorkSpaces\1.GITHUB\TestLink-API-Python-client\src\testlink>pylint testlinkapi.py
No config file found, using default configuration
************* Module testlink.testlinkapi
C:  4, 0: Line too long (102/100) (line-too-long)
C: 29, 0: Trailing whitespace (trailing-whitespace)
C: 30, 0: Trailing whitespace (trailing-whitespace)
C: 32, 0: Trailing whitespace (trailing-whitespace)
C: 33, 0: Trailing whitespace (trailing-whitespace)
C: 38, 0: Trailing whitespace (trailing-whitespace)
C: 41, 0: Trailing whitespace (trailing-whitespace)
C: 42, 0: Trailing whitespace (trailing-whitespace)
C: 43, 0: Trailing whitespace (trailing-whitespace)
C: 43, 0: Trailing whitespace (trailing-whitespace)
C: 44, 0: Trailing whitespace (trailing-whitespace)
C: 47, 0: Trailing whitespace (trailing-whitespace)
C: 51, 0: Trailing whitespace (trailing-whitespace)
C: 55, 0: Trailing whitespace (trailing-whitespace)
C: 57, 0: Trailing whitespace (trailing-whitespace)
C: 63, 0: Trailing whitespace (trailing-whitespace)
C: 65, 0: Trailing whitespace (trailing-whitespace)
C: 68, 0: Trailing whitespace (trailing-whitespace)
C: 71, 0: Trailing whitespace (trailing-whitespace)
C: 72, 0: Wrong continued indentation (add 20 spaces).
                        'testprojectid', 'authorlogin', 'summary'] #, 'steps']
                        ^                   | (bad-continuation)
C: 73, 0: Trailing whitespace (trailing-whitespace)
C: 78, 0: Trailing whitespace (trailing-whitespace)
C: 81, 0: Trailing whitespace (trailing-whitespace)
C: 84, 0: Trailing whitespace (trailing-whitespace)
C: 90, 0: Wrong hanging indentation (remove 12 spaces).
                        'testcaseexternalid', 'version' , 'testprojectid',
            |           ^ (bad-continuation)
C: 90, 0: Trailing whitespace (trailing-whitespace)
C: 90, 0: No space allowed before comma
                        'testcaseexternalid', 'version' , 'testprojectid',
                                                        ^ (bad-whitespace)
C: 91, 0: Wrong hanging indentation (remove 12 spaces).
                        'customfieldname', 'details']
            |           ^ (bad-continuation)
C: 94, 0: Trailing whitespace (trailing-whitespace)
C: 95, 0: Trailing whitespace (trailing-whitespace)
C: 99, 0: Trailing whitespace (trailing-whitespace)
C:104, 0: Trailing whitespace (trailing-whitespace)
C:105, 0: Trailing whitespace (trailing-whitespace)
C:107, 0: Trailing whitespace (trailing-whitespace)
C:108, 0: Trailing whitespace (trailing-whitespace)
C:109, 0: Trailing whitespace (trailing-whitespace)
C:110, 0: Trailing whitespace (trailing-whitespace)
C:111, 0: Trailing whitespace (trailing-whitespace)
C:112, 0: Trailing whitespace (trailing-whitespace)
C:113, 0: Trailing whitespace (trailing-whitespace)
C:114, 0: Trailing whitespace (trailing-whitespace)
C:118, 0: Wrong hanging indentation (remove 36 spaces).
                                                *argsPositional, **argsOptional)
            |                                   ^ (bad-continuation)
C:131, 0: Trailing whitespace (trailing-whitespace)
C:132, 0: Trailing whitespace (trailing-whitespace)
C:135, 0: Trailing whitespace (trailing-whitespace)
C:136, 0: Trailing whitespace (trailing-whitespace)
C:138, 0: Trailing whitespace (trailing-whitespace)
C:140, 0: Trailing whitespace (trailing-whitespace)
C:142, 0: Trailing whitespace (trailing-whitespace)
C:145, 0: Trailing whitespace (trailing-whitespace)
C:145, 0: Trailing whitespace (trailing-whitespace)
C:146, 0: Trailing whitespace (trailing-whitespace)
C:155, 0: Trailing whitespace (trailing-whitespace)
C:157, 0: Trailing whitespace (trailing-whitespace)
C:160, 0: Trailing whitespace (trailing-whitespace)
C:164, 0: Trailing whitespace (trailing-whitespace)
C:165, 0: Trailing whitespace (trailing-whitespace)
C:173, 0: Trailing whitespace (trailing-whitespace)
C:177, 0: Trailing whitespace (trailing-whitespace)
C:178, 0: Trailing whitespace (trailing-whitespace)
C:180, 0: Trailing whitespace (trailing-whitespace)
C:185, 0: Trailing whitespace (trailing-whitespace)
C:187, 0: Trailing whitespace (trailing-whitespace)
C:188, 0: Trailing whitespace (trailing-whitespace)
C:189, 0: No space allowed around keyword argument assignment
                            duplicateaction = 'create_new_version')
                                            ^ (bad-whitespace)
C:190, 0: Trailing whitespace (trailing-whitespace)
C:193, 0: Trailing whitespace (trailing-whitespace)
C:196, 0: Trailing whitespace (trailing-whitespace)
C:197, 0: Trailing whitespace (trailing-whitespace)
C:198, 0: Trailing whitespace (trailing-whitespace)
C:200, 0: Trailing whitespace (trailing-whitespace)
C:202, 0: Trailing whitespace (trailing-whitespace)
C:204, 0: Trailing whitespace (trailing-whitespace)
C:205, 0: Trailing whitespace (trailing-whitespace)
C:208, 0: Trailing whitespace (trailing-whitespace)
C:209, 0: Trailing whitespace (trailing-whitespace)
C:211, 0: Trailing whitespace (trailing-whitespace)
C:213, 0: No space allowed around keyword argument assignment
                            duplicateaction = 'generate_new')
                                            ^ (bad-whitespace)
C:214, 0: Trailing whitespace (trailing-whitespace)
C:215, 0: Trailing whitespace (trailing-whitespace)
C:218, 0: Trailing whitespace (trailing-whitespace)
C:220, 0: Trailing whitespace (trailing-whitespace)
C:221, 0: Trailing whitespace (trailing-whitespace)
C:222, 0: Trailing whitespace (trailing-whitespace)
C:225, 0: Trailing whitespace (trailing-whitespace)
C:226, 0: Trailing whitespace (trailing-whitespace)
C:229, 0: Trailing whitespace (trailing-whitespace)
C:230, 0: Trailing whitespace (trailing-whitespace)
C:236, 0: Trailing whitespace (trailing-whitespace)
C:239, 0: Trailing whitespace (trailing-whitespace)
C:241, 0: Trailing whitespace (trailing-whitespace)
C:243, 0: Trailing whitespace (trailing-whitespace)
C:245, 0: Trailing whitespace (trailing-whitespace)
C:246, 0: Wrong continued indentation (add 4 spaces).
                                                        changedArgs, options)
                                                        ^   | (bad-continuation)
C:250, 0: Trailing whitespace (trailing-whitespace)
C:252, 0: Trailing whitespace (trailing-whitespace)
C:253, 0: Trailing whitespace (trailing-whitespace)
C:255, 0: Trailing whitespace (trailing-whitespace)
C:257, 0: Trailing whitespace (trailing-whitespace)
C:264, 0: Trailing whitespace (trailing-whitespace)
C:274, 0: Trailing whitespace (trailing-whitespace)
C:275, 0: Trailing whitespace (trailing-whitespace)
C:278, 0: Trailing whitespace (trailing-whitespace)
C:279, 0: Wrong continued indentation (add 19 spaces).
                'testsuiteid' : 'testsuite_id', 'authorlogin' : 'author_login',
                ^                  | (bad-continuation)
C:279, 0: Trailing whitespace (trailing-whitespace)
C:280, 0: Wrong continued indentation (add 19 spaces).
                'executiontype' : 'execution_type', 'order' : 'node_order',
                ^                  | (bad-continuation)
C:281, 0: Wrong continued indentation (add 19 spaces).
                'estimatedexecduration' : 'estimated_exec_duration' }
                ^                  | (bad-continuation)
C:281, 0: No space allowed before bracket
                'estimatedexecduration' : 'estimated_exec_duration' }
                                                                    ^ (bad-whitespace)
C:282, 0: Trailing whitespace (trailing-whitespace)
C:283, 0: Trailing whitespace (trailing-whitespace)
C:284, 0: Trailing whitespace (trailing-whitespace)
C:285, 0: Trailing whitespace (trailing-whitespace)
C:286, 0: Trailing whitespace (trailing-whitespace)
C:290, 0: Trailing whitespace (trailing-whitespace)
C:292, 0: Trailing whitespace (trailing-whitespace)
C:293, 0: Trailing whitespace (trailing-whitespace)
C:298, 0: Trailing whitespace (trailing-whitespace)
C:299, 0: Trailing whitespace (trailing-whitespace)
C:302, 0: Trailing whitespace (trailing-whitespace)
C:303, 0: Trailing whitespace (trailing-whitespace)
C:308, 0: Trailing whitespace (trailing-whitespace)
C:313, 0: Trailing whitespace (trailing-whitespace)
C:317, 0: Trailing whitespace (trailing-whitespace)
C:320, 0: Trailing whitespace (trailing-whitespace)
C:321, 0: Trailing whitespace (trailing-whitespace)
C:324, 0: Trailing whitespace (trailing-whitespace)
C:326, 0: Trailing whitespace (trailing-whitespace)
C:328, 0: Trailing whitespace (trailing-whitespace)
C:331, 0: Trailing whitespace (trailing-whitespace)
C:333, 0: Trailing whitespace (trailing-whitespace)
C:336, 0: No space allowed before bracket
            a_tc = self.getTestCase(None, testcaseexternalid=a_tc_id )[0]
                                                                     ^ (bad-whitespace)
C:343, 0: No space allowed before bracket
        a_keyword_dic = self.getTestCaseKeywords(testcaseid=a_tc_id )[a_tc_id]
                                                                    ^ (bad-whitespace)
C:349, 0: Trailing whitespace (trailing-whitespace)
C:352, 0: Trailing whitespace (trailing-whitespace)
C:353, 0: Trailing whitespace (trailing-whitespace)
C:354, 0: Trailing whitespace (trailing-whitespace)
C:355, 0: Wrong continued indentation (add 1 space).
                                                     'full', getkeywords=True)
                                                     ^| (bad-continuation)
C:359, 0: Exactly one space required after assignment
            keyword_details =  a_ts_tc.get('keywords', {})
                            ^ (bad-whitespace)
C:365, 0: Trailing whitespace (trailing-whitespace)
C:367, 0: Trailing whitespace (trailing-whitespace)
C:370, 0: Trailing whitespace (trailing-whitespace)
C:374, 0: Trailing whitespace (trailing-whitespace)
C:376, 0: Exactly one space required around assignment
        projects=self.getProjects()
                ^ (bad-whitespace)
C:378, 0: Trailing whitespace (trailing-whitespace)
C:381, 0: Trailing whitespace (trailing-whitespace)
C:383, 0: Exactly one space required around assignment
        projects=self.getProjects()
                ^ (bad-whitespace)
C:392, 0: Trailing whitespace (trailing-whitespace)
C:394, 0: Exactly one space required around assignment
        projects=self.getProjects()
                ^ (bad-whitespace)
C:402, 0: Trailing whitespace (trailing-whitespace)
C:405, 0: Trailing whitespace (trailing-whitespace)
C:407, 0: Exactly one space required around assignment
        projects=self.getProjects()
                ^ (bad-whitespace)
C:415, 0: Trailing whitespace (trailing-whitespace)
C:418, 0: Trailing whitespace (trailing-whitespace)
C:420, 0: Exactly one space required around assignment
        projects=self.getProjects()
                ^ (bad-whitespace)
C:428, 0: Wrong hanging indentation (remove 25 spaces).
                                                 TestSuite['id'],'true','full')
                        |                        ^ (bad-continuation)
C:428, 0: Exactly one space required after comma
                                                 TestSuite['id'],'true','full')
                                                                ^ (bad-whitespace)
C:428, 0: Exactly one space required after comma
                                                 TestSuite['id'],'true','full')
                                                                       ^ (bad-whitespace)
C:435, 0: Trailing whitespace (trailing-whitespace)
C:437, 0: Exactly one space required around assignment
        projects=self.getProjects()
                ^ (bad-whitespace)
C:445, 0: Trailing whitespace (trailing-whitespace)
C:448, 0: Trailing whitespace (trailing-whitespace)
C:450, 0: Exactly one space required around assignment
        projects=self.getProjects()
                ^ (bad-whitespace)
C:458, 0: Trailing whitespace (trailing-whitespace)
C:461, 0: Trailing whitespace (trailing-whitespace)
C:463, 0: Exactly one space required around assignment
        projects=self.getProjects()
                ^ (bad-whitespace)
C:466, 0: Trailing whitespace (trailing-whitespace)
C:470, 0: Trailing whitespace (trailing-whitespace)
C:480, 0: Trailing whitespace (trailing-whitespace)
C:483, 0: Trailing whitespace (trailing-whitespace)
C:491, 0: Trailing whitespace (trailing-whitespace)
C:492, 0: Trailing whitespace (trailing-whitespace)
C:497, 0: Exactly one space required around assignment
        projects=self.getProjects()
                ^ (bad-whitespace)
C:498, 0: Exactly one space required around assignment
        result=-1
              ^ (bad-whitespace)
C:500, 0: Trailing whitespace (trailing-whitespace)
C:500, 0: Unnecessary parens after 'if' keyword (superfluous-parens)
C:505, 0: Trailing whitespace (trailing-whitespace)
C:513, 0: Trailing newlines (trailing-newlines)
C:  1, 0: Missing module docstring (missing-docstring)
C: 61, 8: Invalid attribute name "stepsList" (invalid-name)
C: 64, 4: Invalid method name "_changePositionalArgConfig" (invalid-name)
C:100, 4: Missing method docstring (missing-docstring)
E:101,15: Too many positional arguments for method call (too-many-function-args)
W:103, 4: Parameters differ from overridden 'getTestCaseIDByName' method (arguments-differ)
C:119,11: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck)
W:124, 4: Parameters differ from overridden 'createTestCase' method (arguments-differ)
C:162, 4: Invalid method name "getProjectIDByNode" (invalid-name)
E:166,20: Too many positional arguments for method call (too-many-function-args)
E:168,20: Too many positional arguments for method call (too-many-function-args)
C:171, 4: Invalid method name "copyTCnewVersion" (invalid-name)
C:171, 4: Invalid argument name "origTestCaseId" (invalid-name)
C:171, 4: Invalid argument name "origVersion" (invalid-name)
C:191, 4: Invalid method name "copyTCnewTestCase" (invalid-name)
C:191, 4: Invalid argument name "origTestCaseId" (invalid-name)
C:191, 4: Invalid argument name "origVersion" (invalid-name)
C:216, 4: Invalid method name "_copyTC" (invalid-name)
C:216, 4: Invalid argument name "origTestCaseId" (invalid-name)
C:216, 4: Invalid argument name "changedArgs" (invalid-name)
C:216, 4: Invalid argument name "origVersion" (invalid-name)
C:240, 8: Invalid variable name "origArgItems" (invalid-name)
E:240,23: Too many positional arguments for method call (too-many-function-args)
E:240,23: Unexpected keyword argument 'version' in method call (unexpected-keyword-arg)
C:245, 9: Invalid variable name "posArgValues" (invalid-name)
C:245,23: Invalid variable name "newArgItems" (invalid-name)
C:251, 4: Invalid method name "_copyTCbuildArgs" (invalid-name)
C:251, 4: Invalid argument name "origArgItems" (invalid-name)
C:251, 4: Invalid argument name "changedArgs" (invalid-name)
R:251, 4: Too many local variables (16/15) (too-many-locals)
C:269, 9: Invalid variable name "posArgNames" (invalid-name)
C:269,22: Invalid variable name "optArgNames" (invalid-name)
C:269,35: Invalid variable name "manArgNames" (invalid-name)
C:276, 8: Invalid variable name "externalArgNames" (invalid-name)
C:278, 8: Invalid variable name "externalTointernalNames" (invalid-name)
C:288, 8: Invalid variable name "newArgItems" (invalid-name)
C:289,12: Invalid variable name "exArgName" (invalid-name)
C:290,12: Invalid variable name "inArgName" (invalid-name)
C:296,12: Invalid variable name "changedProjID" (invalid-name)
C:300,13: Invalid variable name "argName" (invalid-name)
C:300,22: Invalid variable name "argValue" (invalid-name)
C:304, 8: Invalid variable name "posArgValues" (invalid-name)
C:305,12: Invalid variable name "argName" (invalid-name)
W:269,35: Unused variable 'manArgNames' (unused-variable)
C:315, 4: Invalid method name "listKeywordsForTC" (invalid-name)
E:336,19: Too many positional arguments for method call (too-many-function-args)
E:336,19: Unexpected keyword argument 'testcaseexternalid' in method call (unexpected-keyword-arg)
E:343,24: Unexpected keyword argument 'testcaseid' in method call (unexpected-keyword-arg)
C:348, 4: Invalid method name "listKeywordsForTS" (invalid-name)
E:354,24: Too many positional arguments for method call (too-many-function-args)
E:354,24: Unexpected keyword argument 'getkeywords' in method call (unexpected-keyword-arg)
C:372, 4: Invalid method name "countProjects" (invalid-name)
C:379, 4: Invalid method name "countTestPlans" (invalid-name)
C:384, 8: Invalid variable name "nbTP" (invalid-name)
E:386,18: Too many positional arguments for method call (too-many-function-args)
C:387,12: Invalid variable name "nbTP" (invalid-name)
C:390, 4: Invalid method name "countTestSuites" (invalid-name)
C:395, 8: Invalid variable name "nbTS" (invalid-name)
C:397,12: Invalid variable name "TestPlans" (invalid-name)
E:397,24: Too many positional arguments for method call (too-many-function-args)
C:398,16: Invalid variable name "TestPlan" (invalid-name)
C:399,16: Invalid variable name "TestSuites" (invalid-name)
E:399,29: Too many positional arguments for method call (too-many-function-args)
C:400,16: Invalid variable name "nbTS" (invalid-name)
C:403, 4: Invalid method name "countTestCasesTP" (invalid-name)
C:408, 8: Invalid variable name "nbTC" (invalid-name)
C:410,12: Invalid variable name "TestPlans" (invalid-name)
E:410,24: Too many positional arguments for method call (too-many-function-args)
C:411,16: Invalid variable name "TestPlan" (invalid-name)
C:412,16: Invalid variable name "TestCases" (invalid-name)
E:412,28: Too many positional arguments for method call (too-many-function-args)
C:413,16: Invalid variable name "nbTC" (invalid-name)
C:416, 4: Invalid method name "countTestCasesTS" (invalid-name)
C:421, 8: Invalid variable name "nbTC" (invalid-name)
C:423,12: Invalid variable name "TestPlans" (invalid-name)
E:423,24: Too many positional arguments for method call (too-many-function-args)
C:424,16: Invalid variable name "TestPlan" (invalid-name)
C:425,16: Invalid variable name "TestSuites" (invalid-name)
E:425,29: Too many positional arguments for method call (too-many-function-args)
C:426,20: Invalid variable name "TestSuite" (invalid-name)
C:427,20: Invalid variable name "TestCases" (invalid-name)
E:427,32: Too many positional arguments for method call (too-many-function-args)
C:429,24: Invalid variable name "TestCase" (invalid-name)
C:430,24: Invalid variable name "nbTC" (invalid-name)
W:429,24: Unused variable 'TestCase' (unused-variable)
C:433, 4: Invalid method name "countPlatforms" (invalid-name)
C:438, 8: Invalid variable name "nbPlatforms" (invalid-name)
C:440,12: Invalid variable name "TestPlans" (invalid-name)
E:440,24: Too many positional arguments for method call (too-many-function-args)
C:441,16: Invalid variable name "TestPlan" (invalid-name)
C:442,16: Invalid variable name "Platforms" (invalid-name)
E:442,28: Too many positional arguments for method call (too-many-function-args)
C:443,16: Invalid variable name "nbPlatforms" (invalid-name)
C:446, 4: Invalid method name "countBuilds" (invalid-name)
C:451, 8: Invalid variable name "nbBuilds" (invalid-name)
C:453,12: Invalid variable name "TestPlans" (invalid-name)
E:453,24: Too many positional arguments for method call (too-many-function-args)
C:454,16: Invalid variable name "TestPlan" (invalid-name)
C:455,16: Invalid variable name "Builds" (invalid-name)
E:455,25: Too many positional arguments for method call (too-many-function-args)
C:456,16: Invalid variable name "nbBuilds" (invalid-name)
C:459, 4: Invalid method name "listProjects" (invalid-name)
C:468, 4: Invalid method name "initStep" (invalid-name)
C:481, 4: Invalid method name "appendStep" (invalid-name)
C:493, 4: Invalid method name "getProjectIDByName" (invalid-name)
C:493, 4: Invalid argument name "projectName" (invalid-name)
C:493, 4: Missing method docstring (missing-docstring)
C:496, 4: Invalid method name "getProjectByName" (invalid-name)
C:496, 4: Invalid argument name "projectName" (invalid-name)
C:496, 4: Missing method docstring (missing-docstring)
C:507, 4: Invalid constant name "tl_helper" (invalid-name)
C:509, 4: Invalid constant name "myTestLink" (invalid-name)
C: 25, 0: standard import "import sys" should be placed before "from .testlinkapigeneric import TestlinkAPIGeneric, TestLinkHelper" (wrong-import-order)

----------------------------------------------------------------------
Your code has been rated at -10.11/10 (previous run: -10.11/10, +0.00)