search

ld4l-labs / vitrolib

Vitro editor for library cataloging
BSD 2-Clause "Simplified" License
10 stars 3 forks source link

Duplicate initialSiteConfig.rdf files result in inconsistent display #34

Open daveneiman opened 7 years ago

daveneiman commented 7 years ago

There are 2 of these files: vitrolib-home/src/main/resources/rdf/applicationMetadata/firsttime/initialSiteConfig.rdf vitrolib-installer-home/src/main/resources/rdf/applicationMetadata/firsttime/initialSiteConfig.rdf

Based on experimenting the following was determined: The later wins out over the former during an installation. The later, when deployed, displays and has an incorrect VIVO</rdfs:label> value -- should be Vitrolib. (This is what's displayed on browser tab.) The later has the correct LD4L logo. The <j.0:aboutText... /> text is incorrect for both files yet neither appears to be used. The description text displayed when the later is deployed could be pulled from one of the two following files (text is the same): vitrolib-home/src/main/resources/rdf/display/firsttime/aboutPage.n3 vitrolib-webapp/src/main/webapp/themes/vitrolib/i18n/all.properties

rjyounes commented 7 years ago

Huda, David,

Would it make sense to put issues Vitro core issues in the Vitro repo rather than VitroLib? From there you can decide whether to move them to the VIVO project JIRA. Most likely you are not going to get many of these general Vitro problems fixed during the VitroLib, and they can just be referred to the Vitro project maintainers.

Rebecca

daveneiman commented 7 years ago

Rebecca,

This looked like a vitrolib, not a Vitro, issue since all files referenced in the issue I submitted are in some vitrolib module. It was the About page display for vitrolib. Without digging further I’m guessing that these vitrolib files overrode some analogous files in Vitro. Then there’s the issue of duplicate text as well as RDF elements in one or more of the files that seemed not to be used in favor of either the properties file or the n3 file.

I hope this makes sense.

Thanks, David

From: Rebecca Younes notifications@github.com Reply-To: ld4l-labs/vitrolib reply@reply.github.com Date: Friday, December 16, 2016 at 2:38 PM To: ld4l-labs/vitrolib vitrolib@noreply.github.com Cc: "Neiman, David" david_neiman@harvard.edu, Author author@noreply.github.com Subject: Re: [ld4l-labs/vitrolib] Duplicate initialSiteConfig.rdf files result in inconsistent display (#34)

Huda, David,

Would it make sense to put issues Vitro core issues in the Vitro repo rather than VitroLib? From there you can decide whether to move them to the VIVO project JIRA. Most likely you are not going to get many of these general Vitro problems fixed during the VitroLib, and they can just be referred to the Vitro project maintainers.

Rebecca

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ld4l-2Dlabs_vitrolib_issues_34-23issuecomment-2D267678360&d=CwMFaQ&c=WO-RGvefibhHBZq3fL85hQ&r=E4CBlG2Y56LZVErMuCUUebUg_BUQBjrd6shQZC_EPhU&m=Leg7a-DNCWIePbq-UbH8T6VJdVD9mO2KDskF1VbsmKI&s=fCV262sJLy_AYu5FiS8fsF9_2SurV1h1tBIpUDvgfMo&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ANKbG-2DOvlSu-2D7lIlna97kpHkHQgd-2Dzaiks5rIui2gaJpZM4LPg-2Db&d=CwMFaQ&c=WO-RGvefibhHBZq3fL85hQ&r=E4CBlG2Y56LZVErMuCUUebUg_BUQBjrd6shQZC_EPhU&m=Leg7a-DNCWIePbq-UbH8T6VJdVD9mO2KDskF1VbsmKI&s=mG4iTcIbzRvFSppcKMPB5sBlgxMamrsdaXwVO-q-ol0&e=.

rjyounes commented 7 years ago

The files get into vitrolib/home but it's a Vitro problem, I believe. Apologies if I'm wrong.