search

ldapjs / node-ldapjs

LDAP Client and Server API for node.js
http://ldapjs.org
MIT License
1.61k stars 452 forks source link

Add integration test for issue #933 #934

Closed audn closed 1 year ago

audn commented 1 year ago

This PR adds a new integration test for issue https://github.com/ldapjs/node-ldapjs/issues/933.

jsumners commented 1 year ago

I believe we can close this, and the Docker image issue, with release https://github.com/ldapjs/node-ldapjs/releases/tag/v3.0.5. Please try that release and report back.

audn commented 1 year ago

Unfortunately, the changes in 3.0.5 did not fix this issue

audn commented 1 year ago

I might have got it working, will update soon.

jsumners commented 1 year ago

Does 3.0.5 solve this issue?

jsumners commented 1 year ago

Given the lack of response, and the fact that the fix included in v3.0.5 includes a test that specifically tests a character included in this issue (https://github.com/ldapjs/filter/commit/e12ec04a3dac543803a57df5ca7cce269355604d#diff-3d1de0fa47b73b302bc2e63ebf2797fe6d17bf7b28a9d369ced5c1d604c011bb), I am closing this (and the other associated issued).

If you determine that there is still a problem, please reopen.