search

ldbc / ldbc_snb_interactive_v1_impls

Reference implementations for LDBC Social Network Benchmark's Interactive workload.
https://ldbcouncil.org/benchmarks/snb-interactive
Apache License 2.0
98 stars 85 forks source link

Remove unused results_log configuration option #404

Closed szarnyasg closed 10 months ago

szarnyasg commented 10 months ago

This PR removes the unused results_log configuration option. This option is not only not used, it's also confusing: the driver modes "create validation parameters" and "validate" do not produce a log file regardless of configuration, while the mode "benchmark" produces a configuration to the directory specified by the results_dir option (default: results/).

See the driver configuration class for details – there is no option called results_log in the first place: https://github.com/ldbc/ldbc_snb_interactive_v1_driver/blob/eed18de824e4c7a6304b431ea32c7deebd008dc5/src/main/java/org/ldbcouncil/snb/driver/control/ConsoleAndFileDriverConfiguration.java#L105-L110

huyannb commented 9 months ago

Is it possible to produce a log file in 'validate' step?

szarnyasg commented 9 months ago

There is no log file other than the one printed to stdout. You may use tee to save that.

As described in the README, in case of a failed validation, you get two JSON files describing the differences found during validation:

If the validation failed, the results are saved to the validation_params-failed-expected.json and validation_params-failed-actual.json files.