ldc-developers / ldc2.snap

Snap package definition for LDC, the LLVM-based D compiler
11 stars 4 forks source link

Switch to using upstream prebuilt binaries for snap package #114

Closed WebDrake closed 3 years ago

WebDrake commented 3 years ago

This is a major (major major MAJOR) change in the package design which carries 3 major benefits:

There are however also some major costs:

If this approach is too heavy-handed then it might be possible to make a compromise such as downloading only prebuilt LLVM and still building the actual compiler and tool executables.

joseph-wakeling-frequenz commented 3 years ago

@kinke @JohanEngelen I'd be interested in your thoughts/preferences on this. I also need to test out the results across different distros somewhat.

kinke commented 3 years ago

As I've mentioned multiple times, I have personally no use for snap packages, and I've never understood why anyone would prefer such a (Canonical-specific/proprietary?) system over a simple download+extract (or upstream's install.sh or the like if that's 'too much work'). Anyway, simply wrapping the official packages into such a package makes probably much more sense than building a near-identical thing manually from scratch.

Wrt. i686, official Ubuntu support was dropped with 19.10 AFAIK, so I doubt anyone will miss it (and cross-compilation from an x64 host is still possible).

joseph-wakeling-frequenz commented 3 years ago

Thanks for the thoughts; I'd forgotten about the 19.10 dropping of i686, so good to have a reminder of why the 32-bit snaps are not needed. My concern was mainly to flag any potential issues that you might anticipate; there are clearly none, so let's push forward with this.

WebDrake commented 3 years ago

OK, this is looking good across multiple distros. Let's take it in: it's far simpler than all the aternatives.