ldc-developers / ldc2.snap

Snap package definition for LDC, the LLVM-based D compiler
11 stars 4 forks source link

Update to LDC 1.15.0 stable release, incl. LLVM 8.0.0 #79

Closed kinke closed 5 years ago

kinke commented 5 years ago

This is a dummy PR, just for making the 1.15 branch visible. Pinging @WebDrake.

WebDrake commented 5 years ago

Thanks for the patch. A couple of notes for future reference:

What I would usually do is:

Anyway, per se this LGTM apart from one small thing -- wasn't there an extra build optimization that could be enabled with 1.15 ... ? I remember you mentioning it when recommending the bootstrap compiler be built from the same version as the release itself.

kinke commented 5 years ago

I know it's just for testing

Wouldn't even by necessary, all branches are tested too. It was just to make this visible to you. ;)

wasn't there an extra build optimization

Nope, but v1.15 as host compiler (with the GC improvements in its druntime) significantly increases the usefulness of the new -lowmem option, so we're already set.

WebDrake commented 5 years ago

Nope, but v1.15 as host compiler (with the GC improvements in its druntime) significantly increases the usefulness of the new -lowmem option, so we're already set.

So no extra build flags needed, the benefits are automatic?

kinke commented 5 years ago

Yes, just a better/less wasteful GC in druntime.

WebDrake commented 5 years ago

Awesome. In that case I'll close this PR and just set up the job to build this version. We can deal with the LLVM C++ flags issue in a separate PR.

WebDrake commented 5 years ago

Closing, as the branch should not be merged into 1.14.

WebDrake commented 5 years ago

Snap package definition in place: https://code.launchpad.net/~ldc-developers/+snap/ldc2-1.15