search

ldd / gatsby-source-github-api

Pull data into Gatsby from Github API v4
MIT License
65 stars 10 forks source link

fix: change boundActionCreators to actions #25

Closed jeffwinegar closed 3 years ago

jeffwinegar commented 3 years ago

Changes boundActionCreators to actions per Gatsby v3 breaking changes: https://www.gatsbyjs.com/docs/reference/release-notes/migrating-from-v2-to-v3#removal-of-boundactioncreators

ldd commented 3 years ago

Oh boy. Thanks for this pull request. Can anyone else confirm that there are no further problems with gatsby v3?

This is a breaking change that makes the code no longer compatible with gatsby v2 so I'll probably need to be careful with the next version's numbers.

ldd commented 3 years ago

Nobody has made a comment against this, so I'm merging it to master. Not publishing a new NPM version until I manually check compatibility issues, which may take a while, as I am busy running a kickstarter.

Thanks!

corybell commented 3 years ago

Nobody has made a comment against this, so I'm merging it to master. Not publishing a new NPM version until I manually check compatibility issues, which may take a while, as I am busy running a kickstarter.

Thanks!

I can confirm that this works in gatsby v3.

ekeih commented 3 years ago

Thanks for fixing this @jeffwinegar, I am just running into this while upgrading to Gatsby v3 and you saved me quite some time :) I can confirm that it works with v3.

For anyone who wants to pin the package unitil there is a new release on npm you can set it to this commit in your package.json:

{
  "dependencies": {
    "gatsby-source-github-api": "ldd/gatsby-source-github-api#fe8fa58d89be8c2f49ea277c58bbd369f8abbda0"
    ...
  }
  ...
}
bradgarropy commented 3 years ago

I can also confirm that this works with Gatsby v3! And thanks to @ekeih for the workaround, it works!

EDIT: It turns out the workaround doesn't work when installing projects in GitHub Actions or on Netlify.

There is a fork of this library on npm which includes the change if you want to jump the gun. @bellistic/gatsby-source-github-api

ldd commented 3 years ago

I've just published version 1.0.0 which includes gatsby v3 support.