search

ldd / gatsby-starter-github-portfolio

Gatsby starter to show your github portfolio
MIT License
9 stars 2 forks source link

compatibility with github v4 #1

Open MoatazAbdAlmageed opened 4 years ago

MoatazAbdAlmageed commented 4 years ago

Thanks for this package but I think it it not compatible with https://developer.github.com/v4/

I got this error 


 ERROR #85907  GRAPHQL

There was an error in your GraphQL query:

- Unknown field 'data' on type 'GithubData'.

File: src/pages/index.js
ldd commented 4 years ago

I'll take a look.

Thanks for opening an issue.

ldd commented 4 years ago

So, I think the main issue was the README.

First, we need to configure a token properly, and my joke about hunter2 is not explicit enough in what you have to do

=> I've changed the README to be more explicit on that aspect

Secondly, this project does in fact support github v4 queries, but to do so, you must modify gatsby-config.js instead of src/pages/index.js. I should've clarified this from the start.

=> I've changed the README to instruct users on how to use their own queries.

If that doesn't solve your problem, please let me know!

MoatazAbdAlmageed commented 4 years ago

@ldd Thanks for your updates but please make sure the demo so I can use this package.

ldd commented 4 years ago

I am not sure I understand. Do you want a demo to see what the package will do?

Or perhaps you want an example of using this with a custom github v4 API ?

I updated the package's version a couple of hours after making that comment. Maybe all you need to do is reinstall the package.

At any rate, let me know what you need.

I know a couple of people that can write and read Arabic so if you prefer, write your comment in another language and I'll try to translate it as soon as I can.

Thanks!

MoatazAbdAlmageed commented 4 years ago

@ldd I mean making sure that gatsby-starter-github-portfolio demo working well becuase I reinstalled the packages but not working.