search

ldelossa / gh.nvim

A fully featured GitHub integration for performing code reviews in Neovim.
MIT License
520 stars 24 forks source link

Submitting thread comment <C-s> fails. #115

Closed eric-distributed-spectrum closed 1 week ago

eric-distributed-spectrum commented 3 months ago

I am trying to make a comment in a PR. I started a review with :GHStartReview. I open a diff, and run :GHCreateThread. In a new line in the buffer I write 'test'. I press control-s. I get this error:

E5108: Error executing lua: ...te/pack/packer/start/gh.nvim/lua/litee/gh/ghcli/init.lua:834: attempt to call a string value
stack traceback:
    ...te/pack/packer/start/gh.nvim/lua/litee/gh/ghcli/init.lua:834: in function 'create_comment_review'
    ...k/packer/start/gh.nvim/lua/litee/gh/pr/thread_buffer.lua:740: in function 'create'
    ...k/packer/start/gh.nvim/lua/litee/gh/pr/thread_buffer.lua:842: in function <...k/packer/start/gh.nvim/lua/litee/gh/pr/thread_buffer.lua:823
joestringer commented 1 week ago

This patch should fix the issue: https://github.com/ldelossa/gh.nvim/pull/117