search

ldelossa / gh.nvim

A fully featured GitHub integration for performing code reviews in Neovim.
MIT License
544 stars 26 forks source link

feat: GHViewWeb uses "open" under macOS #67

Closed Frederick888 closed 2 years ago

Frederick888 commented 2 years ago

As the title.

Under macOS open command is largely equivalent to xdg-open in Free Desktop standard.

ldelossa commented 2 years ago

Hey there, going to revert this commit. Seems to be breaking me on linux:

E5108: Error executing lua: Vim:E475: Invalid value for argument cmd: 'open' is not executable                                                                                                 
stack traceback:                                                                                                                                                                               
        [C]: in function 'system'                                                                                                                                                              
        ...ouis/.config/nvim/after/gh.nvim/lua/litee/gh/pr/init.lua:26: in function 'open_nodes_url'                                                                                           
        ...ouis/.config/nvim/after/gh.nvim/lua/litee/gh/pr/init.lua:1075: in function <...ouis/.config/nvim/after/gh.nvim/lua/litee/gh/pr/init.lua:1065>

feel free to give it another go, maybe test on linux as well.

Frederick888 commented 2 years ago

🤦 lua got me again. will submit another PR. Thanks for catching this.

$ lua
Lua 5.4.4  Copyright (C) 1994-2022 Lua.org, PUC-Rio
> if 0 then print('yes') end
yes