ldelossa / gh.nvim

A fully featured GitHub integration for performing code reviews in Neovim.
MIT License
520 stars 24 forks source link

Feature request: Show diff between current and target branches in per-file diff view #70

Closed Frederick888 closed 8 months ago

Frederick888 commented 1 year ago

At the moment in per-file diff views, it shows the difference from the common ancestor between current and target branches [1].

This gives different results from GitHub web. It'd be nice if this can be configured to head of target branch. (We all have to work with someone who just loves merging master/main into PR branches, don't we ;) )

[1] https://github.com/ldelossa/gh.nvim/blob/20604033b61db43173f85a5b3cfc793089232d1d/lua/litee/gh/pr/diff_view.lua#L436

GuillaumeLagrange commented 8 months ago

@Frederick888 I don't know if you're still interested by this has been fixed

@ldelossa we can close this :tada:

ldelossa commented 8 months ago

Thanks @GuillaumeLagrange appreciated!