ldelossa / gh.nvim

A fully featured GitHub integration for performing code reviews in Neovim.
MIT License
544 stars 26 forks source link

Nothing happens after trying to open PR #72

Open sozoalvin opened 2 years ago

sozoalvin commented 2 years ago

hi!

Trying to open PR using :GHOpenPR in nvim and it this little thing opens at the bottom of my editor asking which PR i want to open.

After which; it says it's fetching and all that suff but it always has a red errror at the top right indicating error adding remote

Ive tried this for a couple of hours and sometimes i get the diff windows; and sometimes I don't. For the times the diff windows worked; my git status always returns the commit ID of the current 'branch' its checked out on.

On the other hand; if it does nothing, my git status always shows the current branch i.e. master.

Is there anything I can do to help you debug this?

ldelossa commented 2 years ago

Checkout the debugging sections in the docs. It should log out the exact cli command which fails and why.

Also ensure "gh config gitprotocol" is set to ssh, remove any litee* named remotes if they exist and try again.

maxandron commented 2 years ago

Setting the git_protocol to ssh solved this and a bunch of other errors for me. Thanks!

Perhaps the plugin can check that and alert accordingly?

sozoalvin commented 2 years ago

same - but some windows still wouldn't open - will try again in the future ! thanks for all that you do on this plugin but just not for me at this moment!

tombh commented 1 year ago

I don't even get the little thing asking which PR I want to open. I've done gh config set git_protocol ssh and made sure there aren't any litee* remotes.

I see from GHOpenDebugBuffer that the API request to get the PRs succeeds. But then the trail goes cold 🤔

marcoSven commented 1 year ago

I have the same issue in the debug log I get

"fatal: could not read Username for 'https://github.com/': Device not configured"

Here is my gh config

git_protocol=ssh
editor=
prompt=enabled
pager=
http_unix_socket=
browser=

What is interesting though is that after some time it does end up opening 🤷

danielo515 commented 1 year ago

I'm in a similar situation. It allow me to pick the PR to open, but when I try to start a review nothing happens. I tried changing the protocol to ssh and I see more messages appearing, but at the end nothing happens. I tried GHOpenDebugBuffer but nothing opens.

danielo515 commented 1 year ago

Ok, in my case the issue was not any error, but the app just being extremely slow. To be fair, my PR is quite big. I triggered the start review command, and after being frustrated because it was not working I left my laptop on and left. After a couple of hours, I came back just to find the PR review UI in my neovim editor. I don't know how long it took, but I'm pretty sure it took more than 5 minutes, because that is how much I spent in my computer trying to guess why it was not working.

SheltonTolbert commented 1 year ago

I ran into a similar issue. In my case the issue stemmed from having opened nvim from a subdirectory of a monorepo. Opening nvim from the root directory of the project fixed the issue.

austinwilcox commented 1 year ago

I ran into this issue as well, I reran the gh config set git_protocol ssh even though my config said it was mapped to ssh, and then everything started working for me. Could be an issue with the gh cli?