ldelossa / gh.nvim

A fully featured GitHub integration for performing code reviews in Neovim.
MIT License
544 stars 26 forks source link

Every word in PR window is highlighted with underline #73

Closed dlvhdr closed 1 year ago

dlvhdr commented 1 year ago

Having an underline on every word makes it hard to read.

For example, when used in gh.nvim: image

Using TSHighlightCapturesUnderCursor shows that the highlight group is LTSymbol which is defined as

        LTSymbol               = 'hi LTSymbol                 guifg=#87afd7 gui=underline',

When I remove this piece of code, this issue is fixed: https://github.com/ldelossa/gh.nvim/blob/6fb1702df462d08f06df21c1e98d69ec08048cde/lua/litee/gh/issues/issue_buffer.lua#L171

image

ldelossa commented 1 year ago

This is weird, I don't think I've pushed a change which did this recently hmm.

ldelossa commented 1 year ago

fixed in: https://github.com/ldelossa/litee.nvim/commit/f8b778b95c152f1fe2021c163eead3a5b2b2889d

can you pull latest litee.nvim and confirm?

dlvhdr commented 1 year ago

Yes this works!

ldelossa commented 1 year ago

Cool, must have just been something I over looked. Closing.