search

ldelossa / gh.nvim

A fully featured GitHub integration for performing code reviews in Neovim.
MIT License
520 stars 24 forks source link

not defaulting to telescope with lazy.nvim #80

Closed sf8193 closed 1 year ago

sf8193 commented 1 year ago

Hello, your plugin looks amazing and exactly what i've been looking for. Can't stand the temptation to go to function definition with octo knowing that it's not possible.

when I run GHOpenPr i get the regular ui view, not telescope. In the readme it's mentioned that it should default to telescope, however i don't see that and haven't been able to figure out where in the code that should be happening. I'm wondering if there's any guidance i'm missing or if this is something else.

Thank you for making the plugin again, really hopeful it solves the need i have

ldelossa commented 1 year ago

Hey,

telescope (or fzf) you should overwrite the "vim.ui.select" function.

Telescope should do this by default

DennisTheMenace780 commented 1 year ago

I'm also experiencing a similar problem, but I do not use lazy.nvim. I have just grabbed the default configuration and tried to do a GHOpenPr as well and Telescope does not take over automatically.

sf8193 commented 1 year ago

i believe you need the telescope-ui.nvim plugin that defaults to telescope? it won't default otherwise