Manage renamed files in PR diff

[GuillaumeLagrange]

If a file was renamed during the PR, its diff view would be useless because the plugin would try to git show the new file name on the base ref, when it did not exist.

I tested it in file diff view, not sure about commit by commit review since I use this feature much less than the whole file change

[ldelossa]

Hey there, should the editorconfig file be included?

[ldelossa]

tested it in file diff view, not sure about commit by commit review since I use this feature much less than the whole file change

mind doing a small test just to ensure commit by commit review works? It should since the code is shared

[GuillaumeLagrange]

I added the editorconfig so that other future contributors dont have to bother with it since it's quite standard. If you wish I can keep it local only, it's really up to you :)

I tested with a commit by commit and it seems to work fine ! Do you want me to create a minimal repro repo with an example PR so you can play around with it ?

[GuillaumeLagrange]

Here you go if you want to play around: https://github.com/GuillaumeLagrange/neoconf-repro/pull/1 It seems coherent to me :hugs:

[ldelossa]

Testing it out seems fine.

Lua formatting im torn on. Lately ive just been using what ever the default null-ls language server formats, will editorconfig file get picked up by that?

[GuillaumeLagrange]

It should not conflict as far as I know, but don't worry I'll just remove it and keep it local

[ldelossa]

Thanks. And thanks for the PR.