search

ldelossa / gh.nvim

A fully featured GitHub integration for performing code reviews in Neovim.
MIT License
520 stars 24 forks source link

Display checkmark icon in PR files if file is marked as viewed #99

Closed GuillaumeLagrange closed 8 months ago

GuillaumeLagrange commented 8 months ago

This pr queries the pull request file viewed state from github's graphql api, and displays a small check mark is the file has been marked as viewed.

image

Resolves #98

GuillaumeLagrange commented 8 months ago

@ldelossa this is ready for review, I added the toggle command :smile:

ldelossa commented 8 months ago

BTW @GuillaumeLagrange I'm thinking of starting a re-implementation of this plugin using nvim-ide framework:

https://github.com/ldelossa/nvim-ide

That code is way prettier and easier to maintain. If you're interested in these efforts we can discuss further.

GuillaumeLagrange commented 8 months ago

@ldelossa that could be interesting indeed, I will look into nvim-ide.

Is there some issue with the theoretical first steps to do so ? Or is it just a plan that you had that we would need to clear out ?

ldelossa commented 8 months ago

@GuillaumeLagrange No issue, and its just a lofty goal right now, its been floating around my head. TBH, I got burnt out from dealing with Github API and the weird way you need to dance around things. But it could be nice to start working on a nvim-ide focused implementation, one component at a time.