(EDITED) Data get lost when highlighting or commenting a page. Seems to happen randomly.

ldenoue / yawas

Yawas Web and PDF Highlighter browser extension for Chrome and Firefox

MIT License

49 stars 12 forks source link

(EDITED) Data get lost when highlighting or commenting a page. Seems to happen randomly. #21

Open alvahro opened 2 years ago

alvahro commented 2 years ago

High risk of data loss ⚠️:

EDITED After the replies, I went and test it again and the behavior changed, I have no clue what is happening. Now the data loss seems to happen randomly. Here is an example: video Randomly after highlighting or placing a comment, Yawas data gets overwritten and only the last highlight/comment is shown.

Yawas version: 7.4.0 (Chrome version from the Chrome Store) Chrome version: 106.0.5249.119 (Build oficial) (x86_64)

ldenoue commented 2 years ago

not able to reproduce. are you using the Chrome version from the Chrome Store or the github version loaded by yourself?

peter-lyons-kehl commented 2 years ago

Thank you Laurent for Yawas. Thank you @alvahro for reporting.

I never experienced such a problem either - even though I'm on v. 7.3.9 on Firefox (the current version for Firefox until Mozilla accepts the new manifests).

However, I have 4857 bookmarks, out of which 3010+ have Yawas-based highlights. I use comments very little, but still - if the problem existed in/before 7.3.9, I would have noticed.

alvahro commented 2 years ago

@ldenoue I'm using the Chrome version from the Chrome Store.

Now it seems to happen randomly and not because of comments, I have no idea. I edited the issue to reflect this. Here is an example

@peter-kehl That you have been able to use it that much and with that reliability it's encouraging, but I'm really afraid of losing important work because of this issue. I hope I can make it work because I think it's the best solution out there for a simple, non-invasive, and functional annotation tool. I'll try loading the version from this repo manually and see if it works. But in theory, both are the same version. If I can find the time I'll try to debug.

Thank you

alvahro commented 2 years ago

Tried loading github version myself (manually) and the issue still persists. Randomly after highlighting or placing a comment, Yawas data gets overwritten and only the last highlight/comment is shown.

ldenoue commented 2 years ago

does it happens for all urls where you try it? Can you share the URL where it fails for you?

alvahro commented 2 years ago

does it happens for all urls where you try it? Can you share the URL where it fails for you?

It has happened in all URLs that I've used it.

ldenoue commented 2 years ago

https://user-images.githubusercontent.com/149561/196723771-669ca5eb-3c48-4ca3-8b5b-3653e88d2eec.mp4

Please send a screencast (like this one) where you're able to reproduce the bug. I can't.

peter-lyons-kehl commented 2 years ago

@alvahro Suggest troubleshooting to narrow down, to help us replicate, like

what OS, kernel... anything else special/custom (profile stored on any special filesystem)?-
disable other Chrome extensions one by one (or several at the same time) and see if the problem persists,
try with a new (temporary) Chrome profile
if the problem persists with a new profile, upload it in a .zip file.

I don't know how exactly to locate, export & import/restore a Chrome profile (it's much easier in Firefox). Google seems to document only the export, but not an import/restore: https://support.google.com/accounts/answer/3024190. But it may be as simple as copying a folder as per https://www.thewindowsclub.com/transfer-google-chrome-profile-to-another-computer (most of it is not Windows-specific - and the part that mentions Windows Registry is just an alternative method).