search

ldeo-glaciology / xapres

package for processing ApRES data using xarray
MIT License
3 stars 2 forks source link

Update ApRESDefs.py #29

Open Elizabethcase opened 10 months ago

Elizabethcase commented 10 months ago

instead of a remote_load arg, always try remotely loading if local file load fails using a try-except statement. This can be propagated through all classes to potentially remove the need for the remote_load arg. I find it very easy to forget that default remote_load=False means that the code will fail with a type error.

jkingslake commented 10 months ago

This sounds like a good idea. Thanks for working on it.

It does seem like we may run into conflicts as I continue working on #20, as both involve changes to ApRESDefs.py, but I am not really sure how to avoid that. Any thoughts?

jkingslake commented 6 months ago

Maybe this line does what we want here: https://github.com/leap-stc/LEAP-bootcamps/blob/2a00e294a2cb91c21070bf18ee1051fd4b5d0d0f/Codes/Day2/utils.py#L15