search

ldeo-glaciology / xapres

package for processing ApRES data using xarray
MIT License
3 stars 2 forks source link

Ongoing work jk 07 24 #45

Closed jkingslake closed 2 months ago

jkingslake commented 3 months ago

Add displacement calculations based on George's work in his fork. See the usingXApRES NB for details on how to use and test the new functionality.

This also adds two new unit tests.

It also improves how bound methods are added to xarray.dataarrays - now this is done in a more easily extendible way upon loading the package, rather then when data is loaded.

jkingslake commented 2 months ago

Thanks @glugeorge. Good point, we dont need that zarr directory in there. I created it to save time loading profiles from the google bucket over-and-over again. It was only 32MB, so not an issue to keep in the repo if we find it useful in the future, but not necessary for now. I deleted them and modified the notebook that was loading them to instead load directly from the google bucket.

jkingslake commented 2 months ago

The computation of the profiles is a separate issue, but I definitely agree that we should add the ability to compute your own and include an explanation of the process in a notebook.

see also #36

jkingslake commented 2 months ago

@glugeorge if you are happy with this PR can you approve it and then I will merge. Thanks again!