ldesgoui / tf2-comp-fixes

Various TF2 tweaks catered towards competitive play
GNU General Public License v3.0
46 stars 7 forks source link

fix pyro airblast explosive self damage (pipes , sentry rockets, flares) #74

Closed kingofings closed 2 years ago

kingofings commented 2 years ago

Reflected Pipes, flares and sentry rockets deal up to 170 self-damage due to them using the flamethrowers dps value from scripts/tf_weapon_flamethrower.ctx

Rockets are unaffected by this since they use the rocket launchers damage value instead of the flamethrower. Reflected rockets use m_hOriginalLaucher. Pipes and flares seem to use m_hLauncher which is the flamethrower. The Sentry rockets m_hOriginalLauncher is also overwritten to the flamethrower as well on deflect.

I haven't taken a look for the windows sig yet. Since you want to deprecate windows support anyways i thought i'd create this pull request for you to take a look at.

ldesgoui commented 2 years ago

That looks pretty good

Is this an exhaustive list? Can you really self-damage with flares? Is it because of the scorch shot? What's the logic with the sentry rocket change, why is it different to the other ones?

Recently I've just googled for Windows sigs, if that's easy to find then great, otherwise don't bother

kingofings commented 2 years ago

I wasn't able to find any regressions of changing these values.

If i remember correctly once you reflect detonator flares you are able to detonate them. Through I'm not sure if that is still the case. But it's probably rare for that to happen, scorch shot is more likely.

When i looked at sentry rockets on a deflect pre Hook their m_hOriginalLauncher was -1, but this will also get overwritten to the flamethrower thus causing up to 170 damage. From this i assume sentry rocket self damage uses m_hOriginalLauncher just like rockets.

ldesgoui commented 2 years ago

Thank you for your contribution :)