github-actions[bot]
commented
4 months ago The benchmark is done!
beego/beego
local
``` client/cache/cache_test.go:31:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err) ^ client/cache/cache_test.go:35:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err) ^ client/cache/cache_test.go:53:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err) ^ client/cache/cache_test.go:83:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, bm.Delete(context.Background(), "astaxie")) ^ client/cache/cache_test.go:87:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, bm.Put(context.Background(), "astaxie", "author", timeoutDuration)) ^ client/cache/cache_test.go:95:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, bm.Put(context.Background(), "astaxie1", "author1", timeoutDuration)) ^ client/cache/cache_test.go:101:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(vv)) ^ client/cache/cache_test.go:106:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(vv)) ^ client/cache/cache_test.go:110:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ client/cache/cache_test.go:116:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err) ^ client/cache/cache_test.go:118:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, bm.Put(context.Background(), "astaxie", 1, timeoutDuration)) ^ client/cache/cache_test.go:132:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, bm.Delete(context.Background(), "astaxie")) ^ client/cache/cache_test.go:137:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, bm.Put(context.Background(), "astaxie", "author", timeoutDuration)) ^ client/cache/cache_test.go:151:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(vv)) ^ client/cache/cache_test.go:156:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(vv)) ^ client/cache/cache_test.go:161:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ client/cache/cache_test.go:200:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, c.Incr(ctx, key)) ^ client/cache/conv_test.go:69:2: float-compare: use assert.InEpsilon (or InDelta) (testifylint) assert.Equal(t, f, GetFloat64(t1)) ^ client/cache/conv_test.go:71:2: float-compare: use assert.InEpsilon (or InDelta) (testifylint) assert.Equal(t, f, GetFloat64(t2)) ^ client/cache/conv_test.go:73:2: float-compare: use assert.InEpsilon (or InDelta) (testifylint) assert.Equal(t, f, GetFloat64(t3)) ^ client/cache/conv_test.go:77:2: float-compare: use assert.InEpsilon (or InDelta) (testifylint) assert.Equal(t, f2, GetFloat64(t4)) ^ client/cache/conv_test.go:79:2: float-compare: use assert.InEpsilon (or InDelta) (testifylint) assert.Equal(t, float64(0), GetFloat64(nil)) ^ client/cache/file_test.go:30:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ client/cache/file_test.go:41:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ client/cache/file_test.go:47:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, fc.DirectoryLevel, 2) ^ client/cache/file_test.go:48:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, fc.EmbedExpiry, 0) ^ client/cache/file_test.go:49:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, fc.FileSuffix, ".bin") ^ client/cache/file_test.go:52:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ client/cache/file_test.go:55:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ client/cache/file_test.go:62:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ client/cache/file_test.go:70:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ client/cache/file_test.go:85:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ client/cache/random_expired_cache_test.go:77:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(vv)) ^ client/cache/random_expired_cache_test.go:82:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(vv)) ^ client/cache/memcache/memcache_test.go:95:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(vv)) ^ client/cache/memcache/memcache_test.go:105:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(vv)) ^ client/cache/redis/redis_test.go:90:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(vv)) ^ client/cache/redis/redis_test.go:128:2: len: use assert.Len (testifylint) assert.Equal(t, 100, len(keys), "scan all error") ^ client/cache/redis/redis_test.go:136:2: empty: use assert.Empty (testifylint) assert.Equal(t, 0, len(keys)) ^ client/httplib/http_response_test.go:34:2: negative-positive: use assert.Positive (testifylint) assert.True(t, resp.ContentLength > 0) ^ client/httplib/httpclient_test.go:36:2: bool-compare: use assert.True (testifylint) assert.Equal(t, true, client.Setting.EnableCookie) ^ client/httplib/httpclient_test.go:95:2: suite-dont-use-pkg: use c.Require().NoError (testifylint) require.NoError(c.T(), err) ^ client/httplib/httpclient_test.go:130:3: suite-dont-use-pkg: use c.Require().NoError (testifylint) require.NoError(c.T(), err) ^ client/httplib/httplib_test.go:44:2: suite-dont-use-pkg: use h.Require().NoError (testifylint) require.NoError(h.T(), err) ^ client/httplib/httplib_test.go:110:3: suite-dont-use-pkg: use h.Require().NoError (testifylint) require.NoError(h.T(), err) ^ client/httplib/httplib_test.go:111:3: suite-dont-use-pkg: use h.Equal (testifylint) assert.Equal(h.T(), []byte("retry body"), body) ^ client/httplib/httplib_test.go:131:2: suite-dont-use-pkg: use h.Require().NoError (testifylint) require.NoError(h.T(), err) ^ client/httplib/httplib_test.go:496:2: negative-positive: use assert.Positive (testifylint) assert.True(t, req.req.ContentLength > 0) ^ client/httplib/httplib_test.go:395:4: require-error: for error assertions use require (testifylint) assert.ErrorIs(t, err, tc.wantErr) ^ client/httplib/httpclient_test.go:34:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ ```v1.59.1
``` client/cache/cache_test.go:31:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err) ^ client/cache/cache_test.go:35:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err) ^ client/cache/cache_test.go:53:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err) ^ client/cache/cache_test.go:83:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, bm.Delete(context.Background(), "astaxie")) ^ client/cache/cache_test.go:87:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, bm.Put(context.Background(), "astaxie", "author", timeoutDuration)) ^ client/cache/cache_test.go:95:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, bm.Put(context.Background(), "astaxie1", "author1", timeoutDuration)) ^ client/cache/cache_test.go:101:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(vv)) ^ client/cache/cache_test.go:106:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(vv)) ^ client/cache/cache_test.go:110:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ client/cache/cache_test.go:116:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err) ^ client/cache/cache_test.go:118:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, bm.Put(context.Background(), "astaxie", 1, timeoutDuration)) ^ client/cache/cache_test.go:132:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, bm.Delete(context.Background(), "astaxie")) ^ client/cache/cache_test.go:137:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, bm.Put(context.Background(), "astaxie", "author", timeoutDuration)) ^ client/cache/cache_test.go:151:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(vv)) ^ client/cache/cache_test.go:156:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(vv)) ^ client/cache/cache_test.go:161:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ client/cache/cache_test.go:200:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, c.Incr(ctx, key)) ^ client/cache/conv_test.go:69:2: float-compare: use assert.InEpsilon (or InDelta) (testifylint) assert.Equal(t, f, GetFloat64(t1)) ^ client/cache/conv_test.go:71:2: float-compare: use assert.InEpsilon (or InDelta) (testifylint) assert.Equal(t, f, GetFloat64(t2)) ^ client/cache/conv_test.go:73:2: float-compare: use assert.InEpsilon (or InDelta) (testifylint) assert.Equal(t, f, GetFloat64(t3)) ^ client/cache/conv_test.go:77:2: float-compare: use assert.InEpsilon (or InDelta) (testifylint) assert.Equal(t, f2, GetFloat64(t4)) ^ client/cache/conv_test.go:79:2: float-compare: use assert.InEpsilon (or InDelta) (testifylint) assert.Equal(t, float64(0), GetFloat64(nil)) ^ client/cache/file_test.go:30:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ client/cache/file_test.go:41:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ client/cache/file_test.go:47:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, fc.DirectoryLevel, 2) ^ client/cache/file_test.go:48:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, fc.EmbedExpiry, 0) ^ client/cache/file_test.go:49:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, fc.FileSuffix, ".bin") ^ client/cache/file_test.go:52:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ client/cache/file_test.go:55:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ client/cache/file_test.go:62:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ client/cache/file_test.go:70:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ client/cache/file_test.go:85:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ client/cache/random_expired_cache_test.go:77:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(vv)) ^ client/cache/random_expired_cache_test.go:82:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(vv)) ^ client/cache/memcache/memcache_test.go:95:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(vv)) ^ client/cache/memcache/memcache_test.go:105:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(vv)) ^ client/cache/redis/redis_test.go:90:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(vv)) ^ client/cache/redis/redis_test.go:128:2: len: use assert.Len (testifylint) assert.Equal(t, 100, len(keys), "scan all error") ^ client/cache/redis/redis_test.go:136:2: empty: use assert.Empty (testifylint) assert.Equal(t, 0, len(keys)) ^ client/httplib/http_response_test.go:34:2: negative-positive: use assert.Positive (testifylint) assert.True(t, resp.ContentLength > 0) ^ client/httplib/httpclient_test.go:36:2: bool-compare: use assert.True (testifylint) assert.Equal(t, true, client.Setting.EnableCookie) ^ client/httplib/httpclient_test.go:95:2: suite-dont-use-pkg: use c.Require().NoError (testifylint) require.NoError(c.T(), err) ^ client/httplib/httpclient_test.go:130:3: suite-dont-use-pkg: use c.Require().NoError (testifylint) require.NoError(c.T(), err) ^ client/httplib/httplib_test.go:44:2: suite-dont-use-pkg: use h.Require().NoError (testifylint) require.NoError(h.T(), err) ^ client/httplib/httplib_test.go:110:3: suite-dont-use-pkg: use h.Require().NoError (testifylint) require.NoError(h.T(), err) ^ client/httplib/httplib_test.go:111:3: suite-dont-use-pkg: use h.Equal (testifylint) assert.Equal(h.T(), []byte("retry body"), body) ^ client/httplib/httplib_test.go:131:2: suite-dont-use-pkg: use h.Require().NoError (testifylint) require.NoError(h.T(), err) ^ client/httplib/httplib_test.go:496:2: negative-positive: use assert.Positive (testifylint) assert.True(t, req.req.ContentLength > 0) ^ client/httplib/httpclient_test.go:34:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ client/httplib/httplib_test.go:395:4: require-error: for error assertions use require (testifylint) assert.ErrorIs(t, err, tc.wantErr) ^ ```| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
local |
844.3 ± 57.8 | 804.2 | 998.3 | 1.07 ± 0.07 |
v1.59.1 |
792.2 ± 6.1 | 782.8 | 804.8 | 1.00 |
cilium/cilium
local
``` test/controlplane/node/localnode.go:109:2: require-error: for error assertions use require (testifylint) assert.NoError(errs, err) ^ bugtool/cmd/helper_test.go:54:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ bugtool/cmd/helper_test.go:56:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ bugtool/cmd/helper_test.go:61:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ bugtool/cmd/helper_test.go:63:2: error-nil: use require.Error (testifylint) require.NotNil(t, err) ^ bugtool/cmd/helper_test.go:65:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ bugtool/cmd/helper_test.go:67:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ bugtool/cmd/helper_test.go:71:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ bugtool/cmd/helper_test.go:73:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ bugtool/cmd/helper_test.go:75:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ bugtool/cmd/helper_test.go:80:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ bugtool/cmd/helper_test.go:82:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ daemon/cmd/daemon_privileged_test.go:37:4: empty: use assert.Empty (testifylint) assert.Len(t, addrs, 0) ^ daemon/cmd/daemon_test.go:253:2: bool-compare: use require.True (testifylint) require.Equal(t, true, numWorkerThreads() >= 2) ^ daemon/cmd/daemon_test.go:254:2: bool-compare: use require.True (testifylint) require.Equal(t, true, numWorkerThreads() >= runtime.NumCPU()) ^ daemon/cmd/endpoint_test.go:62:2: error-nil: use require.Error (testifylint) require.NotNil(t, err) ^ daemon/cmd/endpoint_test.go:99:2: error-nil: use require.Error (testifylint) require.NotNil(t, err) ^ daemon/cmd/endpoint_test.go:154:2: error-nil: use require.Error (testifylint) require.NotNil(t, err) ^ daemon/cmd/kube_proxy_healthz_test.go:94:2: bool-compare: use require.True (testifylint) require.Equal(t, true, lastUpdateTs.Equal(expectedTs)) ^ daemon/cmd/local_node_sync_test.go:211:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, n.Name, "test-node") ^ daemon/cmd/policy_test.go:233:2: bool-compare: use require.True (testifylint) require.Equal(t, true, ready) ^ daemon/cmd/policy_test.go:235:2: bool-compare: use require.True (testifylint) require.Equal(t, true, buildSuccess) ^ daemon/cmd/policy_test.go:242:2: bool-compare: use require.True (testifylint) require.Equal(t, true, ready) ^ daemon/cmd/policy_test.go:244:2: bool-compare: use require.True (testifylint) require.Equal(t, true, buildSuccess) ^ daemon/cmd/policy_test.go:346:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eQABar.Allows(qaBarSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:347:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eQABar.Allows(prodBarSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:348:2: bool-compare: use require.True (testifylint) require.Equal(t, true, eQABar.Allows(qaFooSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:349:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eQABar.Allows(prodFooSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:352:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eProdBar.Allows(0)) ^ daemon/cmd/policy_test.go:353:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eProdBar.Allows(qaBarSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:354:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eProdBar.Allows(prodBarSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:355:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eProdBar.Allows(qaFooSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:356:2: bool-compare: use require.True (testifylint) require.Equal(t, true, eProdBar.Allows(prodFooSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:357:2: bool-compare: use require.True (testifylint) require.Equal(t, true, eProdBar.Allows(prodFooJoeSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:510:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eQABar.Allows(qaBarSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:511:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eQABar.Allows(qaFooSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:606:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eQABar.Allows(qaBarSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:786:2: len: use require.Len (testifylint) require.Equal(t, 2, len(ds.d.policy.SearchRLocked(lbls))) ^ daemon/cmd/policy_test.go:802:2: len: use require.Len (testifylint) require.Equal(t, 2, len(ds.d.policy.SearchRLocked(lbls))) ^ daemon/cmd/policy_test.go:901:2: empty: use require.Empty (testifylint) require.Len(t, networkPolicies, 0) ^ daemon/cmd/policy_test.go:1062:2: empty: use require.Empty (testifylint) require.Len(t, networkPolicies, 0) ^ daemon/cmd/daemon_privileged_test.go:72:3: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ daemon/cmd/daemon_privileged_test.go:86:3: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ daemon/cmd/daemon_privileged_test.go:55:4: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ daemon/cmd/local_node_sync_test.go:206:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ daemon/cmd/map_test.go:64:2: require-error: for error assertions use require (testifylint) assert.NoError(err) ^ daemon/cmd/map_test.go:77:2: require-error: for error assertions use require (testifylint) assert.NoError(err) ^ daemon/cmd/map_test.go:88:2: require-error: for error assertions use require (testifylint) assert.NoError(err) ^ daemon/cmd/daemon_privileged_test.go:30:4: require-error: for error assertions use require (testifylint) assert.NoError(t, removeOldRouterState(false, net.ParseIP("10.0.0.1"))) ^ daemon/cmd/daemon_privileged_test.go:36:4: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ ```v1.59.1
``` test/controlplane/node/localnode.go:109:2: require-error: for error assertions use require (testifylint) assert.NoError(errs, err) ^ bugtool/cmd/helper_test.go:54:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ bugtool/cmd/helper_test.go:56:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ bugtool/cmd/helper_test.go:61:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ bugtool/cmd/helper_test.go:63:2: error-nil: use require.Error (testifylint) require.NotNil(t, err) ^ bugtool/cmd/helper_test.go:65:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ bugtool/cmd/helper_test.go:67:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ bugtool/cmd/helper_test.go:71:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ bugtool/cmd/helper_test.go:73:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ bugtool/cmd/helper_test.go:75:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ bugtool/cmd/helper_test.go:80:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ bugtool/cmd/helper_test.go:82:2: error-nil: use require.NoError (testifylint) require.Nil(t, err) ^ daemon/cmd/daemon_privileged_test.go:37:4: empty: use assert.Empty (testifylint) assert.Len(t, addrs, 0) ^ daemon/cmd/daemon_test.go:253:2: bool-compare: use require.True (testifylint) require.Equal(t, true, numWorkerThreads() >= 2) ^ daemon/cmd/daemon_test.go:254:2: bool-compare: use require.True (testifylint) require.Equal(t, true, numWorkerThreads() >= runtime.NumCPU()) ^ daemon/cmd/endpoint_test.go:62:2: error-nil: use require.Error (testifylint) require.NotNil(t, err) ^ daemon/cmd/endpoint_test.go:99:2: error-nil: use require.Error (testifylint) require.NotNil(t, err) ^ daemon/cmd/endpoint_test.go:154:2: error-nil: use require.Error (testifylint) require.NotNil(t, err) ^ daemon/cmd/kube_proxy_healthz_test.go:94:2: bool-compare: use require.True (testifylint) require.Equal(t, true, lastUpdateTs.Equal(expectedTs)) ^ daemon/cmd/local_node_sync_test.go:211:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, n.Name, "test-node") ^ daemon/cmd/policy_test.go:233:2: bool-compare: use require.True (testifylint) require.Equal(t, true, ready) ^ daemon/cmd/policy_test.go:235:2: bool-compare: use require.True (testifylint) require.Equal(t, true, buildSuccess) ^ daemon/cmd/policy_test.go:242:2: bool-compare: use require.True (testifylint) require.Equal(t, true, ready) ^ daemon/cmd/policy_test.go:244:2: bool-compare: use require.True (testifylint) require.Equal(t, true, buildSuccess) ^ daemon/cmd/policy_test.go:346:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eQABar.Allows(qaBarSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:347:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eQABar.Allows(prodBarSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:348:2: bool-compare: use require.True (testifylint) require.Equal(t, true, eQABar.Allows(qaFooSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:349:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eQABar.Allows(prodFooSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:352:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eProdBar.Allows(0)) ^ daemon/cmd/policy_test.go:353:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eProdBar.Allows(qaBarSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:354:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eProdBar.Allows(prodBarSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:355:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eProdBar.Allows(qaFooSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:356:2: bool-compare: use require.True (testifylint) require.Equal(t, true, eProdBar.Allows(prodFooSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:357:2: bool-compare: use require.True (testifylint) require.Equal(t, true, eProdBar.Allows(prodFooJoeSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:510:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eQABar.Allows(qaBarSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:511:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eQABar.Allows(qaFooSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:606:2: bool-compare: use require.False (testifylint) require.Equal(t, false, eQABar.Allows(qaBarSecLblsCtx.ID)) ^ daemon/cmd/policy_test.go:786:2: len: use require.Len (testifylint) require.Equal(t, 2, len(ds.d.policy.SearchRLocked(lbls))) ^ daemon/cmd/policy_test.go:802:2: len: use require.Len (testifylint) require.Equal(t, 2, len(ds.d.policy.SearchRLocked(lbls))) ^ daemon/cmd/policy_test.go:901:2: empty: use require.Empty (testifylint) require.Len(t, networkPolicies, 0) ^ daemon/cmd/policy_test.go:1062:2: empty: use require.Empty (testifylint) require.Len(t, networkPolicies, 0) ^ daemon/cmd/local_node_sync_test.go:206:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ daemon/cmd/daemon_privileged_test.go:55:4: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ daemon/cmd/map_test.go:88:2: require-error: for error assertions use require (testifylint) assert.NoError(err) ^ daemon/cmd/daemon_privileged_test.go:30:4: require-error: for error assertions use require (testifylint) assert.NoError(t, removeOldRouterState(false, net.ParseIP("10.0.0.1"))) ^ daemon/cmd/daemon_privileged_test.go:36:4: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ daemon/cmd/map_test.go:64:2: require-error: for error assertions use require (testifylint) assert.NoError(err) ^ daemon/cmd/map_test.go:77:2: require-error: for error assertions use require (testifylint) assert.NoError(err) ^ daemon/cmd/daemon_privileged_test.go:72:3: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ daemon/cmd/daemon_privileged_test.go:86:3: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ ```| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
local |
5.456 ± 0.040 | 5.404 | 5.520 | 1.00 ± 0.01 |
v1.59.1 |
5.431 ± 0.045 | 5.377 | 5.495 | 1.00 |
spf13/cobra
local
``` ```v1.59.1
``` ```| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
local |
313.2 ± 3.0 | 308.9 | 317.5 | 1.11 ± 0.02 |
v1.59.1 |
282.1 ± 2.8 | 278.1 | 287.9 | 1.00 |
hashicorp/consul
local
``` agent/metrics/testing.go:46:6: float-compare: use assert.InEpsilon (or InDelta) (testifylint) if !assert.Equal(t, value, got) { ^ agent/metrics/testing.go:93:6: float-compare: use assert.InEpsilon (or InDelta) (testifylint) if !assert.Equal(t, value, got) { ^ internal/resource/resourcetest/acls.go:35:3: error-nil: use require.NoError (testifylint) require.Nil(t, got, "expected fallthrough decision") ^ testrpc/wait.go:241:3: compares: use require.GreaterOrEqual (testifylint) require.True(r, reply.ReplicatedIndex >= minPolicyIndex, "Server hasn't replicated enough policies") ^ testrpc/wait.go:242:3: compares: use require.GreaterOrEqual (testifylint) require.True(r, reply.ReplicatedTokenIndex >= minTokenIndex, "Server hasn't replicated enough tokens") ^ testrpc/wait.go:243:3: compares: use require.GreaterOrEqual (testifylint) require.True(r, reply.ReplicatedRoleIndex >= minRoleIndex, "Server hasn't replicated enough roles") ^ agent/acl_endpoint_test.go:267:4: negative-positive: use require.Positive (testifylint) require.True(t, policy.CreateIndex > 0) ^ agent/acl_endpoint_test.go:270:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, policy.Hash, []byte{}) ^ agent/acl_endpoint_test.go:297:4: negative-positive: use require.Positive (testifylint) require.True(t, policy.CreateIndex > 0) ^ agent/acl_endpoint_test.go:300:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, policy.Hash, []byte{}) ^ agent/acl_endpoint_test.go:327:4: negative-positive: use require.Positive (testifylint) require.True(t, policy.CreateIndex > 0) ^ agent/acl_endpoint_test.go:330:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, policy.Hash, []byte{}) ^ agent/acl_endpoint_test.go:385:4: negative-positive: use require.Positive (testifylint) require.True(t, policy.CreateIndex > 0) ^ agent/acl_endpoint_test.go:386:4: compares: use require.Less (testifylint) require.True(t, policy.CreateIndex < policy.ModifyIndex) ^ agent/acl_endpoint_test.go:388:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, policy.Hash, []byte{}) ^ agent/acl_endpoint_test.go:525:4: negative-positive: use require.Positive (testifylint) require.True(t, role.CreateIndex > 0) ^ agent/acl_endpoint_test.go:528:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, role.Hash, []byte{}) ^ agent/acl_endpoint_test.go:558:4: negative-positive: use require.Positive (testifylint) require.True(t, role.CreateIndex > 0) ^ agent/acl_endpoint_test.go:561:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, role.Hash, []byte{}) ^ agent/acl_endpoint_test.go:629:4: negative-positive: use require.Positive (testifylint) require.True(t, role.CreateIndex > 0) ^ agent/acl_endpoint_test.go:630:4: compares: use require.Less (testifylint) require.True(t, role.CreateIndex < role.ModifyIndex) ^ agent/acl_endpoint_test.go:632:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, role.Hash, []byte{}) ^ agent/acl_endpoint_test.go:760:4: negative-positive: use require.Positive (testifylint) require.True(t, token.CreateIndex > 0) ^ agent/acl_endpoint_test.go:763:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, token.Hash, []byte{}) ^ agent/acl_endpoint_test.go:798:4: negative-positive: use require.Positive (testifylint) require.True(t, token.CreateIndex > 0) ^ agent/acl_endpoint_test.go:801:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, token.Hash, []byte{}) ^ agent/acl_endpoint_test.go:860:4: negative-positive: use require.Positive (testifylint) require.True(t, token.CreateIndex > 0) ^ agent/acl_endpoint_test.go:863:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, token.Hash, []byte{}) ^ agent/acl_endpoint_test.go:903:4: compares: use require.Less (testifylint) require.True(t, token.CreateIndex < token.ModifyIndex) ^ agent/acl_endpoint_test.go:945:4: compares: use require.Less (testifylint) require.True(t, token.CreateIndex < token.ModifyIndex) ^ agent/acl_endpoint_test.go:1636:4: compares: use require.Less (testifylint) require.True(t, method.CreateIndex < method.ModifyIndex) ^ agent/acl_endpoint_test.go:1823:4: compares: use require.Less (testifylint) require.True(t, rule.CreateIndex < rule.ModifyIndex) ^ agent/acl_endpoint_test.go:1938:4: empty: use require.Empty (testifylint) require.Len(t, token.Policies, 0) ^ agent/acl_endpoint_test.go:1939:4: empty: use require.Empty (testifylint) require.Len(t, token.Roles, 0) ^ agent/acl_endpoint_test.go:1942:4: empty: use require.Empty (testifylint) require.Len(t, token.ServiceIdentities[0].Datacenters, 0) ^ agent/acl_endpoint_test.go:1972:4: empty: use require.Empty (testifylint) require.Len(t, token.Policies, 0) ^ agent/acl_endpoint_test.go:1973:4: empty: use require.Empty (testifylint) require.Len(t, token.Roles, 0) ^ agent/acl_endpoint_test.go:1976:4: empty: use require.Empty (testifylint) require.Len(t, token.ServiceIdentities[0].Datacenters, 0) ^ agent/acl_endpoint_test.go:1994:4: empty: use require.Empty (testifylint) require.Len(t, tokens, 0) ^ agent/acl_endpoint_test.go:2187:5: empty: use require.Empty (testifylint) require.Len(t, token.Roles, 0) ^ agent/acl_endpoint_test.go:2190:5: empty: use require.Empty (testifylint) require.Len(t, svcid.Datacenters, 0) ^ agent/acl_test.go:459:2: empty: use require.Empty (testifylint) require.Len(t, members, 0) ^ agent/agent_ce_test.go:29:2: bool-compare: use require.False (testifylint) require.Equal(t, false, a.consulConfig().Reporting.License.Enabled) ^ agent/agent_ce_test.go:44:2: bool-compare: use require.False (testifylint) require.Equal(t, false, a.consulConfig().Reporting.License.Enabled) ^ agent/agent_endpoint_test.go:778:5: compares: use assert.GreaterOrEqual (testifylint) assert.True(t, elapsed >= tt.wantWait, "should have waited at least %s, "+ ^ agent/agent_endpoint_test.go:1817:2: float-compare: use require.InEpsilon (or InDelta) (testifylint) require.Equal(t, rate.Limit(2), shim.newCfg.RPCRateLimit) ^ agent/agent_endpoint_test.go:3592:2: len: use require.Len (testifylint) require.Equal(t, 3, len(checks)) ^ agent/agent_endpoint_test.go:6963:2: negative-positive: use assert.Positive (testifylint) assert.True(t, issued.ModifyIndex > 0) ^ agent/agent_endpoint_test.go:7112:2: negative-positive: use assert.Positive (testifylint) assert.True(t, issued.ModifyIndex > 0) ^ agent/agent_endpoint_test.go:7347:2: negative-positive: use assert.Positive (testifylint) assert.True(t, issued.ModifyIndex > 0) ^ ```v1.59.1
``` agent/metrics/testing.go:46:6: float-compare: use assert.InEpsilon (or InDelta) (testifylint) if !assert.Equal(t, value, got) { ^ agent/metrics/testing.go:93:6: float-compare: use assert.InEpsilon (or InDelta) (testifylint) if !assert.Equal(t, value, got) { ^ internal/resource/resourcetest/acls.go:35:3: error-nil: use require.NoError (testifylint) require.Nil(t, got, "expected fallthrough decision") ^ testrpc/wait.go:241:3: compares: use require.GreaterOrEqual (testifylint) require.True(r, reply.ReplicatedIndex >= minPolicyIndex, "Server hasn't replicated enough policies") ^ testrpc/wait.go:242:3: compares: use require.GreaterOrEqual (testifylint) require.True(r, reply.ReplicatedTokenIndex >= minTokenIndex, "Server hasn't replicated enough tokens") ^ testrpc/wait.go:243:3: compares: use require.GreaterOrEqual (testifylint) require.True(r, reply.ReplicatedRoleIndex >= minRoleIndex, "Server hasn't replicated enough roles") ^ agent/acl_endpoint_test.go:267:4: negative-positive: use require.Positive (testifylint) require.True(t, policy.CreateIndex > 0) ^ agent/acl_endpoint_test.go:270:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, policy.Hash, []byte{}) ^ agent/acl_endpoint_test.go:297:4: negative-positive: use require.Positive (testifylint) require.True(t, policy.CreateIndex > 0) ^ agent/acl_endpoint_test.go:300:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, policy.Hash, []byte{}) ^ agent/acl_endpoint_test.go:327:4: negative-positive: use require.Positive (testifylint) require.True(t, policy.CreateIndex > 0) ^ agent/acl_endpoint_test.go:330:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, policy.Hash, []byte{}) ^ agent/acl_endpoint_test.go:385:4: negative-positive: use require.Positive (testifylint) require.True(t, policy.CreateIndex > 0) ^ agent/acl_endpoint_test.go:386:4: compares: use require.Less (testifylint) require.True(t, policy.CreateIndex < policy.ModifyIndex) ^ agent/acl_endpoint_test.go:388:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, policy.Hash, []byte{}) ^ agent/acl_endpoint_test.go:525:4: negative-positive: use require.Positive (testifylint) require.True(t, role.CreateIndex > 0) ^ agent/acl_endpoint_test.go:528:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, role.Hash, []byte{}) ^ agent/acl_endpoint_test.go:558:4: negative-positive: use require.Positive (testifylint) require.True(t, role.CreateIndex > 0) ^ agent/acl_endpoint_test.go:561:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, role.Hash, []byte{}) ^ agent/acl_endpoint_test.go:629:4: negative-positive: use require.Positive (testifylint) require.True(t, role.CreateIndex > 0) ^ agent/acl_endpoint_test.go:630:4: compares: use require.Less (testifylint) require.True(t, role.CreateIndex < role.ModifyIndex) ^ agent/acl_endpoint_test.go:632:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, role.Hash, []byte{}) ^ agent/acl_endpoint_test.go:760:4: negative-positive: use require.Positive (testifylint) require.True(t, token.CreateIndex > 0) ^ agent/acl_endpoint_test.go:763:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, token.Hash, []byte{}) ^ agent/acl_endpoint_test.go:798:4: negative-positive: use require.Positive (testifylint) require.True(t, token.CreateIndex > 0) ^ agent/acl_endpoint_test.go:801:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, token.Hash, []byte{}) ^ agent/acl_endpoint_test.go:860:4: negative-positive: use require.Positive (testifylint) require.True(t, token.CreateIndex > 0) ^ agent/acl_endpoint_test.go:863:4: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, token.Hash, []byte{}) ^ agent/acl_endpoint_test.go:903:4: compares: use require.Less (testifylint) require.True(t, token.CreateIndex < token.ModifyIndex) ^ agent/acl_endpoint_test.go:945:4: compares: use require.Less (testifylint) require.True(t, token.CreateIndex < token.ModifyIndex) ^ agent/acl_endpoint_test.go:1636:4: compares: use require.Less (testifylint) require.True(t, method.CreateIndex < method.ModifyIndex) ^ agent/acl_endpoint_test.go:1823:4: compares: use require.Less (testifylint) require.True(t, rule.CreateIndex < rule.ModifyIndex) ^ agent/acl_endpoint_test.go:1938:4: empty: use require.Empty (testifylint) require.Len(t, token.Policies, 0) ^ agent/acl_endpoint_test.go:1939:4: empty: use require.Empty (testifylint) require.Len(t, token.Roles, 0) ^ agent/acl_endpoint_test.go:1942:4: empty: use require.Empty (testifylint) require.Len(t, token.ServiceIdentities[0].Datacenters, 0) ^ agent/acl_endpoint_test.go:1972:4: empty: use require.Empty (testifylint) require.Len(t, token.Policies, 0) ^ agent/acl_endpoint_test.go:1973:4: empty: use require.Empty (testifylint) require.Len(t, token.Roles, 0) ^ agent/acl_endpoint_test.go:1976:4: empty: use require.Empty (testifylint) require.Len(t, token.ServiceIdentities[0].Datacenters, 0) ^ agent/acl_endpoint_test.go:1994:4: empty: use require.Empty (testifylint) require.Len(t, tokens, 0) ^ agent/acl_endpoint_test.go:2187:5: empty: use require.Empty (testifylint) require.Len(t, token.Roles, 0) ^ agent/acl_endpoint_test.go:2190:5: empty: use require.Empty (testifylint) require.Len(t, svcid.Datacenters, 0) ^ agent/acl_test.go:459:2: empty: use require.Empty (testifylint) require.Len(t, members, 0) ^ agent/agent_ce_test.go:29:2: bool-compare: use require.False (testifylint) require.Equal(t, false, a.consulConfig().Reporting.License.Enabled) ^ agent/agent_ce_test.go:44:2: bool-compare: use require.False (testifylint) require.Equal(t, false, a.consulConfig().Reporting.License.Enabled) ^ agent/agent_endpoint_test.go:778:5: compares: use assert.GreaterOrEqual (testifylint) assert.True(t, elapsed >= tt.wantWait, "should have waited at least %s, "+ ^ agent/agent_endpoint_test.go:1817:2: float-compare: use require.InEpsilon (or InDelta) (testifylint) require.Equal(t, rate.Limit(2), shim.newCfg.RPCRateLimit) ^ agent/agent_endpoint_test.go:3592:2: len: use require.Len (testifylint) require.Equal(t, 3, len(checks)) ^ agent/agent_endpoint_test.go:6963:2: negative-positive: use assert.Positive (testifylint) assert.True(t, issued.ModifyIndex > 0) ^ agent/agent_endpoint_test.go:7112:2: negative-positive: use assert.Positive (testifylint) assert.True(t, issued.ModifyIndex > 0) ^ agent/agent_endpoint_test.go:7347:2: negative-positive: use assert.Positive (testifylint) assert.True(t, issued.ModifyIndex > 0) ^ ```| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
local |
5.859 ± 0.111 | 5.767 | 6.155 | 1.02 ± 0.02 |
v1.59.1 |
5.753 ± 0.041 | 5.690 | 5.818 | 1.00 |
go-delve/delve
local
``` ```v1.59.1
``` ```| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
local |
843.6 ± 21.0 | 807.6 | 867.4 | 1.05 ± 0.03 |
v1.59.1 |
804.3 ± 12.0 | 786.8 | 824.3 | 1.00 |
etcd-io/etcd
local
``` ```v1.59.1
``` ```| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
local |
540.6 ± 19.6 | 528.1 | 594.6 | 1.06 ± 0.05 |
v1.59.1 |
508.7 ± 11.9 | 498.6 | 540.0 | 1.00 |
go-gitea/gitea
local
``` models/actions/runner_token_test.go:20:2: expected-actual: need to reverse actual and expected values (testifylint) assert.EqualValues(t, token, expectedToken) ^ models/actions/runner_token_test.go:29:2: expected-actual: need to reverse actual and expected values (testifylint) assert.EqualValues(t, token, expectedToken) ^ models/actions/runner_token_test.go:39:2: expected-actual: need to reverse actual and expected values (testifylint) assert.EqualValues(t, token, expectedToken) ^ models/activities/action_test.go:69:2: empty: use assert.Empty (testifylint) assert.Len(t, actions, 0) ^ models/activities/action_test.go:85:2: empty: use assert.Empty (testifylint) assert.Len(t, actions, 0) ^ models/activities/action_test.go:147:2: empty: use assert.Empty (testifylint) assert.Len(t, actions, 0) ^ models/activities/action_test.go:242:2: empty: use assert.Empty (testifylint) assert.Len(t, actions, 0) ^ models/activities/user_heatmap_test.go:94:3: formatter: remove unnecessary fmt.Sprintf (testifylint) assert.Equal(t, tc.CountResult, contributions, fmt.Sprintf("testcase '%s'", tc.desc)) ^ models/auth/oauth2_test.go:21:2: negative-positive: use assert.Positive (testifylint) assert.True(t, len(secret) > 0) ^ models/auth/oauth2_test.go:168:2: compares: use assert.Greater (testifylint) assert.True(t, len(code.Code) > 32) // secret length > 32 ^ models/db/iterate_test.go:41:3: useless-assert: asserting of the same variable (testifylint) assert.EqualValues(t, repoUnit.RepoID, repoUnit.RepoID) ^ models/db/iterate_test.go:42:3: useless-assert: asserting of the same variable (testifylint) assert.EqualValues(t, repoUnit.CreatedUnix, repoUnit.CreatedUnix) ^ models/git/commit_status_test.go:35:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, int(maxResults), 5) ^ models/git/commit_status_test.go:64:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, int(maxResults), 5) ^ models/git/protected_branch_test.go:74:3: formatter: remove unnecessary fmt.Sprintf (testifylint) assert.EqualValues(t, kase.ExpectedMatch, pb.Match(kase.BranchName), ^ models/issues/comment_test.go:67:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, issues_model.CommentType(0), issues_model.CommentTypeComment) ^ models/issues/issue_test.go:436:2: expected-actual: need to reverse actual and expected values (testifylint) assert.EqualValues(t, milestone.ID, 1) ^ models/issues/issue_watch_test.go:51:2: empty: use assert.Empty (testifylint) assert.Len(t, iws, 0) ^ models/issues/issue_watch_test.go:56:2: empty: use assert.Empty (testifylint) assert.Len(t, iws, 0) ^ models/issues/issue_watch_test.go:61:2: empty: use assert.Empty (testifylint) assert.Len(t, iws, 0) ^ models/issues/label_test.go:231:2: empty: use assert.Empty (testifylint) assert.Len(t, labels, 0) ^ models/issues/label_test.go:254:2: expected-actual: need to reverse actual and expected values (testifylint) assert.EqualValues(t, newLabel.ArchivedUnix, 0) ^ models/issues/milestone_test.go:90:2: empty: use assert.Empty (testifylint) assert.Len(t, milestones, 0) ^ models/issues/pull_test.go:86:2: empty: use assert.Empty (testifylint) assert.Len(t, pull.RequestedReviewers, 0) ^ models/issues/stopwatch_test.go:35:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, issues_model.CancelStopwatch(db.DefaultContext, user1, issue2)) ^ models/issues/tracked_time_test.go:72:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, issue.RepoID, int64(2)) ^ models/migrations/v1_16/v193_test.go:59:3: negative-positive: use assert.Positive (testifylint) assert.Greater(t, attach.RepoID, int64(0)) ^ models/migrations/v1_16/v193_test.go:60:3: negative-positive: use assert.Positive (testifylint) assert.Greater(t, attach.IssueID, int64(0)) ^ models/migrations/v1_16/v193_test.go:72:3: negative-positive: use assert.Positive (testifylint) assert.Greater(t, attach.RepoID, int64(0)) ^ models/org_team_test.go:126:2: compares: use assert.Less (testifylint) assert.True(t, accessMode < perm.AccessModeWrite) ^ models/unittest/consistency.go:35:3: require-error: for error assertions use require (testifylint) assert.NoError(t, db.GetEngine(db.DefaultContext).Table(bean).Find(ptrToSliceValue.Interface())) ^ models/unittest/consistency.go:47:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ models/unittest/consistency.go:152:3: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ models/unittest/testdb.go:260:2: require-error: for error assertions use require (testifylint) assert.NoError(t, CopyDir(metaPath, setting.RepoRootPath)) ^ models/unittest/testdb.go:262:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ models/unittest/unit_tests.go:69:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ models/unittest/unit_tests.go:80:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ models/unittest/unit_tests.go:81:2: len: use assert.Len (testifylint) assert.True(t, len(res) == 1, ^ models/unittest/unit_tests.go:108:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ models/unittest/unit_tests.go:115:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ models/unittest/unit_tests.go:123:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ modules/indexer/issues/internal/tests/tests.go:116:4: len: use assert.Len (testifylint) assert.Equal(t, 5, len(result.Hits)) ^ modules/indexer/issues/internal/tests/tests.go:179:4: len: use assert.Len (testifylint) assert.Equal(t, 5, len(result.Hits)) ^ modules/indexer/issues/internal/tests/tests.go:195:4: len: use assert.Len (testifylint) assert.Equal(t, 5, len(result.Hits)) ^ modules/indexer/issues/internal/tests/tests.go:211:4: len: use assert.Len (testifylint) assert.Equal(t, 5, len(result.Hits)) ^ modules/indexer/issues/internal/tests/tests.go:227:4: len: use assert.Len (testifylint) assert.Equal(t, 5, len(result.Hits)) ^ modules/indexer/issues/internal/tests/tests.go:277:4: len: use assert.Len (testifylint) assert.Equal(t, 5, len(result.Hits)) ^ modules/indexer/issues/internal/tests/tests.go:295:4: len: use assert.Len (testifylint) assert.Equal(t, 5, len(result.Hits)) ^ modules/indexer/issues/internal/tests/tests.go:313:4: len: use assert.Len (testifylint) assert.Equal(t, 5, len(result.Hits)) ^ modules/indexer/issues/internal/tests/tests.go:331:4: len: use assert.Len (testifylint) assert.Equal(t, 5, len(result.Hits)) ^ ```v1.59.1
``` models/actions/runner_token_test.go:20:2: expected-actual: need to reverse actual and expected values (testifylint) assert.EqualValues(t, token, expectedToken) ^ models/actions/runner_token_test.go:29:2: expected-actual: need to reverse actual and expected values (testifylint) assert.EqualValues(t, token, expectedToken) ^ models/actions/runner_token_test.go:39:2: expected-actual: need to reverse actual and expected values (testifylint) assert.EqualValues(t, token, expectedToken) ^ models/activities/action_test.go:69:2: empty: use assert.Empty (testifylint) assert.Len(t, actions, 0) ^ models/activities/action_test.go:85:2: empty: use assert.Empty (testifylint) assert.Len(t, actions, 0) ^ models/activities/action_test.go:147:2: empty: use assert.Empty (testifylint) assert.Len(t, actions, 0) ^ models/activities/action_test.go:242:2: empty: use assert.Empty (testifylint) assert.Len(t, actions, 0) ^ models/auth/oauth2_test.go:21:2: negative-positive: use assert.Positive (testifylint) assert.True(t, len(secret) > 0) ^ models/auth/oauth2_test.go:168:2: compares: use assert.Greater (testifylint) assert.True(t, len(code.Code) > 32) // secret length > 32 ^ models/db/iterate_test.go:41:3: useless-assert: asserting of the same variable (testifylint) assert.EqualValues(t, repoUnit.RepoID, repoUnit.RepoID) ^ models/db/iterate_test.go:42:3: useless-assert: asserting of the same variable (testifylint) assert.EqualValues(t, repoUnit.CreatedUnix, repoUnit.CreatedUnix) ^ models/git/commit_status_test.go:35:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, int(maxResults), 5) ^ models/git/commit_status_test.go:64:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, int(maxResults), 5) ^ models/issues/comment_test.go:67:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, issues_model.CommentType(0), issues_model.CommentTypeComment) ^ models/issues/issue_test.go:436:2: expected-actual: need to reverse actual and expected values (testifylint) assert.EqualValues(t, milestone.ID, 1) ^ models/issues/issue_watch_test.go:51:2: empty: use assert.Empty (testifylint) assert.Len(t, iws, 0) ^ models/issues/issue_watch_test.go:56:2: empty: use assert.Empty (testifylint) assert.Len(t, iws, 0) ^ models/issues/issue_watch_test.go:61:2: empty: use assert.Empty (testifylint) assert.Len(t, iws, 0) ^ models/issues/label_test.go:231:2: empty: use assert.Empty (testifylint) assert.Len(t, labels, 0) ^ models/issues/label_test.go:254:2: expected-actual: need to reverse actual and expected values (testifylint) assert.EqualValues(t, newLabel.ArchivedUnix, 0) ^ models/issues/milestone_test.go:90:2: empty: use assert.Empty (testifylint) assert.Len(t, milestones, 0) ^ models/issues/pull_test.go:86:2: empty: use assert.Empty (testifylint) assert.Len(t, pull.RequestedReviewers, 0) ^ models/issues/stopwatch_test.go:35:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, issues_model.CancelStopwatch(db.DefaultContext, user1, issue2)) ^ models/issues/tracked_time_test.go:72:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, issue.RepoID, int64(2)) ^ models/migrations/v1_22/v286_test.go:110:2: bool-compare: use assert.True (testifylint) assert.EqualValues(t, true, ok) ^ models/migrations/v1_22/v286_test.go:116:2: bool-compare: use assert.True (testifylint) assert.EqualValues(t, true, ok) ^ models/org_team_test.go:126:2: compares: use assert.Less (testifylint) assert.True(t, accessMode < perm.AccessModeWrite) ^ models/perm/access_mode_test.go:18:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, AccessMode(4), AccessModeOwner) ^ models/unittest/consistency.go:35:3: require-error: for error assertions use require (testifylint) assert.NoError(t, db.GetEngine(db.DefaultContext).Table(bean).Find(ptrToSliceValue.Interface())) ^ models/unittest/consistency.go:47:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ models/unittest/consistency.go:152:3: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ models/unittest/testdb.go:260:2: require-error: for error assertions use require (testifylint) assert.NoError(t, CopyDir(metaPath, setting.RepoRootPath)) ^ models/unittest/testdb.go:262:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ models/unittest/testdb.go:268:3: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ models/unittest/unit_tests.go:69:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ models/unittest/unit_tests.go:81:2: len: use assert.Len (testifylint) assert.True(t, len(res) == 1, ^ models/unittest/unit_tests.go:108:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ models/unittest/unit_tests.go:115:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ models/unittest/unit_tests.go:123:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ models/user/email_address_test.go:101:2: compares: use assert.Greater (testifylint) assert.True(t, count > 5) ^ models/user/user_test.go:201:3: empty: use assert.NotEmpty (testifylint) assert.NotEqual(t, len(strings.TrimSpace(sig.Name)), 0) ^ modules/indexer/issues/internal/tests/tests.go:116:4: len: use assert.Len (testifylint) assert.Equal(t, 5, len(result.Hits)) ^ modules/indexer/issues/internal/tests/tests.go:179:4: len: use assert.Len (testifylint) assert.Equal(t, 5, len(result.Hits)) ^ modules/indexer/issues/internal/tests/tests.go:195:4: len: use assert.Len (testifylint) assert.Equal(t, 5, len(result.Hits)) ^ modules/indexer/issues/internal/tests/tests.go:211:4: len: use assert.Len (testifylint) assert.Equal(t, 5, len(result.Hits)) ^ modules/indexer/issues/internal/tests/tests.go:227:4: len: use assert.Len (testifylint) assert.Equal(t, 5, len(result.Hits)) ^ modules/indexer/issues/internal/tests/tests.go:277:4: len: use assert.Len (testifylint) assert.Equal(t, 5, len(result.Hits)) ^ modules/indexer/issues/internal/tests/tests.go:295:4: len: use assert.Len (testifylint) assert.Equal(t, 5, len(result.Hits)) ^ modules/indexer/issues/internal/tests/tests.go:313:4: len: use assert.Len (testifylint) assert.Equal(t, 5, len(result.Hits)) ^ modules/indexer/issues/internal/tests/tests.go:331:4: len: use assert.Len (testifylint) assert.Equal(t, 5, len(result.Hits)) ^ ```| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
local |
3.612 ± 0.043 | 3.539 | 3.675 | 1.01 ± 0.02 |
v1.59.1 |
3.581 ± 0.053 | 3.536 | 3.720 | 1.00 |
google/go-github
local
``` ```v1.59.1
``` ```| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
local |
1.394 ± 0.030 | 1.349 | 1.446 | 1.05 ± 0.03 |
v1.59.1 |
1.330 ± 0.023 | 1.296 | 1.364 | 1.00 |
golangci/golangci-lint
local
``` ```v1.59.1
``` ```| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
local |
911.1 ± 14.8 | 881.5 | 937.3 | 1.04 ± 0.03 |
v1.59.1 |
877.4 ± 16.5 | 847.2 | 897.8 | 1.00 |
goreleaser/goreleaser
local
``` internal/client/gitea_test.go:629:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ internal/client/gitea_test.go:631:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ internal/client/github_test.go:275:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ internal/client/github_test.go:277:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ internal/client/github_test.go:320:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ internal/client/github_test.go:322:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ internal/client/github_test.go:390:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ internal/client/github_test.go:392:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ internal/client/github_test.go:437:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ internal/client/github_test.go:439:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, json.Unmarshal(got, &pr)) ^ ```v1.59.1
``` internal/client/gitea_test.go:629:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ internal/client/gitea_test.go:631:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ internal/client/github_test.go:275:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ internal/client/github_test.go:277:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ internal/client/github_test.go:320:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ internal/client/github_test.go:322:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ internal/client/github_test.go:390:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ internal/client/github_test.go:392:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ internal/client/github_test.go:437:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ internal/client/github_test.go:439:4: go-require: do not use require in http handlers (testifylint) require.NoError(t, json.Unmarshal(got, &pr)) ^ ```| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
local |
1.505 ± 0.056 | 1.457 | 1.626 | 1.02 ± 0.05 |
v1.59.1 |
1.472 ± 0.045 | 1.412 | 1.575 | 1.00 |
grpc/grpc-go
local
``` ```v1.59.1
``` ```| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
local |
1.402 ± 0.049 | 1.346 | 1.513 | 1.03 ± 0.04 |
v1.59.1 |
1.366 ± 0.023 | 1.328 | 1.395 | 1.00 |
gohugoio/hugo
local
``` ```v1.59.1
``` ```| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
local |
2.230 ± 0.075 | 2.169 | 2.434 | 1.01 ± 0.04 |
v1.59.1 |
2.197 ± 0.033 | 2.159 | 2.278 | 1.00 |
kubernetes/kubernetes
local
``` test/e2e/scheduling/predicates.go:53:2: blank-import: avoid blank import of github.com/stretchr/testify/assert as it does nothing (testifylint) _ "github.com/stretchr/testify/assert" ^ test/e2e/scheduling/preemption.go:53:2: blank-import: avoid blank import of github.com/stretchr/testify/assert as it does nothing (testifylint) _ "github.com/stretchr/testify/assert" ^ test/e2e/scheduling/priorities.go:30:2: blank-import: avoid blank import of github.com/stretchr/testify/assert as it does nothing (testifylint) _ "github.com/stretchr/testify/assert" ^ test/e2e/apimachinery/apply.go:44:2: blank-import: avoid blank import of github.com/stretchr/testify/assert as it does nothing (testifylint) _ "github.com/stretchr/testify/assert" ^ test/e2e/apimachinery/crd_conversion_webhook.go:49:2: blank-import: avoid blank import of github.com/stretchr/testify/assert as it does nothing (testifylint) _ "github.com/stretchr/testify/assert" ^ test/e2e/apimachinery/field_validation.go:27:2: blank-import: avoid blank import of github.com/stretchr/testify/assert as it does nothing (testifylint) _ "github.com/stretchr/testify/assert" ^ test/e2e/apimachinery/openapiv3.go:47:2: blank-import: avoid blank import of github.com/stretchr/testify/assert as it does nothing (testifylint) _ "github.com/stretchr/testify/assert" ^ test/e2e/apimachinery/webhook.go:57:2: blank-import: avoid blank import of github.com/stretchr/testify/assert as it does nothing (testifylint) _ "github.com/stretchr/testify/assert" ^ test/e2e/node/taints.go:39:2: blank-import: avoid blank import of github.com/stretchr/testify/assert as it does nothing (testifylint) _ "github.com/stretchr/testify/assert" ^ test/utils/oidc/testserver.go:139:3: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ test/utils/oidc/testserver.go:153:3: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ cmd/kube-proxy/app/server_test.go:260:3: require-error: for error assertions use require (testifylint) assert.NoError(t, err, "unexpected error for %s: %v", tc.name, err) ^ cmd/kubeadm/app/cmd/certs_test.go:361:3: require-error: for error assertions use require (testifylint) assert.NoErrorf(t, err, "failed to load key file: %s", name) ^ cmd/kubeadm/app/cmd/certs_test.go:364:3: require-error: for error assertions use require (testifylint) assert.NoError(t, err, "failed to load CSR file: %s", name) ^ cmd/kubeadm/app/cmd/certs_test.go:370:3: require-error: for error assertions use require (testifylint) assert.NoErrorf(t, err, "failed to load kubeconfig file: %s", name) ^ cmd/kubeadm/app/cmd/certs_test.go:486:5: require-error: for error assertions use require (testifylint) assert.Error(t, err) ^ pkg/api/v1/resource/helpers_test.go:112:3: expected-actual: need to reverse actual and expected values (testifylint) as.Equal(actual, tc.expectedValue, "expected test case [%d] %v: to return %q; got %q instead", idx, tc.cName, tc.expectedValue, actual) ^ pkg/api/v1/resource/helpers_test.go:264:4: error-nil: use as.NoError (testifylint) as.Nil(err, "expected test case [%d] to not return an error; got %v", idx, err) ^ pkg/apis/autoscaling/v2beta1/conversion_test.go:33:2: require-error: for error assertions use require (testifylint) assert.NoError(t, RegisterConversions(scheme)) ^ pkg/apis/core/validation/validation_test.go:25760:4: formatter: remove unnecessary fmt.Sprintf (testifylint) assert.Error(t, err, fmt.Sprintf("Profile %s should not be valid", test.profile)) ^ pkg/apis/extensions/v1beta1/conversion_test.go:32:2: require-error: for error assertions use require (testifylint) assert.NoError(t, RegisterConversions(scheme)) ^ pkg/apis/networking/v1beta1/conversion_test.go:32:2: require-error: for error assertions use require (testifylint) assert.NoError(t, RegisterConversions(scheme)) ^ pkg/client/tests/remotecommand_test.go:128:3: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ pkg/controller/controller_utils_test.go:429:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, terminatingPods, int32(2)) ^ pkg/controller/controller_utils_test.go:432:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, len(terminatingList), int(2)) ^ pkg/controller/controller_utils_test.go:960:3: require-error: for error assertions use require (testifylint) assert.NoError(t, err, "%s: RemoveTaintOffNode() error = %v", test.name, err) ^ pkg/controller/controller_utils_test.go:1199:3: require-error: for error assertions use require (testifylint) assert.NoError(t, err, "%s: AddOrUpdateTaintOnNode() error = %v", test.name, err) ^ pkg/controller/endpointslice/endpointslice_controller_test.go:198:2: empty: use assert.Empty (testifylint) assert.Len(t, client.Actions(), 0) ^ pkg/controller/endpointslice/endpointslice_controller_test.go:265:4: empty: use assert.Empty (testifylint) assert.Len(t, client.Actions(), 0) ^ pkg/controller/endpointslice/endpointslice_controller_test.go:269:4: empty: use assert.Empty (testifylint) assert.Len(t, sliceList.Items, 0, "Expected 0 endpoint slices") ^ pkg/controller/endpointslice/endpointslice_controller_test.go:291:2: empty: use assert.Empty (testifylint) assert.Len(t, client.Actions(), 0) ^ pkg/controller/endpointslice/endpointslice_controller_test.go:303:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err, "Expected no error fetching endpoint slices") ^ pkg/controller/endpointslice/endpointslice_controller_test.go:341:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err, "Expected no error syncing service") ^ pkg/controller/endpointslice/endpointslice_controller_test.go:344:2: empty: use assert.Empty (testifylint) assert.Len(t, client.Actions(), 0) ^ pkg/controller/endpointslice/endpointslice_controller_test.go:371:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err, "Expected no error fetching endpoint slices") ^ pkg/controller/endpointslice/endpointslice_controller_test.go:377:2: expected-actual: need to reverse actual and expected values (testifylint) assert.EqualValues(t, endpoint.TargetRef, &v1.ObjectReference{Kind: "Pod", Namespace: ns, Name: pod1.Name}) ^ pkg/controller/endpointslice/endpointslice_controller_test.go:387:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err, "Expected no error syncing service") ^ pkg/controller/endpointslice/endpointslice_controller_test.go:418:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err, "Expected no error syncing service") ^ pkg/controller/endpointslice/endpointslice_controller_test.go:508:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err, "Expected no error syncing service") ^ pkg/controller/endpointslice/endpointslice_controller_test.go:1295:4: error-nil: use assert.NoError (testifylint) assert.Nil(t, err, "Expected no error creating service") ^ pkg/controller/endpointslice/endpointslice_controller_test.go:1299:4: error-nil: use assert.NoError (testifylint) assert.Nil(t, err) ^ pkg/controller/endpointslice/endpointslice_controller_test.go:1304:4: error-nil: use assert.NoError (testifylint) assert.Nil(t, err, "Expected no error fetching endpoint slices") ^ pkg/controller/endpointslice/endpointslice_controller_test.go:1687:5: error-nil: use assert.NoError (testifylint) assert.Nil(t, err, "error while retrieving old value of %q: %v", update.podName, err) ^ pkg/controller/endpointslice/endpointslice_controller_test.go:1688:5: bool-compare: use assert.True (testifylint) assert.Equal(t, true, exists, "pod should exist") ^ pkg/controller/garbagecollector/garbagecollector_test.go:107:2: empty: use assert.Empty (testifylint) assert.Equal(t, 0, len(gc.dependencyGraphBuilder.monitors)) ^ pkg/controller/garbagecollector/garbagecollector_test.go:115:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(gc.dependencyGraphBuilder.monitors)) ^ pkg/controller/garbagecollector/garbagecollector_test.go:121:2: len: use assert.Len (testifylint) assert.Equal(t, 1, len(gc.dependencyGraphBuilder.monitors)) ^ pkg/controller/garbagecollector/garbagecollector_test.go:129:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(gc.dependencyGraphBuilder.monitors)) ^ pkg/controller/garbagecollector/garbagecollector_test.go:135:2: len: use assert.Len (testifylint) assert.Equal(t, 1, len(gc.dependencyGraphBuilder.monitors)) ^ pkg/controller/podautoscaler/horizontal_test.go:760:5: formatter: remove unnecessary fmt.Sprintf (testifylint) assert.False(t, true, fmt.Sprintf("Unexpected event: %s / %s", obj.Reason, obj.Message)) ^ ```v1.59.1
``` test/e2e/scheduling/predicates.go:53:2: blank-import: avoid blank import of github.com/stretchr/testify/assert as it does nothing (testifylint) _ "github.com/stretchr/testify/assert" ^ test/e2e/scheduling/preemption.go:53:2: blank-import: avoid blank import of github.com/stretchr/testify/assert as it does nothing (testifylint) _ "github.com/stretchr/testify/assert" ^ test/e2e/scheduling/priorities.go:30:2: blank-import: avoid blank import of github.com/stretchr/testify/assert as it does nothing (testifylint) _ "github.com/stretchr/testify/assert" ^ test/e2e/apimachinery/apply.go:44:2: blank-import: avoid blank import of github.com/stretchr/testify/assert as it does nothing (testifylint) _ "github.com/stretchr/testify/assert" ^ test/e2e/apimachinery/crd_conversion_webhook.go:49:2: blank-import: avoid blank import of github.com/stretchr/testify/assert as it does nothing (testifylint) _ "github.com/stretchr/testify/assert" ^ test/e2e/apimachinery/field_validation.go:27:2: blank-import: avoid blank import of github.com/stretchr/testify/assert as it does nothing (testifylint) _ "github.com/stretchr/testify/assert" ^ test/e2e/apimachinery/openapiv3.go:47:2: blank-import: avoid blank import of github.com/stretchr/testify/assert as it does nothing (testifylint) _ "github.com/stretchr/testify/assert" ^ test/e2e/apimachinery/webhook.go:57:2: blank-import: avoid blank import of github.com/stretchr/testify/assert as it does nothing (testifylint) _ "github.com/stretchr/testify/assert" ^ test/e2e/node/taints.go:39:2: blank-import: avoid blank import of github.com/stretchr/testify/assert as it does nothing (testifylint) _ "github.com/stretchr/testify/assert" ^ test/utils/oidc/testserver.go:139:3: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ test/utils/oidc/testserver.go:153:3: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ cmd/kube-proxy/app/server_test.go:260:3: require-error: for error assertions use require (testifylint) assert.NoError(t, err, "unexpected error for %s: %v", tc.name, err) ^ cmd/kubeadm/app/cmd/certs_test.go:361:3: require-error: for error assertions use require (testifylint) assert.NoErrorf(t, err, "failed to load key file: %s", name) ^ cmd/kubeadm/app/cmd/certs_test.go:364:3: require-error: for error assertions use require (testifylint) assert.NoError(t, err, "failed to load CSR file: %s", name) ^ cmd/kubeadm/app/cmd/certs_test.go:370:3: require-error: for error assertions use require (testifylint) assert.NoErrorf(t, err, "failed to load kubeconfig file: %s", name) ^ cmd/kubeadm/app/cmd/certs_test.go:486:5: require-error: for error assertions use require (testifylint) assert.Error(t, err) ^ pkg/api/v1/resource/helpers_test.go:112:3: expected-actual: need to reverse actual and expected values (testifylint) as.Equal(actual, tc.expectedValue, "expected test case [%d] %v: to return %q; got %q instead", idx, tc.cName, tc.expectedValue, actual) ^ pkg/api/v1/resource/helpers_test.go:264:4: error-nil: use as.NoError (testifylint) as.Nil(err, "expected test case [%d] to not return an error; got %v", idx, err) ^ pkg/apis/autoscaling/v2beta1/conversion_test.go:33:2: require-error: for error assertions use require (testifylint) assert.NoError(t, RegisterConversions(scheme)) ^ pkg/apis/extensions/v1beta1/conversion_test.go:32:2: require-error: for error assertions use require (testifylint) assert.NoError(t, RegisterConversions(scheme)) ^ pkg/apis/networking/v1beta1/conversion_test.go:32:2: require-error: for error assertions use require (testifylint) assert.NoError(t, RegisterConversions(scheme)) ^ pkg/client/tests/remotecommand_test.go:128:3: go-require: do not use require in http handlers (testifylint) require.NoError(t, err) ^ pkg/controller/controller_utils_test.go:429:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, terminatingPods, int32(2)) ^ pkg/controller/controller_utils_test.go:432:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, len(terminatingList), int(2)) ^ pkg/controller/controller_utils_test.go:186:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err, "Couldn't get key for object %#v: %v", rc, err) ^ pkg/controller/controller_utils_test.go:241:4: require-error: for error assertions use require (testifylint) assert.NoError(t, err, "Could not get expectations for rc, exists %v and err %v", exists, err) ^ pkg/controller/endpointslice/endpointslice_controller_test.go:198:2: empty: use assert.Empty (testifylint) assert.Len(t, client.Actions(), 0) ^ pkg/controller/endpointslice/endpointslice_controller_test.go:265:4: empty: use assert.Empty (testifylint) assert.Len(t, client.Actions(), 0) ^ pkg/controller/endpointslice/endpointslice_controller_test.go:269:4: empty: use assert.Empty (testifylint) assert.Len(t, sliceList.Items, 0, "Expected 0 endpoint slices") ^ pkg/controller/endpointslice/endpointslice_controller_test.go:291:2: empty: use assert.Empty (testifylint) assert.Len(t, client.Actions(), 0) ^ pkg/controller/endpointslice/endpointslice_controller_test.go:303:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err, "Expected no error fetching endpoint slices") ^ pkg/controller/endpointslice/endpointslice_controller_test.go:341:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err, "Expected no error syncing service") ^ pkg/controller/endpointslice/endpointslice_controller_test.go:344:2: empty: use assert.Empty (testifylint) assert.Len(t, client.Actions(), 0) ^ pkg/controller/endpointslice/endpointslice_controller_test.go:371:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err, "Expected no error fetching endpoint slices") ^ pkg/controller/endpointslice/endpointslice_controller_test.go:377:2: expected-actual: need to reverse actual and expected values (testifylint) assert.EqualValues(t, endpoint.TargetRef, &v1.ObjectReference{Kind: "Pod", Namespace: ns, Name: pod1.Name}) ^ pkg/controller/endpointslice/endpointslice_controller_test.go:387:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err, "Expected no error syncing service") ^ pkg/controller/endpointslice/endpointslice_controller_test.go:418:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err, "Expected no error syncing service") ^ pkg/controller/endpointslice/endpointslice_controller_test.go:508:2: error-nil: use assert.NoError (testifylint) assert.Nil(t, err, "Expected no error syncing service") ^ pkg/controller/endpointslice/endpointslice_controller_test.go:1295:4: error-nil: use assert.NoError (testifylint) assert.Nil(t, err, "Expected no error creating service") ^ pkg/controller/endpointslice/endpointslice_controller_test.go:1299:4: error-nil: use assert.NoError (testifylint) assert.Nil(t, err) ^ pkg/controller/endpointslice/endpointslice_controller_test.go:1304:4: error-nil: use assert.NoError (testifylint) assert.Nil(t, err, "Expected no error fetching endpoint slices") ^ pkg/controller/endpointslice/endpointslice_controller_test.go:1687:5: error-nil: use assert.NoError (testifylint) assert.Nil(t, err, "error while retrieving old value of %q: %v", update.podName, err) ^ pkg/controller/endpointslice/endpointslice_controller_test.go:1688:5: bool-compare: use assert.True (testifylint) assert.Equal(t, true, exists, "pod should exist") ^ pkg/controller/garbagecollector/garbagecollector_test.go:107:2: empty: use assert.Empty (testifylint) assert.Equal(t, 0, len(gc.dependencyGraphBuilder.monitors)) ^ pkg/controller/garbagecollector/garbagecollector_test.go:115:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(gc.dependencyGraphBuilder.monitors)) ^ pkg/controller/garbagecollector/garbagecollector_test.go:121:2: len: use assert.Len (testifylint) assert.Equal(t, 1, len(gc.dependencyGraphBuilder.monitors)) ^ pkg/controller/garbagecollector/garbagecollector_test.go:129:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(gc.dependencyGraphBuilder.monitors)) ^ pkg/controller/garbagecollector/garbagecollector_test.go:135:2: len: use assert.Len (testifylint) assert.Equal(t, 1, len(gc.dependencyGraphBuilder.monitors)) ^ pkg/controller/podautoscaler/horizontal_test.go:3866:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, calculated, int32(2)) ^ pkg/controller/podautoscaler/horizontal_test.go:3888:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, calculated, int32(3)) ^ ```| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
local |
9.196 ± 0.067 | 9.092 | 9.313 | 1.00 ± 0.01 |
v1.59.1 |
9.179 ± 0.082 | 9.074 | 9.320 | 1.00 |
go-acme/lego
local
``` ```v1.59.1
``` ```| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
local |
1.745 ± 0.063 | 1.682 | 1.915 | 1.02 ± 0.04 |
v1.59.1 |
1.709 ± 0.023 | 1.672 | 1.756 | 1.00 |
pact-foundation/pact-go
local
``` consumer/http_v4_test.go:18:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ consumer/http_v4_test.go:51:2: require-error: for error assertions use require (testifylint) assert.Error(t, err) ^ installer/installer_test.go:20:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ installer/installer_test.go:78:5: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ internal/native/message_server_test.go:206:2: len: use assert.Len (testifylint) assert.Equal(t, 1, len(bytes)) ^ internal/native/message_server_test.go:309:2: len: use assert.Len (testifylint) assert.Equal(t, 1, len(response_bytes)) ^ internal/native/message_server_test.go:418:3: empty: use assert.Empty (testifylint) assert.Len(t, mismatches, 0) ^ internal/native/message_server_test.go:489:3: empty: use assert.Empty (testifylint) assert.Len(t, mismatches, 0) ^ internal/native/mock_server_test.go:217:3: empty: use assert.Empty (testifylint) assert.Len(t, mismatches, 0) ^ internal/native/message_server_test.go:272:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ internal/native/message_server_test.go:293:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ internal/native/message_server_test.go:296:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ internal/native/message_server_test.go:302:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ internal/native/message_server_test.go:307:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ internal/native/message_server_test.go:215:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ ```v1.59.1
``` consumer/http_v4_test.go:18:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ consumer/http_v4_test.go:51:2: require-error: for error assertions use require (testifylint) assert.Error(t, err) ^ installer/installer_test.go:78:5: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ installer/installer_test.go:20:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ internal/native/message_server_test.go:206:2: len: use assert.Len (testifylint) assert.Equal(t, 1, len(bytes)) ^ internal/native/message_server_test.go:309:2: len: use assert.Len (testifylint) assert.Equal(t, 1, len(response_bytes)) ^ internal/native/message_server_test.go:418:3: empty: use assert.Empty (testifylint) assert.Len(t, mismatches, 0) ^ internal/native/message_server_test.go:489:3: empty: use assert.Empty (testifylint) assert.Len(t, mismatches, 0) ^ internal/native/mock_server_test.go:217:3: empty: use assert.Empty (testifylint) assert.Len(t, mismatches, 0) ^ internal/native/message_server_test.go:336:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ internal/native/message_server_test.go:339:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ internal/native/message_server_test.go:345:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ internal/native/mock_server_test.go:169:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ internal/native/mock_server_test.go:196:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ internal/native/mock_server_test.go:199:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ ```| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
local |
439.9 ± 7.9 | 427.8 | 454.5 | 1.07 ± 0.06 |
v1.59.1 |
411.2 ± 19.9 | 393.7 | 463.3 | 1.00 |
rclone/rclone
local
``` fstest/fstest.go:122:2: formatter: remove unnecessary fmt.Sprintf (testifylint) assert.True(t, ok, fmt.Sprintf("%s: Modification time difference too big |%s| > %s (want %s vs got %s) (precision %s)", remote, dt, precision, want, got, precision)) ^ fstest/fstest.go:138:3: formatter: remove unnecessary fmt.Sprintf (testifylint) assert.True(t, hash.Equals(i.Hashes[Hash], sum), fmt.Sprintf("%s/%s: %v hash incorrect - expecting %q got %q", obj.Fs().String(), obj.Remote(), Hash, i.Hashes[Hash], sum)) ^ fstest/fstest.go:145:2: formatter: remove unnecessary fmt.Sprintf (testifylint) assert.Equal(t, i.Size, obj.Size(), fmt.Sprintf("%s: size incorrect file=%d vs obj=%d", i.Path, i.Size, obj.Size())) ^ fstest/fstest.go:186:3: formatter: remove unnecessary fmt.Sprintf (testifylint) assert.True(t, ok, fmt.Sprintf("Unexpected file %q", remote)) ^ fstest/fstest.go:201:2: empty: use assert.Empty (testifylint) assert.Equal(t, 0, len(is.byName), fmt.Sprintf("%d objects not found", len(is.byName))) ^ fstest/fstest.go:300:2: formatter: remove unnecessary fmt.Sprintf (testifylint) assert.True(t, listingOK, fmt.Sprintf("listing wrong, want\n %s got\n %s", wantListing, gotListing)) ^ fstest/fstest.go:375:2: formatter: remove unnecessary fmt.Sprintf (testifylint) assert.True(t, listingOK, fmt.Sprintf("%s not equal, want\n %s got\n %s", what, wantListing, gotListing)) ^ cmd/serve/servetest/servetest.go:36:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ cmd/serve/servetest/servetest.go:40:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ fstest/fstests/fstests.go:456:2: formatter: remove unnecessary fmt.Sprintf (testifylint) require.NoError(t, err, fmt.Sprintf("unexpected error: %v", err)) ^ fstest/fstests/fstests.go:460:2: formatter: remove unnecessary fmt.Sprintf (testifylint) require.NoError(t, err, fmt.Sprintf("unexpected error: %v", err)) ^ fstest/fstests/fstests.go:509:3: negative-positive: use assert.Positive (testifylint) assert.True(t, len(fsInfo.CommandHelp) > 0, "Command is declared, must return some help in CommandHelp") ^ fstest/fstests/fstests.go:753:4: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ fstest/fstests/fstests.go:1063:5: empty: use require.Empty (testifylint) require.Len(t, dirs, 0) ^ fstest/fstests/fstests.go:1131:5: formatter: remove unnecessary fmt.Sprintf (testifylint) assert.True(t, err == fs.ErrorIsDir || err == fs.ErrorObjectNotFound, fmt.Sprintf("Wrong error: expecting fs.ErrorIsDir or fs.ErrorObjectNotFound but got: %#v", err)) ^ fstest/fstests/fstests.go:1255:5: formatter: remove unnecessary fmt.Sprintf (testifylint) require.NoError(t, err, fmt.Sprintf("Error: %#v", err)) ^ fstest/fstests/fstests.go:1467:5: error-is-as: use assert.ErrorIs (testifylint) assert.True(t, errors.Is(err, fs.ErrorDirNotFound)) ^ fstest/fstests/fstests.go:2083:6: error-nil: use assert.NoError (testifylint) assert.Nil(t, err) ^ fstest/fstests/fstests.go:1217:5: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ fstest/fstests/fstests.go:928:5: require-error: for error assertions use require (testifylint) assert.NoError(t, o.Remove(ctx)) ^ fstest/fstests/fstests.go:639:6: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ fstest/fstests/fstests.go:702:6: require-error: for error assertions use require (testifylint) assert.NoError(t, f.Mkdir(ctx, dirName)) ^ fstest/fstests/fstests.go:782:4: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ fstest/fstests/fstests.go:785:4: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ fstest/fstests/fstests.go:788:4: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ fstest/fstests/fstests.go:791:4: require-error: for error assertions use require (testifylint) assert.NoError(t, out.Close()) ^ backend/b2/b2_internal_test.go:324:4: compares: use require.GreaterOrEqual (testifylint) require.True(t, lastColon >= 0) ^ backend/cache/cache_internal_test.go:253:2: empty: use require.Empty (testifylint) require.Len(t, listRoot, 0) ^ backend/cache/cache_internal_test.go:446:3: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, coSize, expectedSize) ^ backend/chunker/chunker_internal_test.go:392:4: len: use assert.Len (testifylint) assert.Equal(t, 1, len(o.chunks)) ^ backend/chunker/chunker_internal_test.go:397:4: len: use assert.Len (testifylint) assert.Equal(t, 1, len(o.chunks)) ^ backend/chunker/chunker_internal_test.go:402:4: empty: use assert.Empty (testifylint) assert.Equal(t, 0, len(o.chunks)) ^ backend/chunker/chunker_internal_test.go:437:3: expected-actual: need to reverse actual and expected values (testifylint) assert.NotEqual(t, sum, "") ^ backend/chunker/chunker_internal_test.go:499:3: compares: use require.NotEqual (testifylint) require.True(t, billyTxn != "") ^ backend/chunker/chunker_internal_test.go:501:3: compares: use require.Equal (testifylint) require.True(t, billyTxn == "") ^ backend/chunker/chunker_internal_test.go:733:2: len: use assert.Len (testifylint) assert.Equal(t, 1, len(ls)) ^ backend/chunker/chunker_internal_test.go:764:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ backend/chunker/chunker_internal_test.go:893:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(list)) ^ backend/crypt/cipher_test.go:33:3: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, actual, test.expected) ^ backend/crypt/cipher_test.go:43:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, NameEncryptionOff.String(), "off") ^ backend/crypt/cipher_test.go:44:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, NameEncryptionStandard.String(), "standard") ^ backend/crypt/cipher_test.go:45:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, NameEncryptionObfuscated.String(), "obfuscate") ^ backend/crypt/cipher_test.go:46:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, NameEncryptionMode(3).String(), "Unknown mode #3") ^ backend/crypt/cipher_test.go:59:3: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, actual, test.expected, fmt.Sprintf("in=%q", test.in)) ^ backend/crypt/cipher_test.go:538:4: error-nil: use assert.NoError (testifylint) assert.Equal(t, err, nil, what) ^ backend/crypt/cipher_test.go:598:4: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, actual, test.expected) ^ backend/crypt/cipher_test.go:1575:2: error-nil: use assert.NoError (testifylint) assert.Equal(t, nil, fh.err) ^ backend/drive/drive_internal_test.go:144:3: bool-compare: use assert.True (testifylint) assert.Equal(t, true, gotIsDocument) ^ backend/drive/drive_internal_test.go:221:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, rateLimitErr, expectedRLError) ^ backend/drive/drive_internal_test.go:395:3: len: use require.Len (testifylint) require.Equal(t, 1, len(entries)) ^ ```v1.59.1
``` fstest/fstest.go:201:2: empty: use assert.Empty (testifylint) assert.Equal(t, 0, len(is.byName), fmt.Sprintf("%d objects not found", len(is.byName))) ^ cmd/serve/servetest/servetest.go:36:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ cmd/serve/servetest/servetest.go:40:2: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ fstest/fstests/fstests.go:509:3: negative-positive: use assert.Positive (testifylint) assert.True(t, len(fsInfo.CommandHelp) > 0, "Command is declared, must return some help in CommandHelp") ^ fstest/fstests/fstests.go:753:4: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ fstest/fstests/fstests.go:1063:5: empty: use require.Empty (testifylint) require.Len(t, dirs, 0) ^ fstest/fstests/fstests.go:1467:5: error-is-as: use assert.ErrorIs (testifylint) assert.True(t, errors.Is(err, fs.ErrorDirNotFound)) ^ fstest/fstests/fstests.go:2083:6: error-nil: use assert.NoError (testifylint) assert.Nil(t, err) ^ fstest/fstests/fstests.go:928:5: require-error: for error assertions use require (testifylint) assert.NoError(t, o.Remove(ctx)) ^ fstest/fstests/fstests.go:782:4: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ fstest/fstests/fstests.go:785:4: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ fstest/fstests/fstests.go:788:4: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ fstest/fstests/fstests.go:791:4: require-error: for error assertions use require (testifylint) assert.NoError(t, out.Close()) ^ fstest/fstests/fstests.go:702:6: require-error: for error assertions use require (testifylint) assert.NoError(t, f.Mkdir(ctx, dirName)) ^ fstest/fstests/fstests.go:1958:7: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ fstest/fstests/fstests.go:639:6: require-error: for error assertions use require (testifylint) assert.NoError(t, err) ^ backend/b2/b2_internal_test.go:324:4: compares: use require.GreaterOrEqual (testifylint) require.True(t, lastColon >= 0) ^ backend/cache/cache_internal_test.go:253:2: empty: use require.Empty (testifylint) require.Len(t, listRoot, 0) ^ backend/cache/cache_internal_test.go:446:3: expected-actual: need to reverse actual and expected values (testifylint) require.NotEqual(t, coSize, expectedSize) ^ backend/chunker/chunker_internal_test.go:392:4: len: use assert.Len (testifylint) assert.Equal(t, 1, len(o.chunks)) ^ backend/chunker/chunker_internal_test.go:397:4: len: use assert.Len (testifylint) assert.Equal(t, 1, len(o.chunks)) ^ backend/chunker/chunker_internal_test.go:402:4: empty: use assert.Empty (testifylint) assert.Equal(t, 0, len(o.chunks)) ^ backend/chunker/chunker_internal_test.go:437:3: expected-actual: need to reverse actual and expected values (testifylint) assert.NotEqual(t, sum, "") ^ backend/chunker/chunker_internal_test.go:499:3: compares: use require.NotEqual (testifylint) require.True(t, billyTxn != "") ^ backend/chunker/chunker_internal_test.go:501:3: compares: use require.Equal (testifylint) require.True(t, billyTxn == "") ^ backend/chunker/chunker_internal_test.go:733:2: len: use assert.Len (testifylint) assert.Equal(t, 1, len(ls)) ^ backend/chunker/chunker_internal_test.go:764:2: error-nil: use assert.Error (testifylint) assert.NotNil(t, err) ^ backend/chunker/chunker_internal_test.go:893:2: len: use assert.Len (testifylint) assert.Equal(t, 2, len(list)) ^ backend/crypt/cipher_test.go:33:3: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, actual, test.expected) ^ backend/crypt/cipher_test.go:43:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, NameEncryptionOff.String(), "off") ^ backend/crypt/cipher_test.go:44:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, NameEncryptionStandard.String(), "standard") ^ backend/crypt/cipher_test.go:45:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, NameEncryptionObfuscated.String(), "obfuscate") ^ backend/crypt/cipher_test.go:46:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, NameEncryptionMode(3).String(), "Unknown mode #3") ^ backend/crypt/cipher_test.go:59:3: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, actual, test.expected, fmt.Sprintf("in=%q", test.in)) ^ backend/crypt/cipher_test.go:538:4: error-nil: use assert.NoError (testifylint) assert.Equal(t, err, nil, what) ^ backend/crypt/cipher_test.go:598:4: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, actual, test.expected) ^ backend/crypt/cipher_test.go:1575:2: error-nil: use assert.NoError (testifylint) assert.Equal(t, nil, fh.err) ^ backend/drive/drive_internal_test.go:144:3: bool-compare: use assert.True (testifylint) assert.Equal(t, true, gotIsDocument) ^ backend/drive/drive_internal_test.go:221:2: expected-actual: need to reverse actual and expected values (testifylint) assert.Equal(t, rateLimitErr, expectedRLError) ^ backend/drive/drive_internal_test.go:395:3: len: use require.Len (testifylint) require.Equal(t, 1, len(entries)) ^ backend/drive/drive_internal_test.go:461:2: bool-compare: use require.True (testifylint) require.Equal(t, true, f.opt.UseTrash) ^ backend/drive/drive_internal_test.go:540:3: empty: use assert.Empty (testifylint) assert.Len(t, results, 0) ^ backend/drive/drive_internal_test.go:554:4: negative-positive: use require.Positive (testifylint) require.True(t, len(results) > 0) ^ backend/drive/drive_internal_test.go:556:5: negative-positive: use assert.Positive (testifylint) assert.True(t, len(result.Id) > 0) ^ backend/dropbox/dbhash/dbhash_test.go:36:4: error-nil: use assert.NoError (testifylint) assert.Nil(t, err) ^ backend/dropbox/dbhash/dbhash_test.go:40:3: error-nil: use assert.NoError (testifylint) assert.Nil(t, err) ^ backend/googlephotos/albums_test.go:287:2: bool-compare: use assert.True (testifylint) assert.Equal(t, true, ok) ^ backend/googlephotos/albums_test.go:291:2: bool-compare: use assert.False (testifylint) assert.Equal(t, false, ok) ^ backend/googlephotos/albums_test.go:305:2: bool-compare: use assert.True (testifylint) assert.Equal(t, true, ok) ^ backend/googlephotos/albums_test.go:309:2: bool-compare: use assert.False (testifylint) assert.Equal(t, false, ok) ^ ```| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
local |
2.207 ± 0.057 | 2.142 | 2.334 | 1.01 ± 0.03 |
v1.59.1 |
2.183 ± 0.048 | 2.133 | 2.278 | 1.00 |
hashicorp/terraform
local
``` ```v1.59.1
``` ```| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
local |
2.920 ± 0.060 | 2.851 | 3.048 | 1.02 ± 0.03 |
v1.59.1 |
2.875 ± 0.043 | 2.817 | 2.950 | 1.00 |
traefik/traefik
local
``` integration/tracing_test.go:457:2: empty: use s.NotEmptyf (testifylint) s.NotEmptyf(len(out.Traces), "expected at least one trace") ^ integration/tracing_test.go:499:2: empty: use s.NotEmptyf (testifylint) s.NotEmptyf(len(out.Traces), "expected at least one trace") ^ pkg/middlewares/accesslog/logger_test.go:202:5: formatter: remove unnecessary fmt.Sprintf (testifylint) require.NoError(t, err, fmt.Sprintf("logger should create %s", config.FilePath)) ^ pkg/middlewares/accesslog/logger_test.go:707:3: empty: use assert.Empty (testifylint) assert.Zero(t, len(logData)) ^ pkg/middlewares/accesslog/logger_test.go:764:3: formatter: remove unnecessary fmt.Sprintf (testifylint) require.NoError(t, err, fmt.Sprintf("logger should create %s", config.FilePath)) ^ ```v1.59.1
``` ```| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
local |
2.859 ± 0.044 | 2.795 | 2.924 | 1.01 ± 0.02 |
v1.59.1 |
2.821 ± 0.054 | 2.742 | 2.892 | 1.00 |
You can find the workflow here: https://github.com/ldez/golangci-lint-bench/actions/runs/9622440029
{ "pr": 4836, "linter": "testifylint", "version": "v1.59.1" }