github-actions[bot]
commented
2 weeks ago Benchmark PR (new linter) Something went wrong!
Details: https://github.com/ldez/golangci-lint-bench/actions/runs/9569875763
Closed ldez closed 2 weeks ago
github-actions[bot]
commented
2 weeks ago Benchmark PR (new linter) Something went wrong!
Details: https://github.com/ldez/golangci-lint-bench/actions/runs/9569875763
github-actions[bot]
commented
2 weeks ago Benchmark PR (new linter) Something went wrong!
Details: https://github.com/ldez/golangci-lint-bench/actions/runs/9569908282
github-actions[bot]
commented
2 weeks ago Benchmark PR (new linter) The benchmark is done!
You can find the workflow here: https://github.com/ldez/golangci-lint-bench/actions/runs/9570074159
github-actions[bot]
commented
2 weeks ago Benchmark PR (new linter) The benchmark is done!
You can find the workflow here: https://github.com/ldez/golangci-lint-bench/actions/runs/9570120213
github-actions[bot]
commented
2 weeks ago Benchmark PR (new linter) Something went wrong!
Details: https://github.com/ldez/golangci-lint-bench/actions/runs/9570489919
github-actions[bot]
commented
2 weeks ago Benchmark PR (new linter) The benchmark is done!
You can find the workflow here: https://github.com/ldez/golangci-lint-bench/actions/runs/9570509991
github-actions[bot]
commented
2 weeks ago Benchmark PR (new linter) Something went wrong!
Details: https://github.com/ldez/golangci-lint-bench/actions/runs/9570598105
github-actions[bot]
commented
2 weeks ago Benchmark PR (new linter) The benchmark is done!
You can find the workflow here: https://github.com/ldez/golangci-lint-bench/actions/runs/9570598105
github-actions[bot]
commented
2 weeks ago Benchmark PR (new linter) The benchmark is done!
You can find the workflow here: https://github.com/ldez/golangci-lint-bench/actions/runs/9574861535
github-actions[bot]
commented
2 weeks ago Benchmark PR (new linter) Something went wrong!
Details: https://github.com/ldez/golangci-lint-bench/actions/runs/9604668213
github-actions[bot]
commented
2 weeks ago Benchmark PR (new linter) The benchmark is done!
You can find the workflow here: https://github.com/ldez/golangci-lint-bench/actions/runs/9604693368
github-actions[bot]
commented
2 weeks ago Benchmark PR (new linter) The benchmark is done!
server/web/controller_test.go:142:2: os.TempDir() should be replaced by `t.TempDir()` in TestAdditionalViewPaths (ttempdir)
tmpDir := os.TempDir()
^
server/web/template_test.go:52:2: os.TempDir() should be replaced by `t.TempDir()` in TestTemplate (ttempdir)
tmpDir := os.TempDir()
^
server/web/template_test.go:116:2: os.TempDir() should be replaced by `t.TempDir()` in TestRelativeTemplate (ttempdir)
tmpDir := os.TempDir()
^bugtool/cmd/helper_test.go:87:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestWalkPath (ttempdir)
nestedDir, err := os.MkdirTemp(baseDir, "nested")
^
bugtool/cmd/root_test.go:25:3: os.MkdirTemp() should be replaced by `t.TempDir()` in anonymous function (ttempdir)
if _, err := os.MkdirTemp(tempdir, ""); err != nil {
^
clustermesh-apiserver/clustermesh/users_mgmt_test.go:75:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestUsersManagement (ttempdir)
tmpdir, err := os.MkdirTemp("", "clustermesh-config")
^
pkg/endpoint/restore_test.go:87:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestReadEPsFromDirNames (ttempdir)
tmpDir, err := os.MkdirTemp("", "cilium-tests")
^
pkg/endpoint/restore_test.go:160:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestReadEPsFromDirNamesWithRestoreFailure (ttempdir)
tmpDir, err := os.MkdirTemp("", "cilium-tests")
^
pkg/endpoint/restore_test.go:227:2: os.MkdirTemp() should be replaced by `b.TempDir()` in BenchmarkReadEPsFromDirNames (ttempdir)
tmpDir, err := os.MkdirTemp("", "cilium-tests")
^
pkg/envoy/embedded_envoy_test.go:53:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestEnvoy (ttempdir)
testRunDir, err := os.MkdirTemp("", "envoy_go_test")
^
pkg/envoy/embedded_envoy_test.go:158:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestEnvoyNACK (ttempdir)
testRunDir, err := os.MkdirTemp("", "envoy_go_test")
^
pkg/hubble/relay/pool/client_test.go:50:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestGRPCClientConnBuilder_CertificateChange (ttempdir)
dir, err := os.MkdirTemp("", t.Name())
^
pkg/mountinfo/mountinfo_privileged_test.go:23:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestIsMountFSbyMount (ttempdir)
tmpDir, err := os.MkdirTemp("", "IsMountFS_")
^
pkg/testutils/bpffs.go:17:2: os.MkdirTemp() should be replaced by `tb.TempDir()` in TempBPFFS (ttempdir)
tmp, err := os.MkdirTemp("/sys/fs/bpf", "cilium-test")
^
pkg/testutils/cgroup.go:56:2: os.MkdirTemp() should be replaced by `tb.TempDir()` in TempCgroup (ttempdir)
cgdir, err := os.MkdirTemp(cg2, "cilium-test")
^
plugins/cilium-cni/types/types_test.go:20:2: os.MkdirTemp() should be replaced by `t.TempDir()` in testConfRead (ttempdir)
dir, err := os.MkdirTemp("", "cilium-cnitype-testsuite")
^
plugins/cilium-cni/types/types_test.go:303:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestReadCNIConfError (ttempdir)
dir, err := os.MkdirTemp("", "cilium-cnitype-testsuite")
^fish_completions_test.go:121:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestFailGenFishCompletionFile (ttempdir)
tmpDir, err := os.MkdirTemp("", "cobra-test")
^
doc/man_docs_test.go:171:2: ioutil.TempDir() should be replaced by `t.TempDir()` in TestGenManTree (ttempdir)
tmpdir, err := ioutil.TempDir("", "test-gen-man-tree")
^
doc/md_docs_test.go:97:2: ioutil.TempDir() should be replaced by `t.TempDir()` in TestGenMdTree (ttempdir)
tmpdir, err := ioutil.TempDir("", "test-gen-md-tree")
^
doc/rest_docs_test.go:84:2: ioutil.TempDir() should be replaced by `t.TempDir()` in TestGenRSTTree (ttempdir)
tmpdir, err := ioutil.TempDir("", "test-gen-rst-tree")
^
doc/yaml_docs_test.go:61:2: ioutil.TempDir() should be replaced by `t.TempDir()` in TestGenYamlTree (ttempdir)
tmpdir, err := ioutil.TempDir("", "test-gen-yaml-tree")
^agent/config/builder_test.go:75:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestNewBuilder_PopulatesSourcesFromConfigFiles (ttempdir)
path, err := os.MkdirTemp("", t.Name())
^
agent/connect/testing_ca_test.go:39:2: os.MkdirTemp() should be replaced by `t.TempDir()` in testCAAndLeaf (ttempdir)
td, err := os.MkdirTemp("", "consul")
^
agent/connect/testing_ca_test.go:71:2: os.MkdirTemp() should be replaced by `t.TempDir()` in testCAAndLeaf_xc (ttempdir)
td, err := os.MkdirTemp("", "consul")
^
agent/consul/acl_endpoint_test.go:3089:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestACLEndpoint_AuthMethodSet (ttempdir)
tempDir, err := os.MkdirTemp("", "consul")
^
agent/hcp/bootstrap/config-loader/loader_test.go:154:3: os.MkdirTemp() should be replaced by `t.TempDir()` in anonymous function (ttempdir)
dir, err := os.MkdirTemp(os.TempDir(), "bootstrap-test-")
^
agent/hcp/bootstrap/config-loader/loader_test.go:348:3: os.MkdirTemp() should be replaced by `t.TempDir()` in anonymous function (ttempdir)
dataDir, err := os.MkdirTemp(os.TempDir(), "load-bootstrap-test-")
^
lib/file/atomic_test.go:18:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestWriteAtomic (ttempdir)
td, err := os.MkdirTemp("", "lib-file")
^cmd/dlv/dlv_test.go:1429:2: os.TempDir() should be replaced by `t.TempDir()` in TestUnixDomainSocket (ttempdir)
tmpdir := os.TempDir()
^
pkg/proc/proc_test.go:2828:2: os.TempDir() should be replaced by `t.TempDir()` in TestWorkDir (ttempdir)
wd := os.TempDir()
^modules/util/legacy_test.go:20:2: os.TempDir() should be replaced by `t.TempDir()` in TestCopyFile (ttempdir)
tmpDir := os.TempDir()
^
tests/integration/dump_restore_test.go:47:3: os.MkdirTemp() should be replaced by `t.TempDir()` in anonymous function (ttempdir)
basePath, err := os.MkdirTemp("", reponame)
^internal/git/git_test.go:49:30: os.TempDir() should be replaced by `t.TempDir()` in TestRepo (ttempdir)
require.NoError(t, os.Chdir(os.TempDir()))
^authz/grpc_authz_server_interceptors_test.go:36:2: os.MkdirTemp() should be replaced by `t.TempDir()` in createTmpPolicyFile (ttempdir)
dir, err := os.MkdirTemp("", dirSuffix)
^
credentials/tls/certprovider/pemfile/watcher_test.go:176:2: os.MkdirTemp() should be replaced by `t.TempDir()` in createTmpDirWithFiles (ttempdir)
dir, err := os.MkdirTemp("", dirSuffix)
^
credentials/tls/certprovider/pemfile/watcher_test.go:318:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestProvider_UpdateSuccessWithSymlink (ttempdir)
tmpdir, err := os.MkdirTemp("", "test_symlink_*")
^helpers/path_test.go:490:2: os.TempDir() should be replaced by `t.TempDir()` in TestGetTempDir (ttempdir)
dir := os.TempDir()
^cmd/kubeadm/test/util.go:34:2: os.MkdirTemp() should be replaced by `t.TempDir()` in SetupTempDir (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
test/integration/framework/test_server.go:73:2: os.MkdirTemp() should be replaced by `t.TempDir()` in StartTestServer (ttempdir)
certDir, err := os.MkdirTemp("", "test-integration-"+strings.ReplaceAll(t.Name(), "/", "_"))
^
cluster/gce/gci/audit_policy_test.go:43:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestCreateMasterAuditPolicy (ttempdir)
baseDir, err := os.MkdirTemp("", "configure-helper-test") // cleaned up by c.tearDown()
^
cluster/gce/gci/configure_helper_test.go:58:2: os.MkdirTemp() should be replaced by `t.TempDir()` in newManifestTestCase (ttempdir)
d, err := os.MkdirTemp("", "configure-helper-test")
^
cluster/images/etcd/migrate/data_dir_test.go:158:2: os.MkdirTemp() should be replaced by `t.TempDir()` in newTestPath (ttempdir)
path, err := os.MkdirTemp("", "etcd-migrate-test-")
^
cmd/kube-scheduler/app/server_test.go:49:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestSetup (ttempdir)
tmpDir, err := os.MkdirTemp("", "scheduler-options")
^
cmd/kube-scheduler/app/options/configfile_test.go:58:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestLoadConfigFromFile (ttempdir)
tmpDir, err := os.MkdirTemp("", "scheduler-configs")
^
cmd/kube-scheduler/app/options/options_test.go:49:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestSchedulerOptions (ttempdir)
tmpDir, err := os.MkdirTemp("", "scheduler-options")
^
cmd/kubeadm/app/cmd/config_test.go:105:4: os.MkdirTemp() should be replaced by `t.TempDir()` in anonymous function (ttempdir)
tmpDir, err := os.MkdirTemp("", "kubeadm-images-test")
^
cmd/kubeadm/app/cmd/init_test.go:77:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestNewInitData (ttempdir)
tmpDir, err := os.MkdirTemp("", "kubeadm-init-test")
^
cmd/kubeadm/app/cmd/join_test.go:62:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestNewJoinData (ttempdir)
tmpDir, err := os.MkdirTemp("", "kubeadm-join-test")
^
cmd/kubeadm/app/cmd/reset_test.go:52:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestNewResetData (ttempdir)
tmpDir, err := os.MkdirTemp("", "kubeadm-reset-test")
^
cmd/kubeadm/app/cmd/token_test.go:203:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestNewCmdToken (ttempdir)
tmpDir, err := os.MkdirTemp("", "kubeadm-token-test")
^
cmd/kubeadm/app/cmd/token_test.go:267:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestGetClientSet (ttempdir)
tmpDir, err := os.MkdirTemp("", "kubeadm-token-test")
^
cmd/kubeadm/app/cmd/token_test.go:303:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestRunDeleteTokens (ttempdir)
tmpDir, err := os.MkdirTemp("", "kubeadm-token-test")
^
cmd/kubeadm/app/cmd/phases/reset/cleanupnode_test.go:161:4: os.MkdirTemp() should be replaced by `t.TempDir()` in anonymous function (ttempdir)
tmpDir, err := os.MkdirTemp("", "kubeadm-reset-test")
^
cmd/kubeadm/app/phases/certs/certlist_test.go:151:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestCreateCertificateChain (ttempdir)
dir, err := os.MkdirTemp("", t.Name())
^
cmd/kubeadm/app/phases/certs/certlist_test.go:231:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestCreateKeyAndCSR (ttempdir)
dir, err := os.MkdirTemp("", t.Name())
^
cmd/kubeadm/app/phases/certs/renewal/readwriter_test.go:208:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestFileExists (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/phases/certs/renewal/readwriter_test.go:257:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestPKICertificateReadWriterExists (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/phases/certs/renewal/readwriter_test.go:313:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestKubeConfigReadWriterExists (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/phases/controlplane/volumes_test.go:515:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestGetHostPathVolumesForTheControlPlane (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/phases/kubelet/config_test.go:87:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestApplyKubeletConfigPatches (ttempdir)
dir, err := os.MkdirTemp("", "patches")
^
cmd/kubeadm/app/phases/upgrade/staticpods_test.go:481:4: os.MkdirTemp() should be replaced by `t.TempDir()` in anonymous function (ttempdir)
tempCertsDir, err := os.MkdirTemp("", "kubeadm-certs")
^
cmd/kubeadm/app/phases/upgrade/staticpods_test.go:618:2: os.MkdirTemp() should be replaced by `t.TempDir()` in getTempDir (ttempdir)
dir, err := os.MkdirTemp(os.TempDir(), name)
^
cmd/kubeadm/app/phases/upgrade/staticpods_test.go:1029:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestGetEtcdImageTagFromStaticPod (ttempdir)
manifestsDir, err := os.MkdirTemp("", "GetEtcdImageTagFromStaticPod-test-manifests")
^
cmd/kubeadm/app/preflight/checks_test.go:339:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestDirAvailableCheck (ttempdir)
fileDir, err := os.MkdirTemp("", "dir-avail-check")
^
cmd/kubeadm/app/util/config/cluster_test.go:199:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestGetNodeNameFromKubeletConfig (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/util/config/cluster_test.go:278:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestGetNodeRegistration (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/util/config/cluster_test.go:492:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestGetInitConfigurationFromCluster (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/util/config/initconfiguration_test.go:44:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestLoadInitConfigurationFromFile (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/util/config/joinconfiguration_test.go:29:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestLoadJoinConfigurationFromFile (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/util/config/resetconfiguration_test.go:32:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestLoadResetConfigurationFromFile (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/util/config/upgradeconfiguration_test.go:121:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestLoadUpgradeConfigurationFromFile (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/util/config/upgradeconfiguration_test.go:286:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestLoadOrDefaultUpgradeConfiguration (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/util/kubeconfig/kubeconfig_test.go:146:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestWriteKubeconfigToDisk (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/util/patches/patches_test.go:417:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestGetPatchManagerForPathCache (ttempdir)
tempDir, err := os.MkdirTemp("", testDirPattern)
^
cmd/kubeadm/app/util/pkiutil/pki_helpers_test.go:179:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestWriteCertAndKey (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/util/pkiutil/pki_helpers_test.go:196:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestWriteCert (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/util/pkiutil/pki_helpers_test.go:213:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestWriteCertBundle (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/util/pkiutil/pki_helpers_test.go:228:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestWriteKey (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/util/pkiutil/pki_helpers_test.go:244:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestWritePublicKey (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/util/pkiutil/pki_helpers_test.go:260:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestCertOrKeyExist (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/util/pkiutil/pki_helpers_test.go:319:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestTryLoadCertAndKeyFromDisk (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/util/pkiutil/pki_helpers_test.go:367:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestTryLoadCertFromDisk (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/util/pkiutil/pki_helpers_test.go:415:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestTryLoadCertChainFromDisk (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/app/util/pkiutil/pki_helpers_test.go:868:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestVerifyCertChain (ttempdir)
tmpdir, err := os.MkdirTemp("", "")
^
cmd/kubeadm/test/cmd/init_test.go:32:38: os.TempDir() should be replaced by `t.TempDir()` in runKubeadmInit (ttempdir)
t.Setenv("KUBEADM_INIT_DRYRUN_DIR", os.TempDir())
^
cmd/kubelet/app/server_bootstrap_test.go:51:2: os.MkdirTemp() should be replaced by `t.TempDir()` in Test_buildClientCertificateManager (ttempdir)
testDir, err := os.MkdirTemp("", "kubeletcert")
^
cmd/kubelet/app/server_bootstrap_test.go:137:2: os.MkdirTemp() should be replaced by `t.TempDir()` in Test_buildClientCertificateManager_populateCertDir (ttempdir)
testDir, err := os.MkdirTemp("", "kubeletcert")
^internal/native/message_server_test.go:24:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestHandleBasedMessageTestsWithString (ttempdir)
tmpPactFolder, err := os.MkdirTemp("", "pact-go")
^
internal/native/message_server_test.go:51:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestHandleBasedMessageTestsWithJSON (ttempdir)
tmpPactFolder, err := os.MkdirTemp("", "pact-go")
^
internal/native/message_server_test.go:85:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestHandleBasedMessageTestsWithBinary (ttempdir)
tmpPactFolder, err := os.MkdirTemp("", "pact-go")
^
internal/native/message_server_test.go:350:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestGrpcPluginInteraction (ttempdir)
tmpPactFolder, err := os.MkdirTemp("", "pact-go")
^
internal/native/message_server_test.go:427:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestGrpcPluginInteraction_ErrorResponse (ttempdir)
tmpPactFolder, err := os.MkdirTemp("", "pact-go")
^
internal/native/mock_server_test.go:61:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestMockServer_VerifySuccess (ttempdir)
tmpPactFolder, err := os.MkdirTemp("", "pact-go")
^
internal/native/mock_server_test.go:84:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestMockServer_VerifyFail (ttempdir)
tmpPactFolder, err := os.MkdirTemp("", "pact-go")
^
internal/native/mock_server_test.go:100:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestMockServer_WritePactfile (ttempdir)
tmpPactFolder, err := os.MkdirTemp("", "pact-go")
^
internal/native/mock_server_test.go:129:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestHandleBasedHTTPTests (ttempdir)
tmpPactFolder, err := os.MkdirTemp("", "pact-go")
^
internal/native/mock_server_test.go:168:2: os.MkdirTemp() should be replaced by `t.TempDir()` in TestPluginInteraction (ttempdir)
tmpPactFolder, err := os.MkdirTemp("", "pact-go")
^fs/config/rc_test.go:189:18: os.TempDir() should be replaced by `t.TempDir()` in TestRcPaths (ttempdir)
assert.Equal(t, os.TempDir(), out["temp"])
^internal/command/cliconfig/cliconfig_test.go:63:2: os.TempDir() should be replaced by `t.TempDir()` in TestLoadConfig_non_existing_file (ttempdir)
tmpDir := os.TempDir()
^
internal/configs/configload/testing.go:26:2: ioutil.TempDir() should be replaced by `t.TempDir()` in NewLoaderForTests (ttempdir)
modulesDir, err := ioutil.TempDir("", "tf-configs")
^
internal/initwd/module_install_test.go:921:2: ioutil.TempDir() should be replaced by `t.TempDir()` in tempChdir (ttempdir)
tmpDir, err := ioutil.TempDir("", "terraform-configload")
^You can find the workflow here: https://github.com/ldez/golangci-lint-bench/actions/runs/9604915890
github-actions[bot]
commented
2 weeks ago Benchmark PR (new linter) The benchmark is done!
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
556.6 ± 30.6 | 524.3 | 611.4 | 1.03 ± 0.07 |
goconst |
540.4 ± 23.2 | 516.1 | 597.1 | 1.00 |
durationcheck |
944.9 ± 58.3 | 896.2 | 1105.9 | 1.75 ± 0.13 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
705.7 ± 16.1 | 689.9 | 740.3 | 1.01 ± 0.03 |
goconst |
699.2 ± 14.9 | 686.0 | 735.9 | 1.00 |
durationcheck |
1459.4 ± 12.9 | 1436.4 | 1482.6 | 2.09 ± 0.05 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
922.0 ± 34.5 | 892.2 | 1008.8 | 1.00 |
goconst |
938.6 ± 64.5 | 897.6 | 1116.6 | 1.02 ± 0.08 |
durationcheck |
2273.1 ± 64.1 | 2217.8 | 2433.1 | 2.47 ± 0.12 |
You can find the workflow here: https://github.com/ldez/golangci-lint-bench/actions/runs/9605069188
github-actions[bot]
commented
2 weeks ago Benchmark PR (new linter) The benchmark is done!
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
488.2 ± 6.8 | 476.1 | 497.7 | 1.00 |
goconst |
490.7 ± 3.4 | 482.3 | 494.3 | 1.01 ± 0.02 |
durationcheck |
838.0 ± 55.3 | 793.7 | 979.1 | 1.72 ± 0.12 |
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
ttempdir |
2.679 ± 0.079 | 2.609 | 2.847 | 1.03 ± 0.03 |
goconst |
2.590 ± 0.018 | 2.566 | 2.610 | 1.00 |
durationcheck |
5.096 ± 0.072 | 5.001 | 5.218 | 1.97 ± 0.03 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
243.4 ± 5.5 | 237.6 | 253.2 | 1.01 ± 0.03 |
goconst |
240.5 ± 2.8 | 237.3 | 244.4 | 1.00 |
durationcheck |
329.9 ± 6.3 | 323.8 | 341.4 | 1.37 ± 0.03 |
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
ttempdir |
2.756 ± 0.059 | 2.689 | 2.890 | 1.00 |
goconst |
2.813 ± 0.018 | 2.791 | 2.846 | 1.02 ± 0.02 |
durationcheck |
5.132 ± 0.056 | 5.034 | 5.215 | 1.86 ± 0.05 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
502.0 ± 14.0 | 479.3 | 526.6 | 1.00 |
goconst |
545.0 ± 12.1 | 530.4 | 572.7 | 1.09 ± 0.04 |
durationcheck |
874.6 ± 17.1 | 847.2 | 896.4 | 1.74 ± 0.06 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
317.3 ± 19.9 | 306.5 | 373.4 | 1.00 ± 0.09 |
goconst |
316.7 ± 19.2 | 306.9 | 370.9 | 1.00 |
durationcheck |
557.7 ± 9.1 | 544.5 | 575.4 | 1.76 ± 0.11 |
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
ttempdir |
1.756 ± 0.026 | 1.732 | 1.806 | 1.00 |
goconst |
1.767 ± 0.067 | 1.732 | 1.957 | 1.01 ± 0.04 |
durationcheck |
3.332 ± 0.042 | 3.274 | 3.383 | 1.90 ± 0.04 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
846.7 ± 14.6 | 817.5 | 871.0 | 1.16 ± 0.03 |
goconst |
727.7 ± 11.3 | 713.3 | 743.2 | 1.00 |
durationcheck |
1524.3 ± 36.8 | 1448.3 | 1571.6 | 2.09 ± 0.06 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
544.3 ± 8.4 | 531.4 | 556.6 | 1.02 ± 0.03 |
goconst |
534.7 ± 10.4 | 518.6 | 550.5 | 1.00 |
durationcheck |
914.2 ± 16.6 | 893.8 | 939.3 | 1.71 ± 0.05 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
697.0 ± 17.9 | 676.2 | 736.6 | 1.00 |
goconst |
697.5 ± 23.0 | 678.8 | 761.0 | 1.00 ± 0.04 |
durationcheck |
1442.0 ± 21.3 | 1414.1 | 1483.8 | 2.07 ± 0.06 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
866.1 ± 8.9 | 854.3 | 881.4 | 1.00 |
goconst |
887.5 ± 82.5 | 840.8 | 1088.3 | 1.02 ± 0.10 |
durationcheck |
1477.3 ± 21.0 | 1438.3 | 1503.4 | 1.71 ± 0.03 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
922.6 ± 22.7 | 900.8 | 980.3 | 1.02 ± 0.05 |
goconst |
905.5 ± 37.1 | 874.0 | 1005.5 | 1.00 |
durationcheck |
2264.3 ± 90.3 | 2192.9 | 2504.7 | 2.50 ± 0.14 |
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
ttempdir |
5.420 ± 0.043 | 5.365 | 5.497 | 1.00 |
goconst |
5.464 ± 0.034 | 5.399 | 5.528 | 1.01 ± 0.01 |
durationcheck |
9.274 ± 0.070 | 9.173 | 9.382 | 1.71 ± 0.02 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
818.1 ± 4.6 | 812.3 | 827.5 | 1.01 ± 0.01 |
goconst |
813.9 ± 9.8 | 799.8 | 832.0 | 1.00 |
durationcheck |
1760.9 ± 60.8 | 1719.5 | 1910.2 | 2.16 ± 0.08 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
291.0 ± 14.5 | 282.2 | 331.3 | 1.03 ± 0.06 |
goconst |
283.1 ± 8.1 | 276.5 | 303.0 | 1.00 |
durationcheck |
436.3 ± 6.0 | 428.6 | 446.1 | 1.54 ± 0.05 |
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
ttempdir |
1.173 ± 0.016 | 1.147 | 1.198 | 1.00 |
goconst |
1.236 ± 0.125 | 1.161 | 1.567 | 1.05 ± 0.11 |
durationcheck |
2.103 ± 0.021 | 2.066 | 2.133 | 1.79 ± 0.03 |
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
ttempdir |
1.514 ± 0.022 | 1.491 | 1.567 | 1.00 |
goconst |
1.578 ± 0.057 | 1.516 | 1.712 | 1.04 ± 0.04 |
durationcheck |
3.071 ± 0.136 | 2.929 | 3.411 | 2.03 ± 0.09 |
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
ttempdir |
1.097 ± 0.024 | 1.072 | 1.141 | 1.00 |
goconst |
1.106 ± 0.058 | 1.057 | 1.262 | 1.01 ± 0.06 |
durationcheck |
2.853 ± 0.104 | 2.767 | 3.124 | 2.60 ± 0.11 |
You can find the workflow here: https://github.com/ldez/golangci-lint-bench/actions/runs/9605133828
github-actions[bot]
commented
2 weeks ago Benchmark PR (new linter) The benchmark is done!
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
486.7 ± 8.4 | 477.7 | 507.1 | 1.00 |
goconst |
489.4 ± 9.4 | 479.3 | 513.7 | 1.01 ± 0.03 |
durationcheck |
831.4 ± 50.2 | 796.0 | 962.2 | 1.71 ± 0.11 |
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
ttempdir |
2.682 ± 0.032 | 2.642 | 2.760 | 1.02 ± 0.03 |
goconst |
2.634 ± 0.064 | 2.589 | 2.812 | 1.00 |
durationcheck |
5.280 ± 0.048 | 5.225 | 5.381 | 2.00 ± 0.05 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
246.7 ± 12.0 | 239.7 | 280.4 | 1.03 ± 0.05 |
goconst |
240.6 ± 4.4 | 236.6 | 250.1 | 1.00 |
durationcheck |
328.9 ± 5.1 | 322.9 | 339.7 | 1.37 ± 0.03 |
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
ttempdir |
2.752 ± 0.078 | 2.665 | 2.874 | 1.00 |
goconst |
2.787 ± 0.019 | 2.748 | 2.812 | 1.01 ± 0.03 |
durationcheck |
5.122 ± 0.065 | 5.017 | 5.210 | 1.86 ± 0.06 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
514.4 ± 17.1 | 496.3 | 555.3 | 1.00 |
goconst |
545.5 ± 12.1 | 529.9 | 567.8 | 1.06 ± 0.04 |
durationcheck |
912.8 ± 57.1 | 861.0 | 1056.6 | 1.77 ± 0.13 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
316.8 ± 14.2 | 306.5 | 354.5 | 1.01 ± 0.05 |
goconst |
313.7 ± 5.1 | 308.6 | 324.3 | 1.00 |
durationcheck |
564.8 ± 11.7 | 548.5 | 582.4 | 1.80 ± 0.05 |
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
ttempdir |
1.784 ± 0.017 | 1.762 | 1.808 | 1.00 ± 0.01 |
goconst |
1.777 ± 0.019 | 1.757 | 1.824 | 1.00 |
durationcheck |
3.366 ± 0.027 | 3.325 | 3.414 | 1.89 ± 0.03 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
844.7 ± 27.8 | 803.5 | 901.7 | 1.11 ± 0.11 |
goconst |
758.6 ± 70.0 | 720.0 | 910.1 | 1.00 |
durationcheck |
1513.3 ± 67.3 | 1426.0 | 1658.2 | 1.99 ± 0.20 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
553.6 ± 10.6 | 530.5 | 566.4 | 1.00 |
goconst |
554.4 ± 16.4 | 533.8 | 589.2 | 1.00 ± 0.04 |
durationcheck |
967.3 ± 55.2 | 928.6 | 1114.3 | 1.75 ± 0.11 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
689.2 ± 12.7 | 670.5 | 718.0 | 1.00 |
goconst |
691.0 ± 15.3 | 674.0 | 728.9 | 1.00 ± 0.03 |
durationcheck |
1477.4 ± 66.7 | 1434.2 | 1632.5 | 2.14 ± 0.10 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
864.0 ± 17.0 | 847.1 | 906.9 | 1.00 |
goconst |
864.8 ± 54.2 | 832.0 | 977.5 | 1.00 ± 0.07 |
durationcheck |
1464.3 ± 74.0 | 1401.3 | 1638.0 | 1.69 ± 0.09 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
932.3 ± 31.7 | 894.2 | 1014.4 | 1.00 ± 0.07 |
goconst |
932.2 ± 54.4 | 885.1 | 1080.6 | 1.00 |
durationcheck |
2281.0 ± 71.0 | 2218.5 | 2414.4 | 2.45 ± 0.16 |
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
ttempdir |
5.354 ± 0.054 | 5.269 | 5.457 | 1.00 |
goconst |
5.382 ± 0.038 | 5.337 | 5.465 | 1.01 ± 0.01 |
durationcheck |
9.112 ± 0.059 | 9.033 | 9.201 | 1.70 ± 0.02 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
824.2 ± 6.9 | 810.1 | 833.3 | 1.01 ± 0.01 |
goconst |
816.7 ± 8.6 | 802.5 | 830.6 | 1.00 |
durationcheck |
1779.8 ± 65.4 | 1698.8 | 1922.8 | 2.18 ± 0.08 |
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
ttempdir |
286.0 ± 3.4 | 282.4 | 293.5 | 1.00 |
goconst |
287.0 ± 7.9 | 278.5 | 302.2 | 1.00 ± 0.03 |
durationcheck |
441.2 ± 13.1 | 431.2 | 476.5 | 1.54 ± 0.05 |
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
ttempdir |
1.248 ± 0.172 | 1.146 | 1.693 | 1.05 ± 0.15 |
goconst |
1.194 ± 0.035 | 1.160 | 1.283 | 1.00 |
durationcheck |
2.109 ± 0.022 | 2.078 | 2.145 | 1.77 ± 0.05 |
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
ttempdir |
1.623 ± 0.099 | 1.559 | 1.891 | 1.03 ± 0.07 |
goconst |
1.581 ± 0.044 | 1.545 | 1.696 | 1.00 |
durationcheck |
2.999 ± 0.053 | 2.947 | 3.127 | 1.90 ± 0.06 |
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
ttempdir |
1.142 ± 0.057 | 1.086 | 1.236 | 1.05 ± 0.05 |
goconst |
1.085 ± 0.013 | 1.065 | 1.102 | 1.00 |
durationcheck |
2.866 ± 0.120 | 2.792 | 3.194 | 2.64 ± 0.11 |
You can find the workflow here: https://github.com/ldez/golangci-lint-bench/actions/runs/9605293066
{ "pr": "4794", "linter": "ttempdir" }