search

ldionne / dyno

Runtime polymorphism done right
Boost Software License 1.0
975 stars 43 forks source link

'concept' and 'requires' are keywords in c++2a #56

Closed palebedev closed 5 years ago

palebedev commented 6 years ago

This makes the library unusable with, for example, clang++ -std=c++2a.

I have a local patch that appends underscores to these names, but I'm not sure how much to change in the documentation comments.

ricejasonf commented 5 years ago 
/usr/local/src/emscripten/system/include/dyno/concept.hpp:27:1: error: declaration of anonymous struct
      must be a definition
struct concept;

@palebedev Do you still have that patch?

ricejasonf commented 5 years ago

I made a PR for this https://github.com/ldionne/dyno/pull/58

palebedev commented 5 years ago

No, but it was pretty much your PR sans documentation updates.

ldionne commented 5 years ago

Fixed by #58.