Signature error on splice TX

ldksplicing / ldk-splicing

Unofficial+experimental Splicing feature in LDK

Other

5 stars 1 forks source link

Signature error on splice TX #1

Closed optout21 closed 1 year ago

optout21 commented 1 year ago

Constructed splice TX fails to broadcast:

failed to broadcast a transaction, this is likely okay but may indicate an error: RPC error -26: non-mandatory-script-verify-flag (Signature must be zero for failed CHECK(MULTI)SIG operation)

Reproduce: Start two ldk-sample nodes, open a channel, initiate splice.

optout21 commented 1 year ago

Two issues found:

in the multisig script, pubkeys are always sorted lexigraphically. Signatures have to be provided in the same order.
in the remote peer, when signature is created, channel parameters are already updated, and the new channel value is used in signing the old funding input.