Platform:
Microsoft Visual C++ compiler (Windows).
Steps to reproduce:
1. Open the Visual Studio solution file
(src/client/windows/breakpad_client.sln) using Visual Studio 2005 or 2008.
2. For each project:
- Open the project properties window.
- In the General tab, change the "Character Set" setting from "Unicode"
to "Multi-Byte".
3. Attempt to build the solution.
Expected output:
The projects successfully build.
Realized output:
The projects fail to build due to compiler errors.
Details:
The errors are caused by encoding-dependent macros/types being used in
places where explicit wchar_t functions/types should be used, such as:
- TEXT() macro used in places where an explicit wchar_t string literal
(i.e. L"text") should be used instead.
- Win32 API functions called with wchar_t string arguments via their
encoding-based redirector macros rather than the explicit wide-character
overloads (e.g. LoadLibrary(L"rpcrt4.dll") should instead be
LoadLibraryW(L"rpcrt4.dll")).
- Use of TCHAR type where WCHAR should be used instead.
Patched sources (edited from trunk revision 522) attached.
Original issue reported on code.google.com by louse...@gmail.com on 17 Feb 2010 at 7:14
Original issue reported on code.google.com by
louse...@gmail.comon 17 Feb 2010 at 7:14Attachments: