ldn0x7dc / react-native-gallery

A pure JavaScript image gallery component for react-native apps with common gestures like pan, pinch and doubleTap, supporting both iOS and Android.
331 stars 116 forks source link

offset of images after rotation #2

Open eljago opened 8 years ago

eljago commented 8 years ago

Hello, I just tried the Demo and the images don't seem to be adapting correctly after rotating the device. Happened on both the Simulator and real Device.

simulator screen shot jul 6 2016 2 05 54 am

ldn0x7dc commented 8 years ago

@eljago That's a really good issue. I'll look into it asap.

ldn0x7dc commented 8 years ago

@eljago The latest release(0.0.15) should fix this bug.

chadwilken commented 8 years ago

Getting a similar issue when rotating the device too fast. If I rotate back and forth after getting into this state it goes back to a fullscreen modal. screenshot

ldn0x7dc commented 8 years ago

@chadwilken Hi, I didn't catch your point. Could you pls post more images including:

chadwilken commented 8 years ago

@ldn0x7dc Here is a good screenshot of how it should look. I did notice when it gets messed up tapping the screen a single time fixes it.

Good This is what it looks like on Android if you rotate the device Bad

On iOS here is the proper display in portrait iOSGood Here is proper on Landscape ios This is what it looks like when you rotate quickly all the way around badddd

ldn0x7dc commented 8 years ago

@chadwilken Could you pls check out the latest Demo project and rotate the demo screen to see if it gets broken? I still can't reproduce your issue. I guess you are using a modal to hold the gallery, so I modified the Demo project to simulate your case.

chadwilken commented 8 years ago

@ldn0x7dc the demo project works perfect for ios on android it still is off when you rotate the device to landscape.

chadwilken commented 8 years ago

On Android this is what I get when I run the demo project

android

and after rotating this is what I get

bad

The console logs

console