search

ldn0x7dc / react-native-gallery

A pure JavaScript image gallery component for react-native apps with common gestures like pan, pinch and doubleTap, supporting both iOS and Android.
331 stars 116 forks source link

Doesn't work with React Native 0.50 and React 16.0.0 because of missing React.PropTypes #53

Open serhiipalash opened 6 years ago

serhiipalash commented 6 years ago

React Native 0.50 is the first version to ship with support for React 16.0.0. https://reactjs.org/blog/2017/09/26/react-v16.0.html

PropTypes are missing in React object. Can you import it from prop-types?

screen shot 2017-11-17 at 23 58 16
chrusart commented 6 years ago

https://github.com/archriss/react-native-image-gallery

dflourusso commented 6 years ago

I created a fork and updated the dependencies, go to fork

serhiipalash commented 6 years ago

@dflourusso maybe we should ask NPM to change package owner as this repo is not maintainable any more? NPM has procedure to handle such case.

dflourusso commented 6 years ago

I think it is not maintainable any more because the last commit was made over 2 years ago and no issue was solved or pull request merged. We can try this or create another NPM package name.

dflourusso commented 6 years ago

https://github.com/archriss/react-native-image-gallery is a good solution and works well for IOS, but it does not uses ViewPager for Android resulting in slow performance.

serhiipalash commented 6 years ago

@dflourusso I wrote to NPM. Let's wait for their response.