ldn0x7dc / react-native-media-kit

Video(and audio) component for react-native apps, supporting both iOS and Android. A unified and elegant player controller is provided by default. The API is similar with HTML video.
200 stars 70 forks source link

new UI style, animation on controls, fullscreen callback and title on video --WIP-- #26

Closed Liroo closed 7 years ago

Liroo commented 8 years ago

Hey, I use this package to implement videoview inside our app but there are many gaps that PR can fill.

I reviewed the interface to make it more attractive and easier. So I added cool animations I added a title to the video might appear at the top of the view at the same time as controls. I tried to Implement a full-screen mode but I have not succeeded without adding too many dependencies, and our applications we will manage with Navigation. so I just add a callback and a fullscreen button.

Poster is now press able to start video.

Liroo commented 8 years ago

FullScreen is implemented with Navigator (only view is implemented, not actually seekTo, correct animations, etc...)

EDIT: just see I have to set fullscreen icon controlled

Liroo commented 8 years ago

Check this PR @ldn0x7dc

Liroo commented 8 years ago

Didn't add a gif to README, I don't have enough time :/ My last commit is about how to handle fullscreen in JS with Navigator, there's some bugs but I have to work on another project, please comment this PR if you want to discuss 🍖 😸

kingctan commented 7 years ago

how to pause? trouble with this. please help,thanks. and when switch to fullscreen, 2 videos, and 2 audios, and navigator back to exit, this will always be playing background.

Liroo commented 7 years ago

That was a tentative to play video in full screen but there is definitively not possible without changing the native module... Or getting a native view which can expand (or js view at root). I close this PR w/o answer of the owner of the repo....