search

ldn0x7dc / react-native-view-transformer

A pure JavaScript RN component that makes ANY views transformable using gestures like pinch, double tap or pull.
135 stars 143 forks source link

getImageSize has been fixed on Android? #1

Closed winglight closed 8 years ago

winglight commented 8 years ago

The pixels prop is used to align the edge of the image content with the view's boundry and to determine the max scale.(We can actually use Image.getSize to get pixels info on iOS, but NOT on Android, so for now this prop is needed) -I checked the link provided above and found someone advised to close the issue for solved this problem. Would you guys like to confirm if we don't need the prop "pixel" any more?

ldn0x7dc commented 8 years ago

@winglight Seems the related commit is in the master branch but not available in the latest release(v0.27.1) for now.

winglight commented 8 years ago

oic, i'm waiting...

ldn0x7dc commented 8 years ago

@winglight With RN 0.28, Image.getSize() is available on Android, and we have update our sources to use this feature. So the pixels prop is now optional for remote images.

winglight commented 8 years ago

@ldn0x7dc Great job!

ldn0x7dc commented 8 years ago

We're considering moving ViewTransformer.Image to a dedicated module react-native-transformable-image. This module will continue to serve as a more basic and general transform utility.